public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* rgmanager: master - rgmanager: Fix leaked context on queue fail
@ 2009-06-22 16:55 Lon Hohberger
  0 siblings, 0 replies; only message in thread
From: Lon Hohberger @ 2009-06-22 16:55 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/rgmanager.git?p=rgmanager.git;a=commitdiff;h=a9ff22b81d8f37d7b6a9d52944dbf5da7c978cd8
Commit:        a9ff22b81d8f37d7b6a9d52944dbf5da7c978cd8
Parent:        d01fecb3d36e4539d6bef1d068c182fcfc113ff6
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Fri Jun 19 17:02:53 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Mon Jun 22 12:52:09 2009 -0400

rgmanager: Fix leaked context on queue fail

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/main.c |   19 ++++++++++++++-----
 1 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/rgmanager/src/daemons/main.c b/rgmanager/src/daemons/main.c
index 4082743..8f9fc2f 100644
--- a/rgmanager/src/daemons/main.c
+++ b/rgmanager/src/daemons/main.c
@@ -458,11 +458,20 @@ dispatch_msg(msgctx_t *ctx, int nodeid, int need_close)
 
 		/* Distributed processing and/or request is from master node
 		   -- Queue request */
-		rt_enqueue_request(msg_sm->sm_data.d_svcName,
-		  		   msg_sm->sm_data.d_action,
-		  		   ctx, 0, msg_sm->sm_data.d_svcOwner,
-		  		   msg_sm->sm_hdr.gh_arg1,
-		  		   msg_sm->sm_hdr.gh_arg2);
+		if (rt_enqueue_request(msg_sm->sm_data.d_svcName,
+		      		       msg_sm->sm_data.d_action,
+		      		       ctx, 0, msg_sm->sm_data.d_svcOwner,
+		      		       msg_sm->sm_hdr.gh_arg1,
+		      		       msg_sm->sm_hdr.gh_arg2) != 0) {
+
+			/* Clean up this context if we fail to 
+			 * queue the request. */
+			send_ret(ctx, msg_sm->sm_data.d_svcName,
+				 RG_EAGAIN, msg_sm->sm_data.d_action, 0);
+			need_close = 1;
+			ret = 0;
+			goto out;
+		}
 		return 0;
 
 	case RG_EVENT:


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-22 16:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-06-22 16:55 rgmanager: master - rgmanager: Fix leaked context on queue fail Lon Hohberger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).