public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: rgmanager: master - rgmanager: Fix stop/start race Date: Mon, 22 Jun 2009 16:55:00 -0000 [thread overview] Message-ID: <20090622165443.DBDE012025B@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/rgmanager.git?p=rgmanager.git;a=commitdiff;h=10f9c02038d1086287f1322287a65101c98828e9 Commit: 10f9c02038d1086287f1322287a65101c98828e9 Parent: a9ff22b81d8f37d7b6a9d52944dbf5da7c978cd8 Author: Lon Hohberger <lhh@redhat.com> AuthorDate: Mon Jun 15 14:18:36 2009 -0400 Committer: Lon Hohberger <lhh@redhat.com> CommitterDate: Mon Jun 22 12:52:11 2009 -0400 rgmanager: Fix stop/start race If a thread exits right as rgmanager gets a request to start a new thread, there's a chance that the the starting thread will incorrectly have a reference to the old thread and not retry when it should. Signed-off-by: Lon Hohberger <lhh@redhat.com> --- rgmanager/src/daemons/rg_thread.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/rgmanager/src/daemons/rg_thread.c b/rgmanager/src/daemons/rg_thread.c index 1aa64b3..5d22968 100644 --- a/rgmanager/src/daemons/rg_thread.c +++ b/rgmanager/src/daemons/rg_thread.c @@ -584,6 +584,8 @@ spawn_if_needed(const char *resgroupname) int ret; resthread_t *resgroup = NULL; +retry: + resgroup = NULL; pthread_mutex_lock(&reslist_mutex); while (resgroup == NULL) { resgroup = find_resthread_byname(resgroupname); @@ -601,8 +603,8 @@ spawn_if_needed(const char *resgroupname) ret = (resgroup->rt_status == RG_STATE_STOPPING); pthread_mutex_unlock(&reslist_mutex); - if (wait_initialize(resgroupname) < 0) { - return -1; + if (!ret && wait_initialize(resgroupname) < 0) { + goto retry; } return ret;
reply other threads:[~2009-06-22 16:55 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090622165443.DBDE012025B@lists.fedorahosted.org \ --to=lon@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).