public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: cluster: RHEL4 - rgmanager: Fix stack overflows on stress testing Date: Mon, 22 Jun 2009 18:23:00 -0000 [thread overview] Message-ID: <20090622182321.080141201D4@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=6b4e6f18cfa7a03b1ee1008a019aad077e3954fc Commit: 6b4e6f18cfa7a03b1ee1008a019aad077e3954fc Parent: 175f79e2ad1bac0bdb233eae32f55b8010973813 Author: Lon Hohberger <lhh@redhat.com> AuthorDate: Fri Jun 19 18:20:46 2009 -0400 Committer: Lon Hohberger <lhh@redhat.com> CommitterDate: Mon Jun 22 14:10:41 2009 -0400 rgmanager: Fix stack overflows on stress testing S/Lang requires you to eat all the values on the stack if not assigned, or you can discard all values, but you can't take 2/5 without explicitly discarding the other three. Signed-off-by: Lon Hohberger <lhh@redhat.com> --- rgmanager/src/resources/default_event_script.sl | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/rgmanager/src/resources/default_event_script.sl b/rgmanager/src/resources/default_event_script.sl index cecc1f6..35e0964 100644 --- a/rgmanager/src/resources/default_event_script.sl +++ b/rgmanager/src/resources/default_event_script.sl @@ -11,6 +11,7 @@ define node_in_set(node_list, node) return 0; } + define move_or_start(service, node_list) { variable len; @@ -19,14 +20,14 @@ define move_or_start(service, node_list) depends = service_property(service, "depend"); if (depends != "") { - (owner, state) = service_status(depends); + (,,, owner, state) = service_status(depends); if (owner < 0) { debug(service, " is not runnable; dependency not met"); return ERR_DEPEND; } } - (owner, state) = service_status(service); + (,,, owner, state) = service_status(service); debug("Evaluating ", service, " state=", state, " owner=", owner); len = length(node_list); @@ -86,7 +87,7 @@ define allowed_nodes(service) (nofailback, restricted, ordered, nodes_domain) = service_domain_info(service); - (owner, state) = service_status(service); + (,,, owner, state) = service_status(service); anodes = nodes_online(); @@ -199,7 +200,7 @@ define default_service_event_handler() continue; } - (owner, state) = service_status(services[x]); + (,,, owner, state) = service_status(services[x]); if ((service_state == "started") and (owner < 0) and (state == "stopped")) { info("Dependency met; starting ", services[x]); @@ -232,7 +233,7 @@ define default_user_event_handler() variable owner, state; nodes = allowed_nodes(service_name); - (owner, state) = service_status(service_name); + (,,, owner, state) = service_status(service_name); if (user_request == USER_RESTART) {
reply other threads:[~2009-06-22 18:23 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090622182321.080141201D4@lists.fedorahosted.org \ --to=lon@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).