cluster: RHEL4 - rgmanager: Don't push NULL on to the S/Lang stack

[Lon Hohberger <lon@fedoraproject.org>]

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=692e03a144b871186c76945ab915f476fbf912ab
Commit:        692e03a144b871186c76945ab915f476fbf912ab
Parent:        2707f7fefd49f07a89f52b093be4bef86d2ccf77
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Mon Jun 22 14:14:53 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Mon Jun 22 14:15:32 2009 -0400

rgmanager: Don't push NULL on to the S/Lang stack

Signed-off-by: Lon Hohberger <lhh@redhat.com>
---
 rgmanager/src/daemons/slang_event.c |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)

diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c
index 920752d..c579ff0 100644
--- a/rgmanager/src/daemons/slang_event.c
+++ b/rgmanager/src/daemons/slang_event.c
@@ -433,8 +433,15 @@ sl_service_property(char *svcName, char *prop)
 	if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0)
 		return;
 
-	/* does this work or do I have to push a malloce'd string? */
 	ret = strdup(buf);
+	if (!ret) {
+		SLang_verror(SL_RunTime_Error,
+			     (char *)"%s: Failed to duplicate state of %s",
+			     __FUNCTION__,
+			     svcName);
+		return;
+	}
+
 	if (SLang_push_malloced_string(ret) < 0) {
 		SLang_verror(SL_RunTime_Error,
 			     (char *)"%s: Failed to push %s property of %s",