public inbox for cluster-cvs@sourceware.org help / color / mirror / Atom feed
From: Lon Hohberger <lon@fedoraproject.org> To: cluster-cvs-relay@redhat.com Subject: cluster: RHEL5 - rgmanager: Fix small memory leak Date: Mon, 22 Jun 2009 18:24:00 -0000 [thread overview] Message-ID: <20090622182334.03F9012020D@lists.fedorahosted.org> (raw) Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=09b0c9418c4d8165e897e6a3d2e8fac17d7de046 Commit: 09b0c9418c4d8165e897e6a3d2e8fac17d7de046 Parent: c2600ba9290b8e3d35f4a8d0fb0d2c01c71a6021 Author: Lon Hohberger <lhh@redhat.com> AuthorDate: Fri Jun 19 22:59:53 2009 -0400 Committer: Lon Hohberger <lhh@redhat.com> CommitterDate: Mon Jun 22 14:16:42 2009 -0400 rgmanager: Fix small memory leak Signed-off-by: Lon Hohberger <lhh@redhat.com> --- rgmanager/src/daemons/slang_event.c | 29 ++++++++++++++++++++++++++--- 1 files changed, 26 insertions(+), 3 deletions(-) diff --git a/rgmanager/src/daemons/slang_event.c b/rgmanager/src/daemons/slang_event.c index c3c337c..4f52041 100644 --- a/rgmanager/src/daemons/slang_event.c +++ b/rgmanager/src/daemons/slang_event.c @@ -440,16 +440,23 @@ out: /** get_service_property(service_name, property) */ -char * +static void sl_service_property(char *svcName, char *prop) { char buf[96]; + char *ret; if (get_service_property(svcName, prop, buf, sizeof(buf)) < 0) - return NULL; + return; /* does this work or do I have to push a malloce'd string? */ - return strdup(buf); + ret = strdup(buf); + if (SLang_push_malloced_string(ret) < 0) { + SLang_verror(SL_RunTime_Error, + (char *)"%s: Failed to push %s property of %s", + __FUNCTION__, prop, svcName); + free(ret); + } } @@ -979,6 +986,7 @@ sl_die(void) SLang_Intrin_Fun_Type rgmanager_slang[] = { +<<<<<<< HEAD:rgmanager/src/daemons/slang_event.c MAKE_INTRINSIC_0("nodes_online", sl_nodes_online, SLANG_VOID_TYPE), MAKE_INTRINSIC_0("service_list", sl_service_list, SLANG_VOID_TYPE), @@ -988,6 +996,21 @@ SLang_Intrin_Fun_Type rgmanager_slang[] = MAKE_INTRINSIC_0("service_stop", sl_stop_service, SLANG_INT_TYPE), MAKE_INTRINSIC_0("service_start", sl_start_service, SLANG_INT_TYPE), MAKE_INTRINSIC_S("service_status", sl_service_status, +======= + MAKE_INTRINSIC_0((char *)"nodes_online", sl_nodes_online, + SLANG_VOID_TYPE), + MAKE_INTRINSIC_0((char *)"service_list", sl_service_list, + SLANG_VOID_TYPE), + MAKE_INTRINSIC_SS((char *)"service_property", sl_service_property, + SLANG_VOID_TYPE), + MAKE_INTRINSIC_S((char *)"service_domain_info", sl_domain_info, + SLANG_VOID_TYPE), + MAKE_INTRINSIC_0((char *)"service_stop", sl_stop_service, + SLANG_INT_TYPE), + MAKE_INTRINSIC_0((char *)"service_start", sl_start_service, + SLANG_INT_TYPE), + MAKE_INTRINSIC_S((char *)"service_status", sl_service_status, +>>>>>>> f4f9663... rgmanager: Fix small memory leak:rgmanager/src/daemons/slang_event.c SLANG_VOID_TYPE), MAKE_INTRINSIC_S("service_freeze", sl_service_freeze, SLANG_INT_TYPE),
reply other threads:[~2009-06-22 18:24 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20090622182334.03F9012020D@lists.fedorahosted.org \ --to=lon@fedoraproject.org \ --cc=cluster-cvs-relay@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).