public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: "Fabio M. Di Nitto" <fabbione@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: dlm: master - group: fix void arithmetic
Date: Tue, 23 Jun 2009 09:25:00 -0000	[thread overview]
Message-ID: <20090623090107.3606212037D@lists.fedorahosted.org> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 2793 bytes --]

Gitweb:        http://git.fedorahosted.org/git/dlm.git?p=dlm.git;a=commitdiff;h=e4b3cfe6af126234715bc2bb51c0e4d1c8bab4ab
Commit:        e4b3cfe6af126234715bc2bb51c0e4d1c8bab4ab
Parent:        16daac0e280bae8b2417169ad4dfedf1f8b84282
Author:        Fabio M. Di Nitto <fdinitto@redhat.com>
AuthorDate:    Tue May 12 14:24:42 2009 +0200
Committer:     Fabio M. Di Nitto <fdinitto@redhat.com>
CommitterDate: Tue Jun 23 10:57:19 2009 +0200

group: fix void arithmetic

stable3/group/dlm_controld/main.c: In function ‘do_read’:
stable3/group/dlm_controld/main.c:35: warning: pointer of type ‘void *’ used in arithmetic
stable3/group/dlm_controld/main.c: In function ‘do_write’:
stable3/group/dlm_controld/main.c:52: warning: pointer of type ‘void *’ used in arithmetic

stable3/group/dlm_controld/netlink.c: In function ‘send_genetlink_cmd’:
stable3/group/dlm_controld/netlink.c:44: warning: pointer of type ‘void *’ used in arithmetic
stable3/group/dlm_controld/netlink.c: In function ‘get_family_id’:
stable3/group/dlm_controld/netlink.c:93: warning: pointer of type ‘void *’ used in arithmetic
stable3/group/dlm_controld/netlink.c: In function ‘process_netlink’:
stable3/group/dlm_controld/netlink.c:221: warning: pointer of type ‘void *’ used in arithmetic

Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
---
 group/dlm_controld/main.c    |    4 ++--
 group/dlm_controld/netlink.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/group/dlm_controld/main.c b/group/dlm_controld/main.c
index ec1616a..88f095c 100644
--- a/group/dlm_controld/main.c
+++ b/group/dlm_controld/main.c
@@ -32,7 +32,7 @@ int do_read(int fd, void *buf, size_t count)
 	int rv, off = 0;
 
 	while (off < count) {
-		rv = read(fd, buf + off, count - off);
+		rv = read(fd, (char *)buf + off, count - off);
 		if (rv == 0)
 			return -1;
 		if (rv == -1 && errno == EINTR)
@@ -49,7 +49,7 @@ int do_write(int fd, void *buf, size_t count)
 	int rv, off = 0;
 
  retry:
-	rv = write(fd, buf + off, count);
+	rv = write(fd, (char *)buf + off, count);
 	if (rv == -1 && errno == EINTR)
 		goto retry;
 	if (rv < 0) {
diff --git a/group/dlm_controld/netlink.c b/group/dlm_controld/netlink.c
index 5a7c261..63122f7 100644
--- a/group/dlm_controld/netlink.c
+++ b/group/dlm_controld/netlink.c
@@ -9,7 +9,7 @@
 
 /* FIXME: look into using libnl/libnetlink */
 
-#define GENLMSG_DATA(glh)       ((void *)(NLMSG_DATA(glh) + GENL_HDRLEN))
+#define GENLMSG_DATA(glh)       ((void *)((char *)NLMSG_DATA(glh) + GENL_HDRLEN))
 #define GENLMSG_PAYLOAD(glh)    (NLMSG_PAYLOAD(glh, 0) - GENL_HDRLEN)
 #define NLA_DATA(na)	    	((void *)((char*)(na) + NLA_HDRLEN))
 #define NLA_PAYLOAD(len)	(len - NLA_HDRLEN)


                 reply	other threads:[~2009-06-23  9:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090623090107.3606212037D@lists.fedorahosted.org \
    --to=fabbione@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).