From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cluster-cvs-return-11440-listarch-cluster-cvs=sources.redhat.com@sourceware.org>
Received: (qmail 31755 invoked by alias); 23 Jun 2009 15:37:06 -0000
Received: (qmail 31747 invoked by alias); 23 Jun 2009 15:37:06 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0
	tests=AWL,BAYES_00,J_CHICKENPOX_43,SPF_HELO_PASS
X-Spam-Status: No, hits=-1.8 required=5.0
	tests=AWL,BAYES_00,J_CHICKENPOX_43,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
	bastion2.fedora.phx.redhat.com
Subject: fence: master - fence: Make fence_node return 2 for no fencing
To: cluster-cvs-relay@redhat.com
X-Project: Cluster Project
X-Git-Module: fence.git
X-Git-Refname: refs/heads/master
X-Git-Reftype: branch
X-Git-Oldrev: e296c0b14d393b341e12d935141d7f592b9ecc0c
X-Git-Newrev: 30984aa352cc3990bdfbad25624216669062953a
From: Lon Hohberger <lon@fedoraproject.org>
Message-Id: <20090623153644.EF5E7120255@lists.fedorahosted.org>
Date: Tue, 23 Jun 2009 15:37:00 -0000
X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254
Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <cluster-cvs.sourceware.org>
List-Subscribe: <mailto:cluster-cvs-subscribe@sourceware.org>
List-Post: <mailto:cluster-cvs@sourceware.org>
List-Help: <mailto:cluster-cvs-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: cluster-cvs-owner@sourceware.org
X-SW-Source: 2009-q2/txt/msg00745.txt.bz2

Gitweb:        http://git.fedorahosted.org/git/fence.git?p=fence.git;a=commitdiff;h=30984aa352cc3990bdfbad25624216669062953a
Commit:        30984aa352cc3990bdfbad25624216669062953a
Parent:        e296c0b14d393b341e12d935141d7f592b9ecc0c
Author:        Lon Hohberger <lhh@redhat.com>
AuthorDate:    Tue Jun 23 11:10:34 2009 -0400
Committer:     Lon Hohberger <lhh@redhat.com>
CommitterDate: Tue Jun 23 11:36:34 2009 -0400

fence: Make fence_node return 2 for no fencing

This makes fence_node return values consistent
between fencing and unfencing cases.

Signed-off-by: Lon Hohberger <lhh@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com
---
 fence/fence_node/fence_node.c |    6 +++++-
 fence/libfence/agent.c        |    2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/fence/fence_node/fence_node.c b/fence/fence_node/fence_node.c
index 4cc533d..e7b147c 100644
--- a/fence/fence_node/fence_node.c
+++ b/fence/fence_node/fence_node.c
@@ -227,7 +227,11 @@ int main(int argc, char *argv[])
 			rv = EXIT_SUCCESS;
 		}
 	} else {
-		if (error) {
+		if (error == -2) {
+			fprintf(stderr, "fence %s undefined\n", victim);
+			logt_print(LOG_ERR, "fence %s undefined\n", victim);
+			rv = 2;
+		} else if (error) {
 			fprintf(stderr, "fence %s failed\n", victim);
 			logt_print(LOG_ERR, "fence %s failed\n", victim);
 			rv = EXIT_FAILURE;
diff --git a/fence/libfence/agent.c b/fence/libfence/agent.c
index 4fa10cd..c454f1b 100644
--- a/fence/libfence/agent.c
+++ b/fence/libfence/agent.c
@@ -309,7 +309,7 @@ int fence_node(char *victim, struct fence_log *log, int log_size,
 			left--;
 		}
 		count++;
-		error = -1;
+		error = -2;		/* No fencing */
 		goto out;
 	}