From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25673 invoked by alias); 25 Jun 2009 09:02:14 -0000 Received: (qmail 24638 invoked by alias); 25 Jun 2009 09:02:12 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: STABLE3 - src/clulib/ckpt_state.c (ds_key_init_nt): detect failed malloc To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/STABLE3 X-Git-Reftype: branch X-Git-Oldrev: 3cf06ec85044817b96fa4c778a959b10c6f71737 X-Git-Newrev: 2088d2121cf0a8ff5ea0e021b8b76d94d20b08d0 From: Jim Meyering Message-Id: <20090625090141.C2346120380@lists.fedorahosted.org> Date: Thu, 25 Jun 2009 09:02:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00755.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=2088d2121cf0a8ff5ea0e021b8b76d94d20b08d0 Commit: 2088d2121cf0a8ff5ea0e021b8b76d94d20b08d0 Parent: 3cf06ec85044817b96fa4c778a959b10c6f71737 Author: Jim Meyering AuthorDate: Tue Jun 23 00:04:33 2009 +0200 Committer: Jim Meyering CommitterDate: Thu Jun 25 10:59:57 2009 +0200 src/clulib/ckpt_state.c (ds_key_init_nt): detect failed malloc --- rgmanager/src/clulib/ckpt_state.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/rgmanager/src/clulib/ckpt_state.c b/rgmanager/src/clulib/ckpt_state.c index fd85aee..766097b 100644 --- a/rgmanager/src/clulib/ckpt_state.c +++ b/rgmanager/src/clulib/ckpt_state.c @@ -70,6 +70,7 @@ ds_key_init_nt(char *keyid, int maxsize, int timeout) } newnode = malloc(sizeof(*newnode)); + // FIXME: detect failed malloc memset(newnode,0,sizeof(*newnode)); snprintf((char *)newnode->kn_cpname.value, SA_MAX_NAME_LENGTH-1, "%s", keyid);