public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jim Meyering <meyering@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - dlm_controld: add comments: mark memory problems
Date: Fri, 26 Jun 2009 08:51:00 -0000	[thread overview]
Message-ID: <20090626085035.B0CA0120381@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=3ae8e17cfe19505bd77eab12375d7dbe213928c9
Commit:        3ae8e17cfe19505bd77eab12375d7dbe213928c9
Parent:        a5adf14a27e9cadc0b355af01fc416528a942372
Author:        Jim Meyering <meyering@redhat.com>
AuthorDate:    Tue Jun 23 11:57:13 2009 +0200
Committer:     Jim Meyering <meyering@redhat.com>
CommitterDate: Fri Jun 26 10:49:47 2009 +0200

dlm_controld: add comments: mark memory problems

* group/dlm_controld/pacemaker.c (process_cluster): Mark additional
memory problems.
---
 group/dlm_controld/pacemaker.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/group/dlm_controld/pacemaker.c b/group/dlm_controld/pacemaker.c
index 5825adc..6365123 100644
--- a/group/dlm_controld/pacemaker.c
+++ b/group/dlm_controld/pacemaker.c
@@ -191,6 +191,7 @@ void process_cluster(int ci)
 
 	log_debug("Decompressing message data");
 	uncompressed = malloc(new_size);
+	// FIXME: handle malloc failure
 	memset(uncompressed, 0, new_size);
 	
 	rc = BZ2_bzBuffToBuffDecompress(


                 reply	other threads:[~2009-06-26  8:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090626085035.B0CA0120381@lists.fedorahosted.org \
    --to=meyering@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).