From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31211 invoked by alias); 26 Jun 2009 10:52:24 -0000 Received: (qmail 31204 invoked by alias); 26 Jun 2009 10:52:24 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: RHEL4 - fence_apc_snmp: #498983 - affected by symlink vulnerabilities To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/RHEL4 X-Git-Reftype: branch X-Git-Oldrev: e92d478d1d309c329e628997f746e7cda65fd1e6 X-Git-Newrev: 7868c811ac968bc973ab452f5bcf1676d65565bd From: =?utf-8?q?Marek_Gr=C3=A1c?= Message-Id: <20090626105158.D2CED120380@lists.fedorahosted.org> Date: Fri, 26 Jun 2009 10:52:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q2/txt/msg00770.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=7868c811ac968bc973ab452f5bcf1676d65565bd Commit: 7868c811ac968bc973ab452f5bcf1676d65565bd Parent: e92d478d1d309c329e628997f746e7cda65fd1e6 Author: Marek 'marx' Grac AuthorDate: Fri Jun 26 12:46:21 2009 +0200 Committer: Marek 'marx' Grac CommitterDate: Fri Jun 26 12:46:21 2009 +0200 fence_apc_snmp: #498983 - affected by symlink vulnerabilities Option -v for verbose mode now expects filename --- fence/agents/apc_snmp/fence_apc_snmp.py | 11 ++++++----- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/fence/agents/apc_snmp/fence_apc_snmp.py b/fence/agents/apc_snmp/fence_apc_snmp.py index 9069461..3078a9e 100755 --- a/fence/agents/apc_snmp/fence_apc_snmp.py +++ b/fence/agents/apc_snmp/fence_apc_snmp.py @@ -229,7 +229,7 @@ def usage(): print " -c SNMP community (default 'private')" print " -n Outlet name/number to act on" print " -o Action: Reboot (default), On, Off and Status" - print " -v Verbose mode - write to /tmp/apclog" + print " -v Verbose mode - write to file" print " -V Version" sys.exit(0) @@ -237,10 +237,10 @@ def usage(): file_log = None -def set_logging(verbose): +def set_logging(verbose, verbose_filename): global file_log if verbose: - file_log = open('/tmp/apclog', 'a') + file_log = open(verbose_filename, 'a') file_log.write('\n----------- ') file_log.write(datetime.datetime.today().ctime()) file_log.write(' -----------\n') @@ -275,7 +275,7 @@ def main2(): if len(sys.argv) > 1: try: - opts, args = getopt.getopt(sys.argv[1:], "ha:u:c:n:o:vV", ["help", "output="]) + opts, args = getopt.getopt(sys.argv[1:], "ha:u:c:n:o:v:V", ["help", "output="]) except getopt.GetoptError: usage() sys.exit(2) @@ -285,6 +285,7 @@ def main2(): a = a.strip() if o == "-v": verbose = True + verbose_filename = a if o == "-V": print "%s\n" % FENCE_RELEASE_NAME print "%s\n" % REDHAT_COPYRIGHT @@ -324,7 +325,7 @@ def main2(): params[o] = a - set_logging(verbose) + set_logging(verbose, verbose_filename) ### validation ###