public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: gfs1-utils: master - gfs_fsck: Segfault in EA leaf repair
Date: Wed, 01 Jul 2009 19:49:00 -0000	[thread overview]
Message-ID: <20090701194847.B01DC1201F0@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/gfs1-utils.git?p=gfs1-utils.git;a=commitdiff;h=6ec6f79ce2b87d3d53efea9074f16339e4e66f2c
Commit:        6ec6f79ce2b87d3d53efea9074f16339e4e66f2c
Parent:        fb264df3f0a1932a892a49bf8967da6e4fc613b2
Author:        Bob Peterson <rpeterso@redhat.com>
AuthorDate:    Wed Jul 1 14:34:17 2009 -0500
Committer:     Bob Peterson <rpeterso@redhat.com>
CommitterDate: Wed Jul 1 14:48:37 2009 -0500

gfs_fsck: Segfault in EA leaf repair

bz 495774 / 507775
---
 gfs/gfs_fsck/metawalk.c |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/gfs/gfs_fsck/metawalk.c b/gfs/gfs_fsck/metawalk.c
index 104ab7e..b797cca 100644
--- a/gfs/gfs_fsck/metawalk.c
+++ b/gfs/gfs_fsck/metawalk.c
@@ -411,10 +411,11 @@ static int check_leaf_eattr(struct fsck_inode *ip, uint64_t block,
 			relse_buf(ip->i_sbd, bh);
 			return 1;
 		}
-		check_eattr_entries(ip, bh, pass);
-
-		if (bh)
+		if (bh) {
+			error = check_eattr_entries(ip, bh, pass);
 			relse_buf(ip->i_sbd, bh);
+		}
+		return error;
 	}
 
 	return 0;


                 reply	other threads:[~2009-07-01 19:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090701194847.B01DC1201F0@lists.fedorahosted.org \
    --to=rpeterso@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).