From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18282 invoked by alias); 1 Jul 2009 19:51:42 -0000 Received: (qmail 18276 invoked by alias); 1 Jul 2009 19:51:42 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: cluster: RHEL54 - gfs_fsck: Segfault in EA leaf repair To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: cluster.git X-Git-Refname: refs/heads/RHEL54 X-Git-Reftype: branch X-Git-Oldrev: ba219de10bab8bc327f83a96f52b98068914def8 X-Git-Newrev: 704f137b77fce75d27621b1571bbb142696d30d6 From: Bob Peterson Message-Id: <20090701195114.24E231201F0@lists.fedorahosted.org> Date: Wed, 01 Jul 2009 19:51:00 -0000 X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00005.txt.bz2 Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=704f137b77fce75d27621b1571bbb142696d30d6 Commit: 704f137b77fce75d27621b1571bbb142696d30d6 Parent: ba219de10bab8bc327f83a96f52b98068914def8 Author: Bob Peterson AuthorDate: Wed Jul 1 14:34:17 2009 -0500 Committer: Bob Peterson CommitterDate: Wed Jul 1 14:36:46 2009 -0500 gfs_fsck: Segfault in EA leaf repair bz 495774 / 507775 --- gfs/gfs_fsck/metawalk.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gfs/gfs_fsck/metawalk.c b/gfs/gfs_fsck/metawalk.c index 3279266..2da494d 100644 --- a/gfs/gfs_fsck/metawalk.c +++ b/gfs/gfs_fsck/metawalk.c @@ -423,10 +423,11 @@ static int check_leaf_eattr(struct fsck_inode *ip, uint64_t block, relse_buf(ip->i_sbd, bh); return 1; } - check_eattr_entries(ip, bh, pass); - - if (bh) + if (bh) { + error = check_eattr_entries(ip, bh, pass); relse_buf(ip->i_sbd, bh); + } + return error; } return 0;