public inbox for
help / color / mirror / Atom feed
From: David Teigland <>
Subject: cluster: STABLE3 - dlm_controld/gfs_controld: GETLK should free unused resource
Date: Wed, 22 Jul 2009 20:40:00 -0000	[thread overview]
Message-ID: <> (raw)

Commit:        c2f3ba7a40d4080f6dbf7a2cc9dc80ff9445eb9e
Parent:        0d93f2b3eb654c787940273d346bf95703a4ffe2
Author:        David Teigland <>
AuthorDate:    Wed Jul 22 15:29:53 2009 -0500
Committer:     David Teigland <>
CommitterDate: Wed Jul 22 15:29:53 2009 -0500

dlm_controld/gfs_controld: GETLK should free unused resource

bz 513285

If a plock resource does not exist in dlm_controld/gfs_controld,
(no posix locks exist on a file), fcntl(GETLK) on that file will
cause the resource to be created, but not removed afterward.

Signed-off-by: David Teigland <>
 group/dlm_controld/plock.c |    1 +
 group/gfs_controld/plock.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/group/dlm_controld/plock.c b/group/dlm_controld/plock.c
index 0b432d1..3d4431e 100644
--- a/group/dlm_controld/plock.c
+++ b/group/dlm_controld/plock.c
@@ -732,6 +732,7 @@ static void do_get(struct lockspace *ls, struct dlm_plock_info *in,
 		rv = 0;
 	write_result(ls, in, rv);
+	put_resource(r);
 static void save_message(struct lockspace *ls, struct dlm_header *hd, int len,
diff --git a/group/gfs_controld/plock.c b/group/gfs_controld/plock.c
index f8b600e..7a83a08 100644
--- a/group/gfs_controld/plock.c
+++ b/group/gfs_controld/plock.c
@@ -705,6 +705,7 @@ static void do_get(struct mountgroup *mg, struct dlm_plock_info *in,
 		rv = 0;
 	write_result(mg, in, rv);
+	put_resource(r);
 static void __receive_plock(struct mountgroup *mg, struct dlm_plock_info *in,

                 reply	other threads:[~2009-07-22 20:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).