public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster: STABLE3 - dlm_controld/gfs_controld: GETLK should free unused resource
@ 2009-07-22 20:40 David Teigland
  0 siblings, 0 replies; only message in thread
From: David Teigland @ 2009-07-22 20:40 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=c2f3ba7a40d4080f6dbf7a2cc9dc80ff9445eb9e
Commit:        c2f3ba7a40d4080f6dbf7a2cc9dc80ff9445eb9e
Parent:        0d93f2b3eb654c787940273d346bf95703a4ffe2
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Wed Jul 22 15:29:53 2009 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Wed Jul 22 15:29:53 2009 -0500

dlm_controld/gfs_controld: GETLK should free unused resource

bz 513285

If a plock resource does not exist in dlm_controld/gfs_controld,
(no posix locks exist on a file), fcntl(GETLK) on that file will
cause the resource to be created, but not removed afterward.

Signed-off-by: David Teigland <teigland@redhat.com>
---
 group/dlm_controld/plock.c |    1 +
 group/gfs_controld/plock.c |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/group/dlm_controld/plock.c b/group/dlm_controld/plock.c
index 0b432d1..3d4431e 100644
--- a/group/dlm_controld/plock.c
+++ b/group/dlm_controld/plock.c
@@ -732,6 +732,7 @@ static void do_get(struct lockspace *ls, struct dlm_plock_info *in,
 		rv = 0;
 
 	write_result(ls, in, rv);
+	put_resource(r);
 }
 
 static void save_message(struct lockspace *ls, struct dlm_header *hd, int len,
diff --git a/group/gfs_controld/plock.c b/group/gfs_controld/plock.c
index f8b600e..7a83a08 100644
--- a/group/gfs_controld/plock.c
+++ b/group/gfs_controld/plock.c
@@ -705,6 +705,7 @@ static void do_get(struct mountgroup *mg, struct dlm_plock_info *in,
 		rv = 0;
 
 	write_result(mg, in, rv);
+	put_resource(r);
 }
 
 static void __receive_plock(struct mountgroup *mg, struct dlm_plock_info *in,


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-07-22 20:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-07-22 20:40 cluster: STABLE3 - dlm_controld/gfs_controld: GETLK should free unused resource David Teigland

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).