public inbox for
help / color / mirror / Atom feed
From: Bob Peterson <>
Subject: cluster: RHEL53 - GFS: Commited data evaporates
Date: Thu, 23 Jul 2009 15:31:00 -0000	[thread overview]
Message-ID: <> (raw)

Commit:        f19cc83e347ccc639bd54635adeb2e77bbbf2e66
Parent:        2bac6a6e1a24cd56f08bb89299296bf2a9a6ea58
Author:        Bob Peterson <>
AuthorDate:    Wed Jul 22 12:13:02 2009 -0500
Committer:     Bob Peterson <>
CommitterDate: Wed Jul 22 12:37:57 2009 -0500

GFS: Commited data evaporates

bz 510310

Since stuffed data is contained along with the metadata, the journal
needs to be flushed at fsync in order to ensure the data hits the media.
The problem is that fsyncs to stuffed inodes were not causing the
journal to be flushed.
 gfs-kernel/src/gfs/ops_file.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gfs-kernel/src/gfs/ops_file.c b/gfs-kernel/src/gfs/ops_file.c
index 1e54e30..64bc76a 100644
--- a/gfs-kernel/src/gfs/ops_file.c
+++ b/gfs-kernel/src/gfs/ops_file.c
@@ -1597,6 +1597,8 @@ gfs_fsync(struct file *file, struct dentry *dentry, int datasync)
 			error = sync_inode(inode, &wbc);
+		if (gfs_is_stuffed(ip))
+			gfs_log_flush_glock(ip->i_gl);

                 reply	other threads:[~2009-07-23 15:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).