public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: andyp <andyp@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - gfs2_quota: Fix sparse error
Date: Wed, 19 Aug 2009 14:36:00 -0000	[thread overview]
Message-ID: <20090819143559.E5F64120215@lists.fedorahosted.org> (raw)

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=634dc32a17ddf0c571d34b798c7124e4de942445
Commit:        634dc32a17ddf0c571d34b798c7124e4de942445
Parent:        43869f6ad3cb6a401a52b8455b00bfa86d3af422
Author:        Andrew Price <andy@andrewprice.me.uk>
AuthorDate:    Wed Aug 19 09:24:32 2009 +0100
Committer:     Andrew Price <andy@andrewprice.me.uk>
CommitterDate: Wed Aug 19 15:30:34 2009 +0100

gfs2_quota: Fix sparse error

Fix sparse error "marked inline, but without a definition" and make
write_quota_internal static as it's only used in main.c

Signed-off-by: Andrew Price <andy@andrewprice.me.uk>
Acked-by: Bob Peterson <rpeterso@redhat.com>
---
 gfs2/quota/gfs2_quota.h |    4 +---
 gfs2/quota/main.c       |    4 ++--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/gfs2/quota/gfs2_quota.h b/gfs2/quota/gfs2_quota.h
index 462246f..f15c25b 100644
--- a/gfs2/quota/gfs2_quota.h
+++ b/gfs2/quota/gfs2_quota.h
@@ -66,10 +66,8 @@ void cleanup(void);
 void read_superblock(struct gfs2_sb *sb, struct gfs2_sbd *sdp);
 void get_last_quota_id(int fd, uint32_t *max_id);
 int is_valid_quota_list(int fd);
-inline void read_quota_internal(int fd, unsigned int id, int id_type, 
+void read_quota_internal(int fd, unsigned int id, int id_type,
 				struct gfs2_quota *q);
-inline void write_quota_internal(int fd, unsigned int id, int id_type, 
-				 struct gfs2_quota *q);
 void print_quota_list_warning(void);
 
 /*  check.c  */
diff --git a/gfs2/quota/main.c b/gfs2/quota/main.c
index a160897..83de4db 100644
--- a/gfs2/quota/main.c
+++ b/gfs2/quota/main.c
@@ -306,7 +306,7 @@ read_superblock(struct gfs2_sb *sb, struct gfs2_sbd *sdp)
 	close(fd);
 }
 
-inline void 
+void
 read_quota_internal(int fd, uint32_t id, int id_type, struct gfs2_quota *q)
 {
 	/* seek to the appropriate offset in the quota file and read the 
@@ -329,7 +329,7 @@ read_quota_internal(int fd, uint32_t id, int id_type, struct gfs2_quota *q)
 	gfs2_quota_in(q, buf);
 }
 
-inline void 
+static inline void
 write_quota_internal(int fd, uint32_t id, int id_type, struct gfs2_quota *q)
 {
 	/* seek to the appropriate offset in the quota file and read the


                 reply	other threads:[~2009-08-19 14:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090819143559.E5F64120215@lists.fedorahosted.org \
    --to=andyp@fedoraproject.org \
    --cc=cluster-cvs-relay@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).