From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7603 invoked by alias); 31 Aug 2009 17:32:49 -0000 Received: (qmail 7590 invoked by alias); 31 Aug 2009 17:32:49 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_61,SPF_HELO_PASS X-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_61,SPF_HELO_PASS X-Spam-Check-By: sourceware.org X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bastion2.fedora.phx.redhat.com Subject: gfs2-utils: master - gfs2_edit: Indirect pointers missing from list when paging up and down To: cluster-cvs-relay@redhat.com X-Project: Cluster Project X-Git-Module: gfs2-utils.git X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: f49b4f3bfdccc8489fbeebe4a059ef1e3629a38e X-Git-Newrev: f2c6bd843a39c145277243a0240a219bbee40c77 From: Bob Peterson Message-Id: <20090831173217.A999A12025B@lists.fedorahosted.org> Date: Mon, 31 Aug 2009 17:32:00 -0000 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 Mailing-List: contact cluster-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: cluster-cvs-owner@sourceware.org X-SW-Source: 2009-q3/txt/msg00259.txt.bz2 Gitweb: http://git.fedorahosted.org/git/gfs2-utils.git?p=gfs2-utils.git;a=commitdiff;h=f2c6bd843a39c145277243a0240a219bbee40c77 Commit: f2c6bd843a39c145277243a0240a219bbee40c77 Parent: f49b4f3bfdccc8489fbeebe4a059ef1e3629a38e Author: Bob Peterson AuthorDate: Mon Aug 31 11:24:23 2009 -0500 Committer: Bob Peterson CommitterDate: Mon Aug 31 12:31:24 2009 -0500 gfs2_edit: Indirect pointers missing from list when paging up and down When using page-up and page-down to scroll a list of indirect block pointers, there was sometimes an occasional gap due to incorrect end-of-line management. rhbz#503529 --- gfs2/edit/hexedit.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c index c99c2c6..5a506a9 100644 --- a/gfs2/edit/hexedit.c +++ b/gfs2/edit/hexedit.c @@ -1291,8 +1291,6 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_ int offsets[5]; last_entry_onscreen[dmode] = 0; - if (!level) - eol(0); if (!has_indirect_blocks()) return -1; if (!level) { @@ -1308,7 +1306,6 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_ print_gfs2("This indirect block contains %d indirect blocks", indblocks); } - eol(0); total_dirents = 0; /* Figure out multiplication factors for indirect pointers. */ if (!S_ISDIR(di.di_mode)) { @@ -1342,9 +1339,9 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_ factor[i + 1] = factor[i] * inptrs; } if (!level) - print_gfs2(" (at height=%d)", cur_height); - eol(0); + print_gfs2(" (at height %d)", cur_height); } + eol(0); if (!level && indblocks) { print_gfs2("Indirect blocks:"); eol(0);