public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
From: Bob Peterson <rpeterso@fedoraproject.org>
To: cluster-cvs-relay@redhat.com
Subject: cluster: STABLE3 - gfs2_edit: Indirect pointers missing from list when paging up and down
Date: Mon, 31 Aug 2009 17:34:00 -0000 [thread overview]
Message-ID: <20090831173319.2F4441201FC@lists.fedorahosted.org> (raw)
Gitweb: http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=90537c74d4c0c67b0f0970752c1d1960c178f4a8
Commit: 90537c74d4c0c67b0f0970752c1d1960c178f4a8
Parent: 5dd73044bf882876b16d924d81159a032a1a8f87
Author: Bob Peterson <bob@ganesha.peterson>
AuthorDate: Mon Aug 31 11:24:23 2009 -0500
Committer: Bob Peterson <bob@ganesha.peterson>
CommitterDate: Mon Aug 31 11:24:23 2009 -0500
gfs2_edit: Indirect pointers missing from list when paging up and down
When using page-up and page-down to scroll a list of indirect
block pointers, there was sometimes an occasional gap due to
incorrect end-of-line management.
rhbz#503529
---
gfs2/edit/hexedit.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c
index 2092d9a..0184e2f 100644
--- a/gfs2/edit/hexedit.c
+++ b/gfs2/edit/hexedit.c
@@ -1289,8 +1289,6 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_
int offsets[5];
last_entry_onscreen[dmode] = 0;
- if (!level)
- eol(0);
if (!has_indirect_blocks())
return -1;
if (!level) {
@@ -1306,7 +1304,6 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_
print_gfs2("This indirect block contains %d indirect blocks",
indblocks);
}
- eol(0);
total_dirents = 0;
/* Figure out multiplication factors for indirect pointers. */
if (!S_ISDIR(di.di_mode)) {
@@ -1340,9 +1337,9 @@ static int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_
factor[i + 1] = factor[i] * inptrs;
}
if (!level)
- print_gfs2(" (at height=%d)", cur_height);
- eol(0);
+ print_gfs2(" (at height %d)", cur_height);
}
+ eol(0);
if (!level && indblocks) {
print_gfs2("Indirect blocks:");
eol(0);
reply other threads:[~2009-08-31 17:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090831173319.2F4441201FC@lists.fedorahosted.org \
--to=rpeterso@fedoraproject.org \
--cc=cluster-cvs-relay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).