public inbox for cluster-cvs@sourceware.org
help / color / mirror / Atom feed
* cluster: RHEL55 - gfs2_edit: Indirect pointers missing from list when paging up and down
@ 2009-08-31 17:56 Bob Peterson
  0 siblings, 0 replies; only message in thread
From: Bob Peterson @ 2009-08-31 17:56 UTC (permalink / raw)
  To: cluster-cvs-relay

Gitweb:        http://git.fedorahosted.org/git/cluster.git?p=cluster.git;a=commitdiff;h=ae947cb6549865a51b279266a2be92fbf2b0bdb2
Commit:        ae947cb6549865a51b279266a2be92fbf2b0bdb2
Parent:        9ae354d72b41c51e0efa44d6839859f6f5d43877
Author:        Bob Peterson <bob@ganesha.peterson>
AuthorDate:    Mon Aug 31 11:24:00 2009 -0500
Committer:     Bob Peterson <rpeterso@redhat.com>
CommitterDate: Mon Aug 31 12:58:09 2009 -0500

gfs2_edit: Indirect pointers missing from list when paging up and down

When using page-up and page-down to scroll a list of indirect
block pointers, there was sometimes an occasional gap due to
incorrect end-of-line management.

rhbz#503529
---
 gfs2/edit/hexedit.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/gfs2/edit/hexedit.c b/gfs2/edit/hexedit.c
index a720aac..c180256 100644
--- a/gfs2/edit/hexedit.c
+++ b/gfs2/edit/hexedit.c
@@ -1300,8 +1300,6 @@ int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_t start
 	int offsets[5];
 
 	last_entry_onscreen[dmode] = 0;
-	if (!level)
-		eol(0);
 	if (!has_indirect_blocks())
 		return -1;
 	if (!level) {
@@ -1317,7 +1315,6 @@ int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_t start
 			print_gfs2("This indirect block contains %d indirect blocks",
 				   indblocks);
 	}
-	eol(0);
 	total_dirents = 0;
 	/* Figure out multiplication factors for indirect pointers. */
 	if (!S_ISDIR(di.di_mode)) {
@@ -1351,9 +1348,9 @@ int display_indirect(struct iinfo *ind, int indblocks, int level, uint64_t start
 				factor[i + 1] = factor[i] * inptrs;
 		}
 		if (!level)
-			print_gfs2("  (at height=%d)", cur_height);
-		eol(0);
+			print_gfs2("  (at height %d)", cur_height);
 	}
+	eol(0);
 	if (!level && indblocks) {
 		print_gfs2("Indirect blocks:");
 		eol(0);


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-08-31 17:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-08-31 17:56 cluster: RHEL55 - gfs2_edit: Indirect pointers missing from list when paging up and down Bob Peterson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).