public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 4 of 8] gcc: promote PKGVERSION and BUGURL options to toolchain level Benoît THÉBAUDEAU
@ 2011-06-01 20:36 ` Benoît THÉBAUDEAU
  2011-06-01 21:16   ` Yann E. MORIN
  2011-06-03 21:44   ` [PATCH 8 of 8] " Arnaud Lacombe
  2011-06-01 20:36 ` [PATCH 7 of 8] gdb: use the PKGVERSION and BUGURL options Benoît THÉBAUDEAU
                   ` (6 subsequent siblings)
  8 siblings, 2 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306960344 -7200
# Node ID b96b4403c850000dfe69b7d64bc4d65542007290
# Parent  9e3cbe13deae566d9ec0c31f38afe238f7c9660d
kconfig: prepend CT-NG's version tag to PKGVERSION

"crosstool-NG-${CT_VERSION}" is currently the default for TOOLCHAIN_PKGVERSION,
and this options is passed as is to --with-pkgversion.

This patch prepends "crosstool-NG ${CT_VERSION}" to TOOLCHAIN_PKGVERSION before
passing it to --with-pkgversion.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -69,13 +69,18 @@
 config TOOLCHAIN_PKGVERSION
     string
     prompt "Toolchain ID string"
-    default "crosstool-NG-${CT_VERSION}"
+    default ""
     help
       Specify a string that identifies your package. You may wish to include
       a build number or build date. This version string will be included in
       the output of gcc --version, and also in binutils, eglibc, gdb and
       gdbserver.
 
+      If this string is left empty, the actual package version will be:
+          "crosstool-NG ${CT_VERSION}"
+      Otherwise, it will be:
+          "crosstool-NG ${CT_VERSION} - ${CT_TOOLCHAIN_PKGVERSION}"
+
       This is passed to the configure flag --with-pkgversion.
 
 config TOOLCHAIN_BUGURL
diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
--- a/scripts/build/binutils/binutils.sh
+++ b/scripts/build/binutils/binutils.sh
@@ -56,8 +56,8 @@
         extra_config+=( --enable-plugins )
     fi
     if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
@@ -147,8 +147,8 @@
         CT_DoLog EXTRA "Configuring binutils for target"
 
         if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-            [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-            [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+            extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
+            [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
         fi
 
         CT_DoExecLog CFG                                            \
diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
--- a/scripts/build/cc/gcc.sh
+++ b/scripts/build/cc/gcc.sh
@@ -161,8 +161,8 @@
 
     if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
         # Bare metal delivers the core compiler as final compiler, so add version info and bugurl
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     if [ "${copy_headers}" = "y" ]; then
@@ -405,8 +405,8 @@
 
     [ "${CT_SHARED_LIBS}" = "y" ] || extra_config+=("--disable-shared")
     if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
     case "${CT_CC_GCC_SJLJ_EXCEPTIONS}" in
         y)  extra_config+=("--enable-sjlj-exceptions");;
diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
--- a/scripts/build/debug/300-gdb.sh
+++ b/scripts/build/debug/300-gdb.sh
@@ -99,8 +99,8 @@
     esac
 
     if [ "${CT_GDB_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     if [ "${CT_GDB_CROSS}" = "y" ]; then
diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common
--- a/scripts/build/libc/glibc-eglibc.sh-common
+++ b/scripts/build/libc/glibc-eglibc.sh-common
@@ -235,8 +235,8 @@
     esac
 
     if [ "${CT_LIBC_EGLIBC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     extra_cc_args="${extra_cc_args} ${CT_ARCH_ENDIAN_OPT}"

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 4 of 8] gcc: promote PKGVERSION and BUGURL options to toolchain level
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
@ 2011-06-01 20:36 ` Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION Benoît THÉBAUDEAU
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306865555 -7200
# Node ID 53773e635418516baed312be0ba3616332a8e30b
# Parent  256249d36bddd5299bf89d451ea3c01abd55b065
gcc: promote PKGVERSION and BUGURL options to toolchain level

This patch promotes the PKGVERSION and BUGURL options to toolchain level so that
all toolchain components supporting them can benefit from them.

These options are passed to configure through --with-pkgversion and
--with-bugurl.

They are supported by binutils 2.18+, gcc 4.3+, eglibc 2.9+ and gdb 7.0+.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/cc/gcc.in.2 b/config/cc/gcc.in.2
--- a/config/cc/gcc.in.2
+++ b/config/cc/gcc.in.2
@@ -1,25 +1,5 @@
 # gcc configuration options
 
-config CC_PKGVERSION
-    string
-    prompt "gcc ID string"
-    depends on CC_GCC_HAS_PKGVERSION_BUGURL
-    default "crosstool-NG-${CT_VERSION}"
-    help
-      Specify a string that identifies your package. You may wish to include
-      a build number or build date. This version string will be included in
-      the output of gcc --version.
-
-      This is passed to the configure flag --with-pkgversion.
-
-config CC_BUGURL
-    string
-    prompt "gcc bug URL"
-    depends on CC_GCC_HAS_PKGVERSION_BUGURL
-    default ""
-    help
-      Specify the URL that users should visit if they wish to report a bug.
-
 config CC_ENABLE_CXX_FLAGS
     string
     prompt "Flags to pass to --enable-cxx-flags"
diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -66,6 +66,24 @@
       NOTE: this has no connection to whether the target libraries will be
       dynamic or static. This only applies to the tools themselves.
 
+config TOOLCHAIN_PKGVERSION
+    string
+    prompt "Toolchain ID string"
+    default "crosstool-NG-${CT_VERSION}"
+    help
+      Specify a string that identifies your package. You may wish to include
+      a build number or build date. This version string will be included in
+      the output of gcc --version.
+
+      This is passed to the configure flag --with-pkgversion.
+
+config TOOLCHAIN_BUGURL
+    string
+    prompt "Toolchain bug URL"
+    default ""
+    help
+      Specify the URL that users should visit if they wish to report a bug.
+
 comment "Tuple completion and aliasing"
 
 config TARGET_VENDOR
diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
--- a/scripts/build/cc/gcc.sh
+++ b/scripts/build/cc/gcc.sh
@@ -159,9 +159,11 @@
     mkdir -p "${CT_BUILD_DIR}/build-cc-core-${mode}"
     cd "${CT_BUILD_DIR}/build-cc-core-${mode}"
 
-    # Bare metal delivers the core compiler as final compiler, so add version info and bugurl
-    [ -n "${CT_CC_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_CC_BUGURL}")
-    [ -n "${CT_CC_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_CC_PKGVERSION}")
+    if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
+        # Bare metal delivers the core compiler as final compiler, so add version info and bugurl
+        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+    fi
 
     if [ "${copy_headers}" = "y" ]; then
         CT_DoLog DEBUG "Copying headers to install area of bootstrap gcc, so it can build libgcc2"
@@ -401,9 +403,11 @@
         fi
     done
 
-    [ "${CT_SHARED_LIBS}" = "y" ]                   || extra_config+=("--disable-shared")
-    [ -n "${CT_CC_PKGVERSION}" ]                    && extra_config+=("--with-pkgversion=${CT_CC_PKGVERSION}")
-    [ -n "${CT_CC_BUGURL}" ]                        && extra_config+=("--with-bugurl=${CT_CC_BUGURL}")
+    [ "${CT_SHARED_LIBS}" = "y" ] || extra_config+=("--disable-shared")
+    if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
+        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+    fi
     case "${CT_CC_GCC_SJLJ_EXCEPTIONS}" in
         y)  extra_config+=("--enable-sjlj-exceptions");;
         m)  ;;

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools
@ 2011-06-01 20:36 Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 4 of 8] gcc: promote PKGVERSION and BUGURL options to toolchain level Benoît THÉBAUDEAU
                   ` (8 more replies)
  0 siblings, 9 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

Hi Yann, all!

This is a new revision of my previous patch series about the same subject,
taking your comments into account.

Best regards,
Benoît

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 7 of 8] gdb: use the PKGVERSION and BUGURL options
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 4 of 8] gcc: promote PKGVERSION and BUGURL options to toolchain level Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION Benoît THÉBAUDEAU
@ 2011-06-01 20:36 ` Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 3 of 8] gcc: add a CC_GCC_HAS_PKGVERSION_BUGURL option Benoît THÉBAUDEAU
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306868583 -7200
# Node ID 9e3cbe13deae566d9ec0c31f38afe238f7c9660d
# Parent  213c4dc5316c83baffe7e431cd70b73c8c8b835b
gdb: use the PKGVERSION and BUGURL options

This patch makes gdb benefit from the TOOLCHAIN_PKGVERSION and
TOOLCHAIN_BUGURL options.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/debug/gdb.in b/config/debug/gdb.in
--- a/config/debug/gdb.in
+++ b/config/debug/gdb.in
@@ -72,6 +72,10 @@
 
 config GDB_7_0_or_later
     bool
+    select GDB_HAS_PKGVERSION_BUGURL
+
+config GDB_HAS_PKGVERSION_BUGURL
+    bool
 
 config GDB_VERSION
     string
diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -73,7 +73,8 @@
     help
       Specify a string that identifies your package. You may wish to include
       a build number or build date. This version string will be included in
-      the output of gcc --version, and also in binutils, eglibc.
+      the output of gcc --version, and also in binutils, eglibc, gdb and
+      gdbserver.
 
       This is passed to the configure flag --with-pkgversion.
 
diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
--- a/scripts/build/debug/300-gdb.sh
+++ b/scripts/build/debug/300-gdb.sh
@@ -98,6 +98,11 @@
         6.2*|6.3)   extra_config+=("--disable-gdbmi");;
     esac
 
+    if [ "${CT_GDB_HAS_PKGVERSION_BUGURL}" = "y" ]; then
+        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+    fi
+
     if [ "${CT_GDB_CROSS}" = "y" ]; then
         local -a cross_extra_config
 

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 2 of 8] scripts/addToolVersion.sh: add a function to extract fields from versions
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
                   ` (3 preceding siblings ...)
  2011-06-01 20:36 ` [PATCH 3 of 8] gcc: add a CC_GCC_HAS_PKGVERSION_BUGURL option Benoît THÉBAUDEAU
@ 2011-06-01 20:36 ` Benoît THÉBAUDEAU
  2011-06-01 20:37 ` [PATCH 1 of 8] kconfig: remove useless 'default n' Benoît THÉBAUDEAU
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306855252 -7200
# Node ID e9712058fd48182b4039e6f066fa36514279ee3b
# Parent  d124516c60a2f0559020400a8dfd1dbf339359a5
scripts/addToolVersion.sh: add a function to extract fields from versions

This patch adds a function to extract major, minor, revision, etc. from version
numbers.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/scripts/addToolVersion.sh b/scripts/addToolVersion.sh
--- a/scripts/addToolVersion.sh
+++ b/scripts/addToolVersion.sh
@@ -18,34 +18,43 @@
 		  'tool' in one of:
 		    gcc, binutils, glibc, eglibc, uClibc, newlib, linux, gdb, dmalloc,
 		    duma, strace, ltrace, libelf, gmp, mpfr, ppl, cloog, mpc
-		
+
 		  Valid options for all tools:
 		    --stable, -s, +x   (default)
 		      mark the version as being stable (as opposed to experimental, below)
-		
+
 		    --experimental, -x, +s
 		      mark the version as being experimental (as opposed to stable, above)
-		
+
 		    --current, -c, +o   (default)
 		      mark the version as being cuurent (as opposed to obsolete, below)
-		
+
 		    --obsolete, -o, +c
 		      mark the version as being obsolete (as opposed to current, above)
-		
+
 		  Note: setting a new tool resets to the defaults: 'stable' and 'current'.
-		
+
 		  'version' is a valid version for the specified tool.
-		
+
 		  Examples:
 		    add stable current version 2.6.19.2 to linux kernel:
 		      ${myname} --linux 2.6.19.2
-		
+
 		    add experimental obsolete version 2.3.5 and stable current versions 2.6.1
 		    and 2.6.2 to glibc, add stable obsolete version 3.3.3 to gcc:
 		      ${myname} --glibc -x -o 2.3.5 -s -c 2.6.1 2.6.2 --gcc -o 3.3.3
 		EOF
 }
 
+# Extract field $3 from version $1 with separator $2
+getVersionField() {
+    local version="$1"
+    local sep="$2"
+    local field="$3"
+
+    echo "${version}${sep}${sep}${sep}${sep}" |cut -d ${sep} -f ${field}
+}
+
 # Effectively add a version to the specified tool
 # $cat          : tool category
 # $tool         : tool name
@@ -100,8 +109,8 @@
     case "${tool}" in
         gcc)
             # Extract 'M'ajor and 'm'inor from version string
-            ver_M=$(echo "${version}...." |cut -d . -f 1)
-            ver_m=$(echo "${version}...." |cut -d . -f 2)
+            ver_M=$(getVersionField "${version}" . 1)
+            ver_m=$(getVersionField "${version}" . 2)
             if [   \( ${ver_M} -eq 4 -a ${ver_m} -eq 6 \)  ]; then
                 SedExpr1="${SedExpr1}\n    select CC_GCC_4_6"
             elif [ \( ${ver_M} -eq 4 -a ${ver_m} -eq 5 \)  ]; then
@@ -116,9 +125,9 @@
             ;;
         uClibc)
             # uClibc-0.9.30 and above need some love
-            ver_M=$(echo "${version}...." |cut -d . -f 1)
-            ver_m=$(echo "${version}...." |cut -d . -f 2)
-            ver_p=$(echo "${version}...." |cut -d . -f 3)
+            ver_M=$(getVersionField "${version}" . 1)
+            ver_m=$(getVersionField "${version}" . 2)
+            ver_p=$(getVersionField "${version}" . 3)
             if [    ${ver_M} -ge 1                                      \
                  -o ${ver_M} -eq 0 -a ${ver_m} -ge 10                   \
                  -o ${ver_M} -eq 0 -a ${ver_m} -eq 9 -a ${ver_p} -ge 30 ]; then
@@ -127,7 +136,7 @@
             ;;
         gdb)
             # gdb-7.0 and above have special handling
-            ver_M=$(echo "${version}...." |cut -d . -f 1)
+            ver_M=$(getVersionField "${version}" . 1)
             if [ ${ver_M} -ge 7 ]; then
                 SedExpr1="${SedExpr1}\n    select GDB_7_0_or_later"
             fi

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 3 of 8] gcc: add a CC_GCC_HAS_PKGVERSION_BUGURL option
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
                   ` (2 preceding siblings ...)
  2011-06-01 20:36 ` [PATCH 7 of 8] gdb: use the PKGVERSION and BUGURL options Benoît THÉBAUDEAU
@ 2011-06-01 20:36 ` Benoît THÉBAUDEAU
  2011-06-01 20:36 ` [PATCH 2 of 8] scripts/addToolVersion.sh: add a function to extract fields from versions Benoît THÉBAUDEAU
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:36 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306864559 -7200
# Node ID 256249d36bddd5299bf89d451ea3c01abd55b065
# Parent  e9712058fd48182b4039e6f066fa36514279ee3b
gcc: add a CC_GCC_HAS_PKGVERSION_BUGURL option

This patch adds a blind option CC_GCC_HAS_PKGVERSION_BUGURL to test the support
of --with-pkgversion and --with-bugurl by GCC's configure.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/cc/gcc.in b/config/cc/gcc.in
--- a/config/cc/gcc.in
+++ b/config/cc/gcc.in
@@ -195,6 +195,7 @@
     bool
     select CC_GCC_4_3_or_later
     select CC_GCC_USE_GMP_MPFR
+    select CC_GCC_HAS_PKGVERSION_BUGURL
 
 config CC_GCC_4_3_or_later
     bool
@@ -205,6 +206,7 @@
     select CC_GCC_4_4_or_later
     select CC_GCC_USE_GMP_MPFR
     select CC_GCC_HAS_GRAPHITE
+    select CC_GCC_HAS_PKGVERSION_BUGURL
 
 config CC_GCC_4_4_or_later
     bool
@@ -217,6 +219,7 @@
     select CC_GCC_USE_MPC
     select CC_GCC_HAS_GRAPHITE
     select CC_GCC_HAS_LTO
+    select CC_GCC_HAS_PKGVERSION_BUGURL
 
 config CC_GCC_4_5_or_later
     bool
@@ -229,6 +232,7 @@
     select CC_GCC_USE_MPC
     select CC_GCC_HAS_GRAPHITE
     select CC_GCC_HAS_LTO
+    select CC_GCC_HAS_PKGVERSION_BUGURL
 
 config CC_GCC_4_6_or_later
     bool
@@ -248,6 +252,9 @@
 config CC_GCC_HAS_LTO
     bool
 
+config CC_GCC_HAS_PKGVERSION_BUGURL
+    bool
+
 # Only enable gcc's support for plugins if binutils has it as well
 # They are usefull only when doing LTO, but it does no harm enabling
 # them even without LTO.
diff --git a/config/cc/gcc.in.2 b/config/cc/gcc.in.2
--- a/config/cc/gcc.in.2
+++ b/config/cc/gcc.in.2
@@ -3,7 +3,7 @@
 config CC_PKGVERSION
     string
     prompt "gcc ID string"
-    depends on CC_GCC_4_3_or_later
+    depends on CC_GCC_HAS_PKGVERSION_BUGURL
     default "crosstool-NG-${CT_VERSION}"
     help
       Specify a string that identifies your package. You may wish to include
@@ -15,7 +15,7 @@
 config CC_BUGURL
     string
     prompt "gcc bug URL"
-    depends on CC_GCC_4_3_or_later
+    depends on CC_GCC_HAS_PKGVERSION_BUGURL
     default ""
     help
       Specify the URL that users should visit if they wish to report a bug.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 1 of 8] kconfig: remove useless 'default n'
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
                   ` (4 preceding siblings ...)
  2011-06-01 20:36 ` [PATCH 2 of 8] scripts/addToolVersion.sh: add a function to extract fields from versions Benoît THÉBAUDEAU
@ 2011-06-01 20:37 ` Benoît THÉBAUDEAU
  2011-06-03 21:49   ` Arnaud Lacombe
  2011-06-01 20:45 ` [PATCH 5 of 8] binutils: use the PKGVERSION and BUGURL options Benoît THÉBAUDEAU
                   ` (2 subsequent siblings)
  8 siblings, 1 reply; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:37 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306852059 -7200
# Node ID d124516c60a2f0559020400a8dfd1dbf339359a5
# Parent  fa3a18f9abcf9dde1535088554778fe4c4e5e831
kconfig: remove useless 'default n'

kconfig bools are disabled by default, so specifying 'default n' is useless and
noisy. This patch removes all occurrences of 'default n'.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/arch/arm.in.2 b/config/arch/arm.in.2
--- a/config/arch/arm.in.2
+++ b/config/arch/arm.in.2
@@ -28,11 +28,10 @@
 config ARCH_ARM_INTERWORKING
     bool
     prompt "Use Thumb-interworking (READ HELP)"
-    default n
     depends on EXPERIMENTAL
     help
       Excerpt from the gcc manual:
-      
+
       > Generate code which supports calling between the ARM and Thumb
       > instruction sets. Without this option the two instruction sets
       > cannot be reliably used inside one program. The default is
diff --git a/config/arch/powerpc.in.2 b/config/arch/powerpc.in.2
--- a/config/arch/powerpc.in.2
+++ b/config/arch/powerpc.in.2
@@ -3,12 +3,11 @@
 config ARCH_POWERPC_SPE
     bool
     prompt "Enable SPE support"
-    default n
     help
       Add support for the Signal Processing Engine.  This will set up
       the toolchain so that it supports the SPE ABI extensions. This
       mainly targets Freescale e500 processors.
-      
+
       Setting this option will append "spe" to the end of your target
       tuple name (e.g., powerpc-e500v2-linux-gnuspe) so that the gcc
       configure/build system will know to include SPE ABI support. It
diff --git a/config/backend.in b/config/backend.in
--- a/config/backend.in
+++ b/config/backend.in
@@ -6,8 +6,7 @@
 
 config BACKEND
     bool
-    default y if IS_A_BACKEND =  "y" || IS_A_BACKEND =  "Y"
-    default n if IS_A_BACKEND != "y" && IS_A_BACKEND != "Y"
+    default y if IS_A_BACKEND = "y" || IS_A_BACKEND = "Y"
 
 config BACKEND_ARCH
     string
diff --git a/config/binutils/binutils.in b/config/binutils/binutils.in
--- a/config/binutils/binutils.in
+++ b/config/binutils/binutils.in
@@ -121,7 +121,7 @@
     help
       Both the historical ld and the new gold linkers will be
       installed, with ld being the default linker used.
-      
+
       See help for gold, above.
 
 config BINUTILS_LINKER_GOLD_LD
@@ -136,7 +136,7 @@
     help
       Both the historical ld and the new gold linkers will be
       installed, with gold being the default linker used.
-      
+
       See help for gold, above.
 
 endchoice # Enable linkers
@@ -173,7 +173,7 @@
     depends on BINUTILS_LINKER_BOTH
     help
       Add an ld wrapper that calls to either gold or ld.
-      
+
       By default, the wrapper will call to the default wrapper,
       but if you set the environment variable CTNG_LD_IS, you
       can change which linker will get called:
@@ -201,7 +201,7 @@
     default ""
     help
       Extra flags passed onto ./configure when configuring
-      
+
       You can enter multiple arguments here, and arguments can contain spaces
       if they are properly quoted (or escaped, but prefer quotes). Eg.:
           --with-foo="1st arg with 4 spaces" --with-bar=2nd-arg-without-space
@@ -211,7 +211,6 @@
     prompt "binutils libraries for the target"
     depends on ! BARE_METAL
     depends on ! BACKEND
-    default n
     help
       Some utilities may need binutils libraries to be available on
       the target, eg. oprofile.
diff --git a/config/cc.in b/config/cc.in
--- a/config/cc.in
+++ b/config/cc.in
@@ -33,7 +33,6 @@
 config CC_LANG_CXX
     bool
     prompt "C++"
-    default n
     depends on CC_SUPPORT_CXX
     help
       Enable building a C++ compiler.
@@ -46,7 +45,6 @@
 config CC_LANG_FORTRAN
     bool
     prompt "Fortran"
-    default n
     depends on CC_SUPPORT_FORTRAN
     help
       Enable building a FORTRAN compiler.
@@ -57,7 +55,6 @@
 config CC_LANG_JAVA
     bool
     prompt "Java"
-    default n
     depends on CC_SUPPORT_JAVA
     help
       Enable building a Java compiler.
@@ -68,7 +65,6 @@
 config CC_LANG_ADA
     bool
     prompt "ADA (EXPERIMENTAL)"
-    default n
     depends on CC_SUPPORT_ADA
     depends on EXPERIMENTAL
     help
@@ -80,7 +76,6 @@
 config CC_LANG_OBJC
     bool
     prompt "Objective-C (EXPERIMENTAL)"
-    default n
     depends on CC_SUPPORT_OBJC
     depends on EXPERIMENTAL
     help
@@ -93,7 +88,6 @@
     bool
     prompt "Objective-C++ (EXPERIMENTAL)"
     depends on EXPERIMENTAL
-    default n
     depends on CC_SUPPORT_OBJCXX
     help
       Enable building an Objective C++ compiler.
diff --git a/config/cc/gcc.in b/config/cc/gcc.in
--- a/config/cc/gcc.in
+++ b/config/cc/gcc.in
@@ -19,15 +19,15 @@
     help
       Linaro is maintaining some advanced/more stable/experimental versions
       of gcc, especially for the ARM architecture.
-      
+
       Those versions have not been blessed by the gcc comunity (nor have they
       been cursed either!), but they look to be pretty much stable, and even
       more stable than the upstream versions. YMMV...
-      
+
       If you do not know what this Linaro stuff is, then simply say 'n' here,
       and rest in peace. OTOH, if you know what you are doing, you will be
       able to use and enjoy :-) the Linaro versions by saying 'y' here.
-      
+
       Linaro: http://www.linaro.org/
 
 choice
@@ -186,39 +186,32 @@
 
 config CC_GCC_4_2
     bool
-    default n
     select CC_GCC_4_2_or_later
 
 config CC_GCC_4_2_or_later
     bool
-    default n
 
 config CC_GCC_4_3
     bool
-    default n
     select CC_GCC_4_3_or_later
     select CC_GCC_USE_GMP_MPFR
 
 config CC_GCC_4_3_or_later
     bool
-    default n
     select CC_GCC_4_2_or_later
 
 config CC_GCC_4_4
     bool
-    default n
     select CC_GCC_4_4_or_later
     select CC_GCC_USE_GMP_MPFR
     select CC_GCC_HAS_GRAPHITE
 
 config CC_GCC_4_4_or_later
     bool
-    default n
     select CC_GCC_4_3_or_later
 
 config CC_GCC_4_5
     bool
-    default n
     select CC_GCC_4_5_or_later
     select CC_GCC_USE_GMP_MPFR
     select CC_GCC_USE_MPC
@@ -227,12 +220,10 @@
 
 config CC_GCC_4_5_or_later
     bool
-    default n
     select CC_GCC_4_4_or_later
 
 config CC_GCC_4_6
     bool
-    default n
     select CC_GCC_4_6_or_later
     select CC_GCC_USE_GMP_MPFR
     select CC_GCC_USE_MPC
@@ -241,12 +232,10 @@
 
 config CC_GCC_4_6_or_later
     bool
-    default n
     select CC_GCC_4_5_or_later
 
 config CC_GCC_HAS_GRAPHITE
     bool
-    default n
 
 # The way LTO works is a bit twisted.
 # See: http://gcc.gnu.org/wiki/LinkTimeOptimization#Requirements
@@ -258,7 +247,6 @@
 # advantage of it
 config CC_GCC_HAS_LTO
     bool
-    default n
 
 # Only enable gcc's support for plugins if binutils has it as well
 # They are usefull only when doing LTO, but it does no harm enabling
@@ -277,24 +265,20 @@
 
 config CC_GCC_USE_GMP_MPFR
     bool
-    default n
     select GMP_NEEDED
     select MPFR_NEEDED
 
 config CC_GCC_USE_PPL_CLOOG
     bool
-    default n
     select PPL_NEEDED
     select CLOOG_NEEDED
 
 config CC_GCC_USE_MPC
     bool
-    default n
     select MPC_NEEDED
 
 config CC_GCC_USE_LIBELF
     bool
-    default n
     select LIBELF_NEEDED
 
 config CC_VERSION
diff --git a/config/cc/gcc.in.2 b/config/cc/gcc.in.2
--- a/config/cc/gcc.in.2
+++ b/config/cc/gcc.in.2
@@ -27,7 +27,7 @@
     help
       Enter here the value of the gcc's ./configure option --enable-cxx-flags.
       Leave empty if you don't know better.
-      
+
       Note: just pass in the option _value_, that is only the part that goes
       after the '=' sign.
 
@@ -37,10 +37,10 @@
     default ""
     help
       Extra flags to pass onto ./configure when configuring the core gcc.
-      
+
       The core gcc is a stripped down, C-only compiler needed to build
       the C library. Kinda bootstrap gcc, if you wish.
-      
+
       You can enter multiple arguments here, and arguments can contain spaces
       if they are properly quoted (or escaped, but prefer quotes). Eg.:
           --with-foo="1st arg with 4 spaces" --with-bar=2nd-arg-without-space
@@ -52,7 +52,7 @@
     depends on ! BARE_METAL
     help
       Extra flags to pass onto ./configure when configuring gcc.
-      
+
       You can enter multiple arguments here, and arguments can contain spaces
       if they are properly quoted (or escaped, but prefer quotes). Eg.:
           --with-foo="1st arg with 4 spaces" --with-bar=2nd-arg-without-space
@@ -85,10 +85,10 @@
     select CC_GCC_USE_PPL_CLOOG
     help
       Enable the GRAPHITE loop optimsations.
-      
+
       This requires the PPL and CLooG companion libraries, and
       those will be automatically build for you.
-      
+
       On some systems (eg. Cygwin), PPL and/or CLooG may not
       build properly (yet), so you'll have to say 'N' here.
 
@@ -110,7 +110,7 @@
     select CC_GCC_USE_LIBELF if CC_GCC_4_5
     help
       Enable the Link Time Optimisations.
-      
+
       This will require the libelf companion library, and it
       wil be build automatically for you.
 
@@ -123,17 +123,16 @@
     default y
     help
       Pass --enable-target-optspace to crossgcc's configure.
-      
+
       This will compile crossgcc's libs with -Os.
 
 config CC_GCC_LIBMUDFLAP
     bool
     prompt "Compile libmudflap"
-    default n
     help
       libmudflap is a pointer-use checking tool, which can detect
       various mis-usages of pointers in C and (to some extents) C++.
-      
+
       You should say 'N' here, as libmduflap generates instrumented
       code (thus it is a bit bigger and a bit slower) and requires
       re-compilation and re-link, while it exists better run-time
@@ -143,22 +142,20 @@
 config CC_GCC_LIBGOMP
     bool
     prompt "Compile libgomp"
-    default n
     help
       libgomp is "the GNU implementation of the OpenMP Application Programming
       Interface (API) for multi-platform shared-memory parallel programming in
       C/C++ and Fortran". See:
         http://gcc.gnu.org/onlinedocs/libgomp/
-      
+
       The default is 'N'. Say 'Y' if you need it, and report success/failure.
 
 config CC_GCC_LIBSSP
     bool
     prompt "Compile libssp"
-    default n
     help
       libssp is the run-time Stack-Smashing Protection library.
-      
+
       The default is 'N'. Say 'Y' if you need it, and report success/failure.
 
 #-----------------------------------------------------------------------------
@@ -177,11 +174,10 @@
 config CC_GCC_DISABLE_PCH
     bool
     prompt "Do not build PCH"
-    default n
     help
       Say 'y' here to not use Pre-Compiled Headers in the resulting toolchain.
       at the expense of speed when compiling C++ code.
-      
+
       For some configurations (most notably canadian?), PCH are broken, and
       need to be disabled. Please see:
         http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40974
@@ -193,19 +189,19 @@
     default m
     help
       'sjlj' is short for setjmp/longjmp.
-      
+
       On some architectures, stack unwinding during exception handling
       works perfectly well without using sjlj, while on some others,
       use of sjlj is required for proper stack unwinding.
-      
+
        Option  | sjlj use           | Associated ./configure switch
       ---------+--------------------+--------------------------------
          Y     | forcibly used      | --enable-sjlj-exceptions
          M     | auto               | (none, ./configure decides)
          N     | forcibly not used  | --disable-sjlj-exceptions
-      
+
       It should be safe to say 'M' or 'N'.
-      
+
       It can happen that ./configure is wrong in some cases. Known
       case is for ARM big endian, where you should say 'N'.
 
@@ -219,5 +215,5 @@
       Saying 'N' will force gcc to use 64-bit wide long doubles
       Saying 'M' will let gcc choose (default is 128-bit for
                  glibc >= 2.4, 64-bit otherwise)
-      
+
       If in doubt, keep the default, ie. 'M'.
diff --git a/config/companion_libs.in b/config/companion_libs.in
--- a/config/companion_libs.in
+++ b/config/companion_libs.in
@@ -6,47 +6,39 @@
 
 config COMPLIBS_NEEDED
     bool
-    default n
 
 config GMP_NEEDED
     bool
-    default n
     select GMP
     select COMPLIBS_NEEDED
 
 config MPFR_NEEDED
     bool
-    default n
     select MPFR
     select COMPLIBS_NEEDED
 
 config PPL_NEEDED
     bool
-    default n
     select PPL
     select COMPLIBS_NEEDED
 
 config CLOOG_NEEDED
     bool
-    default n
     select CLOOG
     select COMPLIBS_NEEDED
 
 config MPC_NEEDED
     bool
-    default n
     select MPC
     select COMPLIBS_NEEDED
 
 config LIBELF_NEEDED
     bool
-    default n
     select LIBELF
     select COMPLIBS_NEEDED
 
 config COMPLIBS
     bool
-    default n
 
 config GMP
     bool
@@ -112,15 +104,14 @@
 config COMPLIBS_CHECK
     bool
     prompt "Check the companion libraries builds (!!! READ HELP!!!)"
-    default n
     help
       It is highly recommended to check the newly built companion libraries.
       Unfortunately, this is a very intensive task, and takes a loooong time.
-      
+
       Checking the newly built companion libraries is thus disabled by default,
       but it is suggested that you check them at least once on your machine,
       and if they work, disable the check on subsequent builds.
-      
+
       If you suspect that one (or more) of your companion libraries is the
       cause for incorrectly generated code, you should answer 'Y' here.
       Note however that this will take a really long time. For example,
diff --git a/config/companion_libs/ppl.in b/config/companion_libs/ppl.in
--- a/config/companion_libs/ppl.in
+++ b/config/companion_libs/ppl.in
@@ -42,9 +42,7 @@
 # For PPL 0.11, we need to pull libpwl if configured static
 config PPL_0_11
     bool
-    default n
     select PPL_NEEDS_LIBPWL if ! COMPLIBS_SHARED
 
 config PPL_NEEDS_LIBPWL
     bool
-    default n
diff --git a/config/config.mk b/config/config.mk
--- a/config/config.mk
+++ b/config/config.mk
@@ -106,12 +106,11 @@
 	    file="$(4)/$${entry}.in";                                           \
 	    _entry=$$(echo "$${entry}" |$(sed) -r -s -e 's/[-.+]/_/g;');        \
 	    echo "";                                                            \
-	    if [ "$(5)" = "Y" ]; then                                                                           \
-	      echo "config $(3)_$${_entry}_AVAILABLE";                                                          \
-	      echo "    bool";                                                                                  \
-	      echo "    default n if ! ( BACKEND_$(3) = \"$${entry}\" || BACKEND_$(3) = \"\" || ! BACKEND )";   \
-	      echo "    default y if BACKEND_$(3) = \"$${entry}\" || BACKEND_$(3) = \"\" || ! BACKEND";         \
-	    fi;                                                                                                 \
+	    if [ "$(5)" = "Y" ]; then                                                                     \
+	      echo "config $(3)_$${_entry}_AVAILABLE";                                                    \
+	      echo "    bool";                                                                            \
+	      echo "    default y if BACKEND_$(3) = \"$${entry}\" || BACKEND_$(3) = \"\" || ! BACKEND";   \
+	    fi;                                                                                           \
 	    echo "if $(3)_$${_entry}";                                          \
 	    echo "config $(3)";                                                 \
 	    echo "    default \"$${entry}\" if $(3)_$${_entry}";                \
diff --git a/config/debug/duma.in b/config/debug/duma.in
--- a/config/debug/duma.in
+++ b/config/debug/duma.in
@@ -15,7 +15,6 @@
     bool
     prompt "Build a shared library"
     default y if SHARED_LIBS
-    default n if ! SHARED_LIBS
 
 choice
     bool
diff --git a/config/debug/gdb.in.cross b/config/debug/gdb.in.cross
--- a/config/debug/gdb.in.cross
+++ b/config/debug/gdb.in.cross
@@ -16,11 +16,10 @@
 config GDB_CROSS_STATIC
     bool
     prompt "Build a static cross gdb"
-    default n
     help
       A static cross gdb can be usefull if you debug on a machine that is
       not the one that is used to compile the toolchain.
-      
+
       That way, you can share the cross-gdb without installing a toolchain
       on every machine that will be used to debug target programs.
 
diff --git a/config/debug/gdb.in.gdbserver b/config/debug/gdb.in.gdbserver
--- a/config/debug/gdb.in.gdbserver
+++ b/config/debug/gdb.in.gdbserver
@@ -3,7 +3,6 @@
 config GDB_GDBSERVER
     bool
     prompt "gdbserver"
-    default n
     depends on ! BARE_METAL
     help
       Build and install a gdbserver for the target, to run on the target.
diff --git a/config/debug/gdb.in.native b/config/debug/gdb.in.native
--- a/config/debug/gdb.in.native
+++ b/config/debug/gdb.in.native
@@ -3,7 +3,6 @@
 config GDB_NATIVE
     bool
     prompt "Native gdb"
-    default n
     depends on ! BARE_METAL
     depends on ! BACKEND
     help
@@ -13,13 +12,11 @@
 
 config GDB_NATIVE_NO_STATIC
     bool
-    default n
 
 config GDB_NATIVE_STATIC
     bool
     prompt "Build a static native gdb"
     depends on ! GDB_NATIVE_NO_STATIC
-    default n
     help
       In case you have trouble with dynamic loading of shared libraries,
       you will find that a static gdb comes in handy.
diff --git a/config/debug/ltrace.in b/config/debug/ltrace.in
--- a/config/debug/ltrace.in
+++ b/config/debug/ltrace.in
@@ -48,4 +48,3 @@
 
 config LTRACE_0_5_3_or_later
     bool
-    default n
diff --git a/config/global/ct-behave.in b/config/global/ct-behave.in
--- a/config/global/ct-behave.in
+++ b/config/global/ct-behave.in
@@ -5,25 +5,23 @@
 config OBSOLETE
     bool
     prompt "Use obsolete features"
-    default n
     help
       If you set this to Y, you will be able to select obsolete features.
-      
+
       Such obsolete features are the use of old kernel headers, old gcc
       versions, etc... for which maintaining support in crosstool-NG
       would be very costly.
-      
+
       It does not however mean that the specific feature or version has been
       marked obsolete by the upstream team.
 
 config EXPERIMENTAL
     bool
     prompt "Try features marked as EXPERIMENTAL"
-    default n
     help
       If you set this to Y, then you will be able to try very experimental
       features.
-      
+
       Experimental features can be one of:
         - working, in which case you should tell me it is!
         - buggy, in which case you could try patching and send me the result
@@ -34,7 +32,6 @@
 config DEBUG_CT
     bool
     prompt "Debug crosstool-NG"
-    default n
     depends on ! BACKEND
     help
       Say 'y' here to get some options regarding debugging crosstool-NG.
@@ -44,7 +41,6 @@
 config DEBUG_PAUSE_STEPS
     bool
     prompt "Pause between every steps"
-    default n
     help
       Say 'y' if you intend to attend the build, and want to investigate
       the result of each steps before running the next one.
@@ -52,14 +48,13 @@
 config DEBUG_CT_SAVE_STEPS
     bool
     prompt "Save intermediate steps"
-    default n
     help
       If you say 'y' here, then you will be able to restart crosstool-NG at
       any step.
-      
+
       It is not currently possible to restart at any of the debug facilities.
       They are treated as a whole.
-      
+
       To get the full list os steps, run: ct-ng list-steps
 
 config DEBUG_CT_SAVE_STEPS_GZIP
@@ -70,7 +65,7 @@
     help
       If you are tight on space, then you can ask to gzip the saved states
       tarballs. On the other hand, this takes some longer time...
-      
+
       To lose as less time as possible, the gzip process is done with a low
       compression ratio (-3), which gives roughly 70% gain in size. Going
       further doesn't gain much, and takes far more time (believe me, I've
@@ -80,17 +75,16 @@
     bool
     prompt "Do *not* overide LC_MESSAGES (EXPERIMENTAL)"
     depends on EXPERIMENTAL
-    default n
     help
       By default, crosstool-NG sets and exports LC_ALL=C so that the
       build.log file contains english messages, that can be read by
       people most likely to help interpret the logs. If you say N here,
       and your locale is not an english language, then dissecting your
       log file will be difficult for most people but you.
-      
+
       If you say Y here, then your current locale settings will be used
       to print messages, instead of plain english.
-      
+
       Say N, please.
 
 endif
diff --git a/config/global/download.in b/config/global/download.in
--- a/config/global/download.in
+++ b/config/global/download.in
@@ -5,14 +5,13 @@
 config FORBID_DOWNLOAD
     bool
     prompt "Forbid downloads"
-    default n
     help
       Normally, crosstool-NG will try to download missing tarballs (or
       checkout from CVS/SVN...).
       If you do not have network connectivity when you run crosstool-NG,
       and some files are missing, it can be a long time before crosstool-NG
       fails.
-      
+
       Saying 'y' here will prevent crosstool-NG from downloading missing
       files, thus failing early so that you don't get stuck.
 
@@ -21,21 +20,19 @@
 config FORCE_DOWNLOAD
     bool
     prompt "Force downloads"
-    default n
     help
       Force downloading tarballs, even if one already exists.
-      
+
       Usefull if you suspect a tarball to be damaged.
 
 config USE_MIRROR
     bool
     prompt "Use a mirror"
-    default n
     help
       If you have a machine on your LAN that mirrors some of the needed
       tarballs, you can say 'Y' here, and configure adequate values in
       the following options.
-      
+
       Obviously, nothing prevents you from using a mirror that is in fact
       *not* on your LAN, for example on another subnet of your company's
       network, or a mirror on the Internet.
@@ -45,7 +42,6 @@
 config PREFER_MIRROR
     bool
     prompt "Prefer the mirror"
-    default n
     help
       Say 'Y' here if you prefer the LAN miror over the upstream sources.
 
@@ -55,7 +51,7 @@
     default "http://ymorin.is-a-geek.org/mirrors/"
     help
       This is the base URL searched in for tarballs.
-      
+
       I (Yann E. MORIN) have set up such a mirror to host snapshots of
       some components, when those snapshots are volatile on the upstream
       servers. The mirror is *slow*, because it is hosted behind an ADSL
@@ -63,7 +59,7 @@
       but should the mirror be abused, I will. Please avoid using my
       machine when you can... Also, no guarantee is made as to its
       availability. Use at your own risks.
-      
+
       The mirror is available at:
         http://ymorin.is-a-geek.org/mirrors/
 
@@ -76,7 +72,7 @@
     help
       From the curl manual:
         Maximum time in seconds that you allow the connection to the server to take.
-      
+
       The scenario is as follows;
         - some enterprise networks have firewalls that prohibit FTP traffic, while
           still allowing HTTP
@@ -84,20 +80,19 @@
         - after this number of seconds, it is considered that the connection could
           not be established, and the next URL in the list is tried, until we reach
           an URL that will go through the firewall, most probably an http:// URL.
-      
+
       If you have a slow network, you'd better set this value higher than the default
       10s. If you know a firewall is blocking connections, but your network is globally
       fast, you can try to lower this value to jump more quickly to allowed URLs. YMMV.
-      
+
       Note that this value applies equally to wget if you have that installed.
 
 config ONLY_DOWNLOAD
     bool
     prompt "Stop after downloading tarballs"
-    default n
     help
       Only download the tarballs. Exit once it done.
-      
+
       Usefull to pre-retrieve the tarballs before going off-line.
 
 endif # ! FORBID_DOWNLOAD
diff --git a/config/global/extract.in b/config/global/extract.in
--- a/config/global/extract.in
+++ b/config/global/extract.in
@@ -5,10 +5,9 @@
 config FORCE_EXTRACT
     bool
     prompt "Force extractions"
-    default n
     help
       Force extraction of already exctracted tarballs.
-      
+
       Usefull if you suspect a previous extract did not complete (eg. broken
       tarball), or you added a new set of patches for this component.
 
@@ -35,10 +34,9 @@
 config ONLY_EXTRACT
     bool
     prompt "Stop after extracting tarballs"
-    default n
     help
       Exit after unpacking and patching tarballs.
-      
+
       Usefull to look at the code before doing the build itself.
 
 choice
@@ -98,12 +96,12 @@
     prompt "None"
     help
       Don't use any patch at all.
-      
+
       Please be carefull if you select this. Most components do require
       patches to properly build. It can happen, however, that support for
       your architecture is clean enough that you can build a toolchain
       with no patch. But most probably, this is *not* the case.
-      
+
       Be safe, use (the bundeld) patches.
 
 endchoice
@@ -118,11 +116,9 @@
 
 config PATCH_SINGLE
     bool
-    default n
 
 config PATCH_USE_LOCAL
     bool
-    default n
 
 config LOCAL_PATCH_DIR
     string
@@ -131,6 +127,6 @@
     depends on PATCH_USE_LOCAL
     help
       Enter the custom patch directory here.
-      
+
       Note that you must ensure that the directory contianing your custom
       patches is arranged the same way the official directory is.
diff --git a/config/global/logging.in b/config/global/logging.in
--- a/config/global/logging.in
+++ b/config/global/logging.in
@@ -59,7 +59,6 @@
 config LOG_SEE_TOOLS_WARN
     bool
     prompt "Warnings from the tools' builds"
-    default n
     depends on ! LOG_ERROR
     help
       Treat warnings from the different tools as crosstool-NG warnings.
@@ -78,7 +77,7 @@
     depends on ! LOG_ALL && ! LOG_DEBUG
     help
       If you say 'y' here, you'll be able to see the elapsed time.
-      
+
       As a bonus, you'll also get a rotating bar (/-\|) showing you
       that the build is not stalled (the bar rotates 1/4 every 10 lines
       of components build log).
diff --git a/config/global/paths.in b/config/global/paths.in
--- a/config/global/paths.in
+++ b/config/global/paths.in
@@ -15,7 +15,6 @@
     prompt "Save new tarballs" if ! BACKEND
     depends on LOCAL_TARBALLS_DIR != "" || BACKEND
     default y if BACKEND
-    default n if ! BACKEND
     help
       If you say 'y' here, new downloaded tarballs will be saved in the
       directory you entered above.
@@ -26,10 +25,10 @@
     default "${CT_TOP_DIR}/.build"
     help
       Set this to the directory where all build actions will be done.
-      
+
       The default is "${CT_TOP_DIR}/.build", and leaving this option
       empty will also use the default.
-      
+
       You should not need to change that, except in one very peculiar
       setup:
        - your crosstool-NG source directory is on the network
@@ -38,7 +37,7 @@
       access would have to go through the wire. In this case, you should
       set CT_WORK_DIR to point to a path local to your machine, to avoid
       any network overhead.
-      
+
       Do *NOT* change it if you don't know better.
 
 config PREFIX_DIR
@@ -54,7 +53,7 @@
     default "${CT_PREFIX_DIR}"
 #    help
 #      This is the path the toolchain will be installed into.
-#      
+#
 #      Normally, you would set this to ${CT_PREFIX_DIR}, but if for some reasons
 #      you can't write there, you can install somewhere else and have a third
 #      person do the install for you.
@@ -69,17 +68,17 @@
     help
       If you say 'y' here, then PREFIX_DIR (above) will be eradicated
       prior to the toolchain is built.
-      
+
       This can be usefull when you are trying different settings (due
       to build failures or feature tests). In this case, to avoid using
       a potentially broken previous toolchain, the install location is
       removed, to start afresh.
-      
+
       On the oher hand, if you are building a final toolchain, and install
       it into a directory with pre-install, unrelated programs, it would be
       damageable to remove that directory. In this case, you may want to
       say 'n' here.
-      
+
       Note that when acting as a backend, this option is not available, and
       is forced to 'n'.
 
@@ -98,7 +97,7 @@
     help
       Render the directory of the toolchain (and its sub-directories)
       read-only.
-      
+
       Usefull for toolchains destined for production.
 
 config STRIP_ALL_TOOLCHAIN_EXECUTABLES
diff --git a/config/kernel.in b/config/kernel.in
--- a/config/kernel.in
+++ b/config/kernel.in
@@ -6,18 +6,15 @@
 # we have a kernel or not (there might be different bare metal stuff)...
 config BARE_METAL
     bool
-    default n
 
 config MINGW32
     bool
-    default n
 
 # Each target OS (aka kernel) that support shared libraries can select
 # this, so the user can decide whether or not to build a shared library
 # enabled toolchain
 config KERNEL_SUPPORTS_SHARED_LIBS
     bool
-    default n
 
 config KERNEL
     string
@@ -36,7 +33,7 @@
     default y
     help
       Say 'y' here, unless you don't want shared libraries.
-      
+
       You might not want shared libraries if you're building for a target that
       don't support it (maybe some nommu targets, for example, or bare metal).
 
diff --git a/config/kernel/linux.in b/config/kernel/linux.in
--- a/config/kernel/linux.in
+++ b/config/kernel/linux.in
@@ -22,7 +22,7 @@
       If you have some pre-installed kernel headers lying around, you can
       enter the path to these headers, below, they will be copied from
       there, and into the toolchain's sysroot.
-      
+
       Note:
       This will *not* let you use a complete kernel tree!
       If you want to use your own full kernel tree, then you want to
@@ -83,16 +83,16 @@
     prompt "2.6.35.13 (longterm)"
     help
       The Linux 2.6.35 tree is a "longterm" maintenance branch.
-      
+
       It is intended to fill the niche for users who are not using distribution
       kernels but want to use a regression-free kernel for a longer time.
-      
+
       Critical bug fixes to later 2.6 releases are often ported to this branch
       which makes 2.6.35 a very useful base for many embedded developers seeking
       stable APIs or those who do not need the latest bleeding edge features.
-      
+
       ... and no, this kernel has not undergone any specific QA testing.
-      
+
       See the original announcement by Andi Kleen in the following mailing
       list entry:
         http://marc.info/?l=linux-kernel&m=129136895415202&w=4
@@ -110,16 +110,16 @@
     prompt "2.6.32.40 (longterm)"
     help
       The Linux 2.6.32 tree is a "longterm" maintenance branch.
-      
+
       It is intended to fill the niche for users who are not using distribution
       kernels but want to use a regression-free kernel for a longer time.
-      
+
       Critical bug fixes to later 2.6 releases are often ported to this branch
       which makes 2.6.32 a very useful base for many embedded developers seeking
       stable APIs or those who do not need the latest bleeding edge features.
-      
+
       ... and no, this kernel has not undergone any specific QA testing.
-      
+
       See the original announcement by Greg Kroah-Hartman in the following
       mailing list entry:
         http://marc.info/?l=linux-kernel&m=126384198403392&w=4
@@ -133,20 +133,20 @@
     prompt "2.6.27.59 (longterm)"
     help
       The Linux 2.6.27 tree is a "longterm" maintenance branch.
-      
+
       It is intended to fill the niche for users who are not using distribution
       kernels but want to use a regression-free kernel for a longer time.
-      
+
       Critical bug fixes to later 2.6 releases are often ported to this branch
       which makes 2.6.27 a very useful base for many embedded developers seeking
       stable APIs or those who do not need the latest bleeding edge features.
-      
+
       ... and no, this kernel has not undergone any specific QA testing.
-      
+
       See the original announcement by Adrian Bunk in the following mailing list
       entry:
         http://marc.info/?l=linux-kernel&m=122375909403298&w=4
-      
+
       It is now maintained by Greg Kroah-Hartman, see this mailing list entry:
         http://marc.info/?l=linux-kernel&m=129133701916793&w=4
 
@@ -199,17 +199,16 @@
 config KERNEL_LINUX_CUSTOM_IS_TARBALL
     bool
     prompt "This is a tarball"
-    default n
     help
       If you say 'n' here, the path above is expected to point to a directory
       containing readily prepared headers
-      
+
       If you say 'y' here, then the path above is expected to point to a
       tarball of such a directory.
-      
+
       Eg., if your headers are available in: /foo/bar/buz/my_hdrs/include,
       say 'n' here, and enter: /foo/bar/buz/my_hdrs below.
-      
+
       Now, passing a tarball around is easier than passing a directory, so
       if you want to, you can make a tarball of /foo/bar/buz/my_hdrs/include,
       say 'y' here, and enter the path to this tarball below.
diff --git a/config/libc.in b/config/libc.in
--- a/config/libc.in
+++ b/config/libc.in
@@ -11,11 +11,11 @@
       Enter the date of the snapshot you want to use in the form: YYYYMMDD
       where YYYY is the 4-digit year, MM the 2-digit month and DD the 2-digit
       day in the month.
-      
+
       Please note:
       - glibc has snapshots done every monday, and only the last ten are kept.
       - uClibc has daily snapshots, and only the last 30-or-so are kept.
-      
+
       So if you want to be able to re-build your toolchain later, you will
       have to save your C library tarball by yourself.
 
@@ -23,26 +23,21 @@
 
 config LIBC_SUPPORT_THREADS_ANY
     bool
-    default n
 
 config LIBC_SUPPORT_NPTL
     bool
-    default n
     select LIBC_SUPPORT_THREADS_ANY
 
 config LIBC_SUPPORT_LINUXTHREADS
     bool
-    default n
     select LIBC_SUPPORT_THREADS_ANY
 
 config LIBC_SUPPORT_WIN32THREADS
     bool
-    default n
     select LIBC_SUPPORT_THREADS_ANY
 
 config LIBC_SUPPORT_THREADS_NONE
     bool
-    default n
 
 config THREADS
     string
@@ -97,7 +92,7 @@
       you can run on your build system, and that will (try to)
       resolve shared libraries dependencies as if run on the
       target.
-      
+
       Note that the cross-ldd helper is not a full replacement
       for the native ldd. Please see the help, by running it
       with '--help' for more explanations.
diff --git a/config/libc/eglibc.in b/config/libc/eglibc.in
--- a/config/libc/eglibc.in
+++ b/config/libc/eglibc.in
@@ -89,12 +89,12 @@
     help
       Enter the revision of trunk you want to use.
       Default is HEAD.
-      
+
       A revision argument can be one of:
           NUMBER       revision number
           '{' DATE '}' revision at start of the date (*)
           'HEAD'       latest in repository
-      
+
       (*) If you want to use a date, please use ISO-8601 formats if
           at all possible.
 
@@ -102,12 +102,11 @@
     bool
     prompt "checkout instead of export"
     default y if LIBC_EGLIBC_V_TRUNK
-    default n if ! LIBC_EGLIBC_V_TRUNK
     help
       By default, the eglibc download will be an export of the subversion
       repository. If you say 'y' here, then the repository will instead be
       checked-out, so that you can update it later.
-      
+
       Note that crosstool-NG will *not* update your working copy, you will
       have to do that yourself.
 
@@ -121,7 +120,6 @@
 config EGLIBC_CUSTOM_CONFIG
     bool
     prompt "Use custom configuration file"
-    default n
     help
       Use a custom configuration file to disable some features in the eglibc
       library. The configuration file options are described in detail in the
diff --git a/config/libc/glibc-eglibc.in-common b/config/libc/glibc-eglibc.in-common
--- a/config/libc/glibc-eglibc.in-common
+++ b/config/libc/glibc-eglibc.in-common
@@ -36,9 +36,9 @@
       Some architectures need to set options in the file configparms.
       This is the case for sh3/4, which really need to set configparms
       to "no-z-defs=yes" as of gcc-3.4/glibc-2.3.2.
-      
+
       Unless you are building a toolchain for sh3/4, you should leave that empty.
-      
+
       Note: If you need to pass more than one value, separate them with
             '\n'. Eg.:  var1=val1\nvar2=val2
 
@@ -63,19 +63,18 @@
     bool
     prompt "Enable fortified build (EXPERIMENTAL)"
     depends on EXPERIMENTAL
-    default n
     help
       If you say 'y' here, then glibc will be using fortified versions
       of functions with format arguments (eg. vsyslog, printf...), and
       do a sanity check on the format at runtime, to avoid some of the
       common format string attacks.
-      
+
       This is currently not supported, and will most probably result in
       a broken build, with an error message like:
         ../misc/syslog.c: In function '__vsyslog_chk':
         ../misc/syslog.c:123: sorry, unimplemented: inlining failed in
         call to 'syslog': function body not available
-      
+
       If you are brave enough and want to debug the issue, then say 'y'
       here. Otherwise, be still and say 'n' (the default). ;-)
 
@@ -83,7 +82,6 @@
 config LIBC_DISABLE_VERSIONING
     bool
     prompt "Disable symbols versioning"
-    default n
     help
       Do not include versioning information in the library objects.
 
@@ -93,7 +91,7 @@
     default ""
     help
       Set the oldest ABI supported by the C library.
-      
+
       Setting this option, for example, to 2.2 will provide ABI support
       back to (e)glibc-2.2.
 
@@ -102,14 +100,13 @@
 config LIBC_GLIBC_FORCE_UNWIND
     bool
     prompt "Force unwind support (READ HELP!)"
-    default n
     help
       If your toolchain fails building while building the C library
       start files, or the complete C library, with a message like:
         configure: error: forced unwind support is required
-      
+
       then you may try setting this to 'y'. Otherwise, leave it to 'n'.
-      
+
       The issue seems to be related to building NPTL on old versions
       of glibc (and possibly eglibc as well) on some architectures
       (seen on s390, s390x and x86_64).
@@ -117,7 +114,6 @@
 config LIBC_GLIBC_USE_PORTS
     bool
     prompt "Use the ports addon"
-    default n
     help
       The ports addon contains some architecture ports that are not available
       in the official distribution.
@@ -161,11 +157,11 @@
     help
       Let ./configure decide what minimum kernel version glibc/eglibc
       will be able to run against.
-      
+
       This will inclde legacy compatibility code for older kernels in
       the C library, thus ensuring that it will run on a large number
       of old kernels.
-      
+
       The minimum kernel version supported will be dependent upon the
       target you build for. For example:
         alpha*-*-linux-gnu      Requires Linux 2.6.9 for NPTL
@@ -179,18 +175,18 @@
     help
       Normaly, you'll want glibc/eglibc to run against the same kernel
       version as the one used for the headers.
-      
+
       This is the default.
-      
+
       If enabled, crosstool-ng will use the chosen version of kernel
       headers for the glibc minimum kernel version supported, which is
       what gets passed to "--enable-kernel=" when configuring glibc.
-      
+
       Enabling this will ensure that no legacy compatibility code for
       older kernels is built into your C libraries, but it will
       be unable to run on kernel versions older than whichever kernel
       headers version you've built the toolchain for.
-      
+
       If you know for sure that your toolchain will never need to build
       applications that will run under a kernel version older than your
       chosen kernel headers version (CT_KERNEL_VERSION), you can choose
@@ -223,14 +219,14 @@
     help
       Enter here the lowest kernel version glibc/eglibc will be able to
       run against.
-      
+
       The minimum kernel version supported will be dependent upon the
       target you build for. For example:
         alpha*-*-linux-gnu      Requires Linux 2.6.9 for NPTL
         sh[34]-*-linux-gnu      Requires Linux 2.6.11
         powerpc*                Requires Linux 2.4.19
         arm*-*-linux-*gnueabi   Requires Linux 2.6.16
-      
+
       Note that no sanity check is performed by crosstool-NG to ensure
       that the value you enter here is appropriate for your target.
 
diff --git a/config/libc/mingw.in.2 b/config/libc/mingw.in.2
--- a/config/libc/mingw.in.2
+++ b/config/libc/mingw.in.2
@@ -3,17 +3,14 @@
 config MINGW_DIRECTX
     bool
     prompt "Include DirectX development files"
-    default n
 
 config MINGW_OPENGL
     bool
     prompt "Include OpenGL development files"
-    default n
 
 config MINGW_PDCURSES
     bool
     prompt "Include PDCurses (NCurses library) development files"
-    default n
 
 choice
     bool
@@ -45,7 +42,6 @@
 config MINGW_GNURX
     bool
     prompt "Include GnuRX (regex library) development files"
-    default n
 
 choice
     bool
diff --git a/config/libc/newlib.in.2 b/config/libc/newlib.in.2
--- a/config/libc/newlib.in.2
+++ b/config/libc/newlib.in.2
@@ -3,21 +3,18 @@
 config LIBC_NEWLIB_IO_C99FMT
     bool
     prompt "Enable IOs on C99 formats"
-    default n
     help
       Enable support for IOs on C99 formats.
 
 config LIBC_NEWLIB_IO_LL
     bool
     prompt "Enable IOs on long long"
-    default n
     help
       Enable support for IOs on long long integers.
 
 config LIBC_NEWLIB_IO_FLOAT
     bool
     prompt "Enable IOs on floats and doubles"
-    default n
     help
       Enable support for IOs on floating point
       values (float and double).
@@ -25,7 +22,6 @@
 config LIBC_NEWLIB_IO_LDBL
     bool
     prompt "Enable IOs on long doubles"
-    default n
     depends on LIBC_NEWLIB_IO_FLOAT
     help
       Enable support for IOs on long doubles.
diff --git a/config/libc/uClibc.in b/config/libc/uClibc.in
--- a/config/libc/uClibc.in
+++ b/config/libc/uClibc.in
@@ -87,12 +87,10 @@
 
 config LIBC_UCLIBC_0_9_30_or_later
     bool
-    default n
     select LIBC_UCLIBC_PARALLEL
 
 config LIBC_UCLIBC_PARALLEL
     bool
-    default n
 
 choice
     bool
@@ -156,5 +154,5 @@
     default ""
     help
       Path to the configuration file.
-      
+
       You _must_ provide one (for now).
diff --git a/config/libc/uClibc.in.2 b/config/libc/uClibc.in.2
--- a/config/libc/uClibc.in.2
+++ b/config/libc/uClibc.in.2
@@ -41,7 +41,6 @@
     bool
     select LIBC_UCLIBC_WCHAR
     prompt "Add support for locales"
-    default n
     help
       Say y if you want uClibc to support localisation.
 
@@ -62,7 +61,6 @@
 config LIBC_UCLIBC_WCHAR
     bool
     prompt "Add support for WCHAR"
-    default n
     help
       Say y if you want uClibc to support WCHAR.
 
diff --git a/config/target.in b/config/target.in
--- a/config/target.in
+++ b/config/target.in
@@ -44,24 +44,21 @@
 
 config ARCH_SUPPORTS_BOTH_MMU
     bool
-    default n
 
 config ARCH_DEFAULT_HAS_MMU
     bool
-    default n
 
 config ARCH_USE_MMU
     bool
     prompt "Use the MMU" if ARCH_SUPPORTS_BOTH_MMU
-    default n if ! ARCH_DEFAULT_HAS_MMU
     default y if ARCH_DEFAULT_HAS_MMU
     help
       If your architecture has an MMU and you want to use it,
       say 'Y' here.
-      
+
       OTOH, if you don't want to use the MMU, or your arch
       lacks an MMU, say 'N' here.
-      
+
       Note that some architectures (eg. ARM) has variants that
       lacks an MMU (eg. ARM Cortex-M3), while other variants
       have one (eg. ARM Cortex-A8).
@@ -69,15 +66,12 @@
 #--------------------------------------
 config ARCH_SUPPORTS_BOTH_ENDIAN
     bool
-    default n
 
 config ARCH_DEFAULT_BE
     bool
-    default n
 
 config ARCH_DEFAULT_LE
     bool
-    default n
 
 choice
     bool
@@ -99,19 +93,15 @@
 #--------------------------------------
 config ARCH_SUPPORTS_32
     bool
-    default n
 
 config ARCH_SUPPORTS_64
     bool
-    default n
 
 config ARCH_DEFAULT_32
     bool
-    default n
 
 config ARCH_DEFAULT_64
     bool
-    default n
 
 config ARCH_BITNESS
     int
@@ -141,23 +131,18 @@
 
 config ARCH_SUPPORT_ARCH
     bool
-    default n
 
 config ARCH_SUPPORT_ABI
     bool
-    default n
 
 config ARCH_SUPPORT_CPU
     bool
-    default n
 
 config ARCH_SUPPORT_TUNE
     bool
-    default n
 
 config ARCH_SUPPORT_FPU
     bool
-    default n
 
 config ARCH_ARCH
     string
@@ -169,13 +154,13 @@
       when generating assembly code. This option can be used in conjunction
       with or instead of the ARCH_CPU option (above), or a (command-line)
       -mcpu= option.
-      
+
       This is the configuration flag --with-arch=XXXX, and the runtime flag
       -march=XXX.
-      
+
       Pick a value from the gcc manual for your choosen gcc version and your
       target CPU.
-      
+
       Leave blank if you don't know, or if your target architecture does not
       offer this option.
 
@@ -205,13 +190,13 @@
       This specifies the name of the target processor. GCC uses this name
       to determine what kind of instructions it can emit when generating
       assembly code.
-      
+
       This is the configuration flag --with-cpu=XXXX, and the runtime flag
       -mcpu=XXX.
 
       Pick a value from the gcc manual for your choosen gcc version and your
       target CPU.
-      
+
       Leave blank if you don't know, or if your target architecture does not
       offer this option.
 
@@ -228,13 +213,13 @@
       specified in this option, but still choosing the instructions that it
       will generate based on the cpu specified by the ARCH_CPU option
       (above), or a (command-line) -mcpu= option.
-      
+
       This is the configuration flag --with-tune=XXXX, and the runtime flag
       -mtune=XXX.
-      
+
       Pick a value from the gcc manual for your choosen gcc version and your
       target CPU.
-      
+
       Leave blank if you don't know, or if your target architecture does not
       offer this option.
 
@@ -249,12 +234,12 @@
 
       This is the configuration flag --with-fpu=XXX, and the runtime flag
       -mfpu=XXX.
-      
+
       See below wether to actually emit FP opcodes, or to emulate them.
-      
+
       Pick a value from the gcc manual for your choosen gcc version and your
       target CPU.
-      
+
       Leave blank if you don't know, or if your target architecture does not
       offer this option.
 
@@ -267,12 +252,12 @@
     prompt "hardware (FPU)"
     help
       Emit hardware floating point opcodes.
-      
+
       If you've got a processor with a FPU, then you want that.
       If your hardware has no FPU, you still can use HW floating point, but
       need to compile support for FPU emulation in your kernel. Needless to
       say that emulating the FPU is /slooowwwww/...
-      
+
       One situation you'd want HW floating point without a FPU is if you get
       binary blobs from different vendors that are compiling this way and
       can't (don't wan't to) change.
@@ -282,7 +267,7 @@
     prompt "software"
     help
       Do not emit any hardware floating point opcode.
-      
+
       If your processor has no FPU, then you most probably want this, as it
       is faster than emulating the FPU in the kernel.
 
@@ -295,10 +280,10 @@
     help
       Used to add specific options when compiling libraries of the toolchain,
       that will run on the target (eg. libc.so).
-      
+
       Note that the options above for ARCH, ABI, CPU, TUNE and FPU will be
       automaticaly used. You don't need to specify them here.
-      
+
       Leave blank if you don't know better.
 
 config TARGET_LDFLAGS
@@ -308,7 +293,7 @@
     help
       Used to add specific options when linking libraries of the toolchain,
       that will run on your target.
-      
+
       Leave blank if you don't know better.
 
 source "config.gen/arch.in.2"
diff --git a/config/test_suite.in b/config/test_suite.in
--- a/config/test_suite.in
+++ b/config/test_suite.in
@@ -6,13 +6,11 @@
 
 config TEST_SUITE
     bool
-    default n
 
 config TEST_SUITE_GCC
     bool
     prompt "GCC test suite"
     depends on EXPERIMENTAL
-    default n
     select TEST_SUITE
     help
       Select this option to install the GCC test suite in $CT_PREFIX_DIR/test_suite.
@@ -22,7 +20,7 @@
 
       For some tests a network enabled target with ssh server is required.
 
-      A helper Makefile is provided for running the tests - please see the included 
+      A helper Makefile is provided for running the tests - please see the included
       README for information on how to run the test suite.
 
 endmenu
diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -5,7 +5,6 @@
 config FORCE_SYSROOT
     bool
     default y if !OBSOLETE
-    default n if OBSOLETE
     select USE_SYSROOT
 
 config USE_SYSROOT
@@ -15,7 +14,7 @@
     help
       Use the 'shinny new' sysroot feature of gcc: libraries split between
       prefix/target/sysroot/lib and prefix/target/sysroot/usr/lib
-      
+
       You definitely want to say 'Y' here. Yes you do. I know you do. Say 'Y'.
 
 config SYSROOT_NAME
@@ -26,7 +25,7 @@
     help
       Enter the base name of the sysroot directory. Usually, this simply
       is 'sysroot' (the default) or 'sys-root'.
-      
+
       You are free to enter anything here, except for spaces, and '/'
       (see SYSROOT_DIR_PREFIX, below). If you leave this empy, then the
       default 'sysroot' is used.
@@ -40,10 +39,10 @@
       *
       * Unless you realy know you need that, leave it empty!
       *
-      
+
       This string will be interpreted as a directory component to be added
       to the sysroot path, just before the actual sysroot directory.
-      
+
       In fact, the sysroot path is constructed as:
         ${CT_PREFIX_DIR}/${CT_TARGET}/${CT_SYSROOT_DIR_PREFIX}/${CT_SYSROOT_NAME}
 
@@ -51,20 +50,19 @@
     bool
     prompt "Build Static Toolchain (EXPERIMENTAL)"
     depends on EXPERIMENTAL
-    default n
     help
       Build static host binaries.
-      
+
       If you wish to move the toolchain to another host, and you are not
       confident that this host has the required versions of system libs, then
       you can say 'Y' here, and all the host tools will be linked staticaly.
-      
+
       The impacted tools are:
         - the GNU binutils
         - the cross-gdb
-      
+
       The default is 'N', to build dynamicaly-linked host binaries.
-      
+
       NOTE: this has no connection to whether the target libraries will be
       dynamic or static. This only applies to the tools themselves.
 
@@ -76,12 +74,12 @@
     default "unknown"
     help
       Vendor part of the target tuple.
-      
+
       A tuple is of the form arch-vendor-kernel-system.
       You can set the second part, vendor, to whatever you see fit.
       Use a single word, or use underscores "_" to separate words.
       Use neither dash nor space, as it breaks things.
-      
+
       Keep the default (unknown) if you don't know better.
 
 config TARGET_ALIAS_SED_EXPR
@@ -92,14 +90,14 @@
       Normaly, you'd call your toolchain components (especially gcc) by
       prefixing the target tuple followed by a dash and the component name
       (eg. armeb-unknown-linux-uclibc-gcc).
-      
+
       You can enter here a sed expression to be applied to ${CT_TARGET} to
       create an alias for your toolchain.
-      
+
       For example, "s/${CT_TARGET_VENDOR}/foobar/" (without the double quotes)
       will create the armeb-foobar-linux-uclibc alias to the above-mentioned
       toolchain.
-      
+
       You shouldn't need to enter anything here, unless you plan to manually
       call the tools (autotools-based ./configure will use the standard name).
 
@@ -111,12 +109,12 @@
       Normaly, you'd call your toolchain components (especially gcc) by
       prefixing the target tuple followed by a dash and the component name
       (eg. armeb-unknown-linux-uclibc-gcc).
-      
+
       You can enter a shortcut here. This string will be used to create
       symbolic links to the toolchain tools (eg. if you enter "foo-bar" here,
       then gcc for your toolchain will also be available as "foo-bar-gcc" along
       with the original name).
-      
+
       You shouldn't need to enter anything here, unless you plan to manually
       call the tools (autotools-based ./configure will use the standard name).
 
@@ -169,7 +167,7 @@
 
 comment "Build system"
 
-config BUILD 
+config BUILD
     string
     prompt "|  Tuple        (READ HELP!)"
     default ""
@@ -184,18 +182,18 @@
     help
       If you have your *build system* tools in a weird location, and/or
       they have an unusual prefix, enter it here.
-      
+
       Usually, you should leave that empty!
-      
+
       Eg.:
         If your *build* gcc is /opt/build-tools/bin/weird-gcc then you
         should enter:
             /opt/build-tools/bin/weird-
-        
+
         If your *build* gcc is /opt/build-tools/bin/weird-gcc and
         /opt/build-tools/bin is in your PATH, you should enter:
             weird-
-        
+
         If your *build* gcc is /opt/build-tools/bin/gcc then you
         should enter (do not forget to add the trailing '/'):
             /opt/build-tools/bin/
@@ -207,14 +205,14 @@
     help
       If your *build system* tools have an unusual suffix, enter it
       here.
-      
+
       Usually, you should leave that empty!
-      
+
       Eg.:
         If your 'default' gcc is gcc 4.3.1, but you also have gcc-3.4.2
         installed as gcc-3.4, then you should enter:
             -3.4
-      
+
       It can happen that some of the tools have a suffix, when others
       don't, eg. you can have 'gcc-3.4' and 'ar'. crosstool-NG accounts
       for that by checking the tools without the suffix in case it can
@@ -238,18 +236,18 @@
     help
       If you have your *host system* tools in a weird location, and/or
       they have an unusual prefix, enter it here.
-      
+
       Usually, you should leave that empty!
-      
+
       Eg.:
         If your *host* gcc is /opt/host-tools/bin/weird-gcc then you
         should enter:
             /opt/host-tools/bin/weird-
-        
+
         If your *host* gcc is /opt/host-tools/bin/weird-gcc and
         /opt/host-tools/bin is in your PATH, you should enter:
             weird-
-        
+
         If your *host* gcc is /opt/host-tools/bin/gcc then you
         should enter (do not forget to add the trailing '/'):
             /opt/host-tools/bin/
@@ -261,14 +259,14 @@
     help
       If your *host system* tools have an unusual suffix, enter it
       here.
-      
+
       Usually, you should leave that empty!
-      
+
       Eg.:
         If your 'default' gcc is gcc 4.3.1, but you also have gcc-3.4.2
         installed as gcc-3.4, then you should enter:
             -3.4
-      
+
       It can happen that some of the tools have a suffix, when others
       don't, eg. you can have 'gcc-3.4' and 'ar'. crosstool-NG accounts
       for that by checking the tools without the suffix in case it can
@@ -287,18 +285,18 @@
     help
       If you have your *target system* tools in a weird location, and/or
       they have an unusual prefix, enter it here.
-      
+
       Usually, you should leave that empty!
-      
+
       Eg.:
         If your *target* gcc is /opt/target-tools/bin/weird-gcc then you
         should enter:
             /opt/target-tools/bin/weird-
-        
+
         If your *target* gcc is /opt/target-tools/bin/weird-gcc and
         /opt/target-tools/bin is in your PATH, you should enter:
             weird-
-        
+
         If your *target* gcc is /opt/target-tools/bin/gcc then you
         should enter (do not forget to add the trailing '/'):
             /opt/target-tools/bin/
@@ -310,14 +308,14 @@
     help
       If your *target system* tools have an unusual suffix, enter it
       here.
-      
+
       Usually, you should leave that empty!
-      
+
       Eg.:
         If your 'default' gcc is gcc 4.3.1, but you also have gcc-3.4.2
         installed as gcc-3.4, then you should enter:
             -3.4
-      
+
       It can happen that some of the tools have a suffix, when others
       don't, eg. you can have 'gcc-3.4' and 'ar'. crosstool-NG accounts
       for that by checking the tools without the suffix in case it can

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 6 of 8] eglibc: use the PKGVERSION and BUGURL options
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
                   ` (6 preceding siblings ...)
  2011-06-01 20:45 ` [PATCH 5 of 8] binutils: use the PKGVERSION and BUGURL options Benoît THÉBAUDEAU
@ 2011-06-01 20:45 ` Benoît THÉBAUDEAU
  2011-06-01 21:18 ` [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Yann E. MORIN
  8 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:45 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306868130 -7200
# Node ID 213c4dc5316c83baffe7e431cd70b73c8c8b835b
# Parent  0a04ab980089daa608da6fc0490b9189487bb5d1
eglibc: use the PKGVERSION and BUGURL options

This patch makes eglibc benefit from the TOOLCHAIN_PKGVERSION and
TOOLCHAIN_BUGURL options.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/libc/eglibc.in b/config/libc/eglibc.in
--- a/config/libc/eglibc.in
+++ b/config/libc/eglibc.in
@@ -22,22 +22,27 @@
     bool
     prompt "2_13"
     depends on EXPERIMENTAL
+    select LIBC_EGLIBC_2_13_or_later
 
 config LIBC_EGLIBC_V_2_12
     bool
     prompt "2_12"
+    select LIBC_EGLIBC_2_12_or_later
 
 config LIBC_EGLIBC_V_2_11
     bool
     prompt "2_11"
+    select LIBC_EGLIBC_2_11_or_later
 
 config LIBC_EGLIBC_V_2_10
     bool
     prompt "2_10"
+    select LIBC_EGLIBC_2_10_or_later
 
 config LIBC_EGLIBC_V_2_9
     bool
     prompt "2_9"
+    select LIBC_EGLIBC_2_9_or_later
 
 config LIBC_EGLIBC_V_2_8
     bool
@@ -62,6 +67,7 @@
 config LIBC_EGLIBC_V_TRUNK
     bool
     prompt "'trunk'"
+    select LIBC_EGLIBC_2_13_or_later
     help
       Selecting this will export the trunk of the eglibc subversion repository.
 
@@ -82,6 +88,29 @@
     default "2_5" if LIBC_EGLIBC_V_2_5
     default "trunk" if LIBC_EGLIBC_V_TRUNK
 
+config LIBC_EGLIBC_2_13_or_later
+    bool
+    select LIBC_EGLIBC_2_12_or_later
+
+config LIBC_EGLIBC_2_12_or_later
+    bool
+    select LIBC_EGLIBC_2_11_or_later
+
+config LIBC_EGLIBC_2_11_or_later
+    bool
+    select LIBC_EGLIBC_2_10_or_later
+
+config LIBC_EGLIBC_2_10_or_later
+    bool
+    select LIBC_EGLIBC_2_9_or_later
+
+config LIBC_EGLIBC_2_9_or_later
+    bool
+    select LIBC_EGLIBC_HAS_PKGVERSION_BUGURL
+
+config LIBC_EGLIBC_HAS_PKGVERSION_BUGURL
+    bool
+
 config EGLIBC_REVISION
     string
     prompt "Revision to use"
diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -73,7 +73,7 @@
     help
       Specify a string that identifies your package. You may wish to include
       a build number or build date. This version string will be included in
-      the output of gcc --version, and also in binutils.
+      the output of gcc --version, and also in binutils, eglibc.
 
       This is passed to the configure flag --with-pkgversion.
 
diff --git a/scripts/addToolVersion.sh b/scripts/addToolVersion.sh
--- a/scripts/addToolVersion.sh
+++ b/scripts/addToolVersion.sh
@@ -137,6 +137,22 @@
                 SedExpr1="${SedExpr1}\n    select BINUTILS_2_18_or_later"
             fi
             ;;
+        eglibc)
+            # Extract 'M'ajor and 'm'inor from version string
+            ver_M=$(getVersionField "${version}" . 1)
+            ver_m=$(getVersionField "${version}" . 2)
+            if [   \( ${ver_M} -eq 2 -a ${ver_m} -eq 13 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select LIBC_EGLIBC_2_13_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 12 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select LIBC_EGLIBC_2_12_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 11 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select LIBC_EGLIBC_2_11_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 10 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select LIBC_EGLIBC_2_10_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 9 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select LIBC_EGLIBC_2_9_or_later"
+            fi
+            ;;
         uClibc)
             # uClibc-0.9.30 and above need some love
             ver_M=$(getVersionField "${version}" . 1)
diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common
--- a/scripts/build/libc/glibc-eglibc.sh-common
+++ b/scripts/build/libc/glibc-eglibc.sh-common
@@ -234,6 +234,11 @@
         *)  extra_config+=("--enable-add-ons=$(do_libc_add_ons_list ,)");;
     esac
 
+    if [ "${CT_LIBC_EGLIBC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
+        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+    fi
+
     extra_cc_args="${extra_cc_args} ${CT_ARCH_ENDIAN_OPT}"
 
     touch config.cache
@@ -245,7 +250,7 @@
     # Pre-seed the configparms file with values from the config option
     printf "${CT_LIBC_GLIBC_CONFIGPARMS}\n" > configparms
 
-    cross_cc=$(CT_Which "${CT_TARGET}-gcc")    
+    cross_cc=$(CT_Which "${CT_TARGET}-gcc")
 
     CT_DoLog DEBUG "Using gcc for target:     '${cross_cc}'"
     CT_DoLog DEBUG "Configuring with addons : '$(do_libc_add_ons_list ,)'"
@@ -296,7 +301,7 @@
         --with-headers="${CT_HEADERS_DIR}"                          \
         "${extra_config[@]}"                                        \
         "${CT_LIBC_GLIBC_EXTRA_CONFIG_ARRAY[@]}"
-    
+
     # build hacks
     case "${CT_ARCH},${CT_ARCH_CPU}" in
         powerpc,8??)

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH 5 of 8] binutils: use the PKGVERSION and BUGURL options
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
                   ` (5 preceding siblings ...)
  2011-06-01 20:37 ` [PATCH 1 of 8] kconfig: remove useless 'default n' Benoît THÉBAUDEAU
@ 2011-06-01 20:45 ` Benoît THÉBAUDEAU
  2011-06-01 20:45 ` [PATCH 6 of 8] eglibc: " Benoît THÉBAUDEAU
  2011-06-01 21:18 ` [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Yann E. MORIN
  8 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 20:45 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1306867182 -7200
# Node ID 0a04ab980089daa608da6fc0490b9189487bb5d1
# Parent  53773e635418516baed312be0ba3616332a8e30b
binutils: use the PKGVERSION and BUGURL options

This patch makes binutils benefit from the TOOLCHAIN_PKGVERSION and
TOOLCHAIN_BUGURL options.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/binutils/binutils.in b/config/binutils/binutils.in
--- a/config/binutils/binutils.in
+++ b/config/binutils/binutils.in
@@ -17,22 +17,27 @@
 config BINUTILS_V_2_20_1
     bool
     prompt "2.20.1"
+    select BINUTILS_2_20_or_later
 
 config BINUTILS_V_2_20
     bool
     prompt "2.20"
+    select BINUTILS_2_20_or_later
 
 config BINUTILS_V_2_19_1
     bool
     prompt "2.19.1"
+    select BINUTILS_2_19_or_later
 
 config BINUTILS_V_2_19
     bool
     prompt "2.19"
+    select BINUTILS_2_19_or_later
 
 config BINUTILS_V_2_18
     bool
     prompt "2.18"
+    select BINUTILS_2_18_or_later
 
 config BINUTILS_V_2_17
     bool
@@ -61,9 +66,22 @@
 
 config BINUTILS_2_21_or_later
     bool
+    select BINUTILS_2_20_or_later
     select BINUTILS_HAS_GOLD
     select BINUTILS_HAS_PLUGINS
 
+config BINUTILS_2_20_or_later
+    bool
+    select BINUTILS_2_19_or_later
+
+config BINUTILS_2_19_or_later
+    bool
+    select BINUTILS_2_18_or_later
+
+config BINUTILS_2_18_or_later
+    bool
+    select BINUTILS_HAS_PKGVERSION_BUGURL
+
 config BINUTILS_HAS_GOLD
     bool
 
@@ -73,6 +91,9 @@
 config BINUTILS_HAS_PLUGINS
     bool
 
+config BINUTILS_HAS_PKGVERSION_BUGURL
+    bool
+
 # Only these architectures have support in gold
 config ARCH_arm
     select BINUTILS_GOLD_SUPPORTS_ARCH
diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -73,7 +73,7 @@
     help
       Specify a string that identifies your package. You may wish to include
       a build number or build date. This version string will be included in
-      the output of gcc --version.
+      the output of gcc --version, and also in binutils.
 
       This is passed to the configure flag --with-pkgversion.
 
diff --git a/scripts/addToolVersion.sh b/scripts/addToolVersion.sh
--- a/scripts/addToolVersion.sh
+++ b/scripts/addToolVersion.sh
@@ -123,6 +123,20 @@
                 SedExpr1="${SedExpr1}\n    select CC_GCC_4_2"
             fi
             ;;
+        binutils)
+            # Extract 'M'ajor and 'm'inor from version string
+            ver_M=$(getVersionField "${version}" . 1)
+            ver_m=$(getVersionField "${version}" . 2)
+            if [   \( ${ver_M} -eq 2 -a ${ver_m} -eq 21 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select BINUTILS_2_21_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 20 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select BINUTILS_2_20_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 19 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select BINUTILS_2_19_or_later"
+            elif [ \( ${ver_M} -eq 2 -a ${ver_m} -eq 18 \)  ]; then
+                SedExpr1="${SedExpr1}\n    select BINUTILS_2_18_or_later"
+            fi
+            ;;
         uClibc)
             # uClibc-0.9.30 and above need some love
             ver_M=$(getVersionField "${version}" . 1)
diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
--- a/scripts/build/binutils/binutils.sh
+++ b/scripts/build/binutils/binutils.sh
@@ -55,6 +55,10 @@
     if [ "${CT_BINUTILS_PLUGINS}" = "y" ]; then
         extra_config+=( --enable-plugins )
     fi
+    if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
+        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+    fi
 
     CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
 
@@ -141,6 +145,12 @@
         CT_Pushd "${CT_BUILD_DIR}/build-binutils-for-target"
 
         CT_DoLog EXTRA "Configuring binutils for target"
+
+        if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
+            [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
+            [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        fi
+
         CT_DoExecLog CFG                                            \
         "${CT_SRC_DIR}/binutils-${CT_BINUTILS_VERSION}/configure"   \
             --build=${CT_BUILD}                                     \

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-01 20:36 ` [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION Benoît THÉBAUDEAU
@ 2011-06-01 21:16   ` Yann E. MORIN
  2011-06-01 21:41     ` Benoît THÉBAUDEAU
  2011-06-03 21:44   ` [PATCH 8 of 8] " Arnaud Lacombe
  1 sibling, 1 reply; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-01 21:16 UTC (permalink / raw)
  To: Benoît THÉBAUDEAU; +Cc: crossgcc

Benoit, All,

On Wednesday 01 June 2011 22:36:00 Benoît THÉBAUDEAU wrote:
> # HG changeset patch
> # User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
> # Date 1306960344 -7200
> # Node ID b96b4403c850000dfe69b7d64bc4d65542007290
> # Parent  9e3cbe13deae566d9ec0c31f38afe238f7c9660d
> kconfig: prepend CT-NG's version tag to PKGVERSION
[--SNIP--]
> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
> --- a/scripts/build/binutils/binutils.sh
> +++ b/scripts/build/binutils/binutils.sh
> @@ -56,8 +56,8 @@
>          extra_config+=( --enable-plugins )
>      fi
>      if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
> -        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")

Compute the string only once. Eg. in scripts/crosstool-ng.sh.in:
  CT_PKGVERSION="crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}"

Then use "${CT_PKGVERSION}" every where: gcc, gdb...
Ditto bugurl.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools
  2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
                   ` (7 preceding siblings ...)
  2011-06-01 20:45 ` [PATCH 6 of 8] eglibc: " Benoît THÉBAUDEAU
@ 2011-06-01 21:18 ` Yann E. MORIN
  2011-06-01 21:35   ` Benoît THÉBAUDEAU
  2011-06-04 14:19   ` Yann E. MORIN
  8 siblings, 2 replies; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-01 21:18 UTC (permalink / raw)
  To: Benoît THÉBAUDEAU; +Cc: crossgcc

Benoit, All,

On Wednesday 01 June 2011 22:35:52 Benoît THÉBAUDEAU wrote:
> This is a new revision of my previous patch series about the same subject,
> taking your comments into account.

Applying patches 1..7.
Space-damage in most patches. I will fix here.

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools
  2011-06-01 21:18 ` [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Yann E. MORIN
@ 2011-06-01 21:35   ` Benoît THÉBAUDEAU
  2011-06-04 14:19   ` Yann E. MORIN
  1 sibling, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 21:35 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

Yann, all,

> Applying patches 1..7.

Great!

> Space-damage in most patches. I will fix here.

Yes, I had noticed that. The spaces removed were only useless trailing spaces,
so I did not change the patches for that. Keep these spaces if you prefer.

> Thank you!

You're welcome.

Best regards,
Benoît

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-01 21:16   ` Yann E. MORIN
@ 2011-06-01 21:41     ` Benoît THÉBAUDEAU
  2011-06-01 21:48       ` Yann E. MORIN
  0 siblings, 1 reply; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-01 21:41 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

Yann, all,

> Compute the string only once. Eg. in scripts/crosstool-ng.sh.in:
>   CT_PKGVERSION="crosstool-NG
>   ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ -
>   ${CT_TOOLCHAIN_PKGVERSION}}"
>
> Then use "${CT_PKGVERSION}" every where: gcc, gdb...

OK. I'll do that on Friday.

> Ditto bugurl.

Why? There is no string computation for bugurl. Do you want something like
CT_BUGURL="${CT_TOOLCHAIN_BUGURL}"
then use "${CT_BUGURL}" everywhere?

Best regards,
Benoît

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-01 21:41     ` Benoît THÉBAUDEAU
@ 2011-06-01 21:48       ` Yann E. MORIN
  2011-06-03 16:38         ` [PATCH] " Benoît THÉBAUDEAU
  0 siblings, 1 reply; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-01 21:48 UTC (permalink / raw)
  To: crossgcc; +Cc: Benoît THÉBAUDEAU

Benoit, All,

On Wednesday 01 June 2011 23:41:34 Benoît THÉBAUDEAU wrote:
> > Ditto bugurl.
> Why? There is no string computation for bugurl. Do you want something like
> CT_BUGURL="${CT_TOOLCHAIN_BUGURL}"
> then use "${CT_BUGURL}" everywhere?

Forget it... My bad. I just saw a change in the bugurl line, but I did not
look what it was.

/me should go to bed.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-01 21:48       ` Yann E. MORIN
@ 2011-06-03 16:38         ` Benoît THÉBAUDEAU
  2011-06-03 21:47           ` Yann E. MORIN
  2011-06-04 13:36           ` Yann E. MORIN
  0 siblings, 2 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-03 16:38 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
# Date 1307114516 -7200
# Node ID b5541f296b921fe7e00748576e85ee1cf1de48a3
# Parent  02b7285c078f27acbe56d5df86e373d7e420c265
kconfig: prepend CT-NG's version tag to PKGVERSION

"crosstool-NG-${CT_VERSION}" is currently the default for TOOLCHAIN_PKGVERSION,
and this options is passed as is to --with-pkgversion.

This patch prepends "crosstool-NG ${CT_VERSION}" to TOOLCHAIN_PKGVERSION before
passing it to --with-pkgversion.

Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>

diff --git a/config/toolchain.in b/config/toolchain.in
--- a/config/toolchain.in
+++ b/config/toolchain.in
@@ -78,13 +78,18 @@
 config TOOLCHAIN_PKGVERSION
     string
     prompt "Toolchain ID string"
-    default "crosstool-NG-${CT_VERSION}"
+    default ""
     help
       Specify a string that identifies your package. You may wish to include
       a build number or build date. This version string will be included in
       the output of gcc --version, and also in binutils, eglibc, gdb and
       gdbserver.
 
+      If this string is left empty, the actual package version will be:
+          "crosstool-NG ${CT_VERSION}"
+      Otherwise, it will be:
+          "crosstool-NG ${CT_VERSION} - ${CT_TOOLCHAIN_PKGVERSION}"
+
       This is passed to the configure flag --with-pkgversion.
 
 config TOOLCHAIN_BUGURL
diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
--- a/scripts/build/binutils/binutils.sh
+++ b/scripts/build/binutils/binutils.sh
@@ -56,8 +56,8 @@
         extra_config+=( --enable-plugins )
     fi
     if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=${CT_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
@@ -147,8 +147,8 @@
         CT_DoLog EXTRA "Configuring binutils for target"
 
         if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-            [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-            [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+            extra_config+=("--with-pkgversion=${CT_PKGVERSION}")
+            [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
         fi
 
         CT_DoExecLog CFG                                            \
diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
--- a/scripts/build/cc/gcc.sh
+++ b/scripts/build/cc/gcc.sh
@@ -161,8 +161,8 @@
 
     if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
         # Bare metal delivers the core compiler as final compiler, so add version info and bugurl
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=${CT_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     if [ "${copy_headers}" = "y" ]; then
@@ -405,8 +405,8 @@
 
     [ "${CT_SHARED_LIBS}" = "y" ] || extra_config+=("--disable-shared")
     if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=${CT_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
     case "${CT_CC_GCC_SJLJ_EXCEPTIONS}" in
         y)  extra_config+=("--enable-sjlj-exceptions");;
diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
--- a/scripts/build/debug/300-gdb.sh
+++ b/scripts/build/debug/300-gdb.sh
@@ -99,8 +99,8 @@
     esac
 
     if [ "${CT_GDB_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=${CT_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     if [ "${CT_GDB_CROSS}" = "y" ]; then
diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common
--- a/scripts/build/libc/glibc-eglibc.sh-common
+++ b/scripts/build/libc/glibc-eglibc.sh-common
@@ -240,8 +240,8 @@
     esac
 
     if [ "${CT_LIBC_EGLIBC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
-        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
-        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
+        extra_config+=("--with-pkgversion=${CT_PKGVERSION}")
+        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
     fi
 
     extra_cc_args="${extra_cc_args} ${CT_ARCH_ENDIAN_OPT}"
diff --git a/scripts/crosstool-NG.sh.in b/scripts/crosstool-NG.sh.in
--- a/scripts/crosstool-NG.sh.in
+++ b/scripts/crosstool-NG.sh.in
@@ -153,6 +153,9 @@
 CT_CC_CORE_EXTRA_CONFIG_ARRAY=( ${CT_ARCH_CC_CORE_EXTRA_CONFIG} "${CT_CC_CORE_EXTRA_CONFIG_ARRAY[@]}" )
 CT_CC_EXTRA_CONFIG_ARRAY=( ${CT_ARCH_CC_EXTRA_CONFIG} "${CT_CC_EXTRA_CONFIG_ARRAY[@]}" )
 
+# Compute the package version string
+CT_PKGVERSION="crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}"
+
 # Compute the working directories names
 CT_TARBALLS_DIR="${CT_WORK_DIR}/tarballs"
 CT_SRC_DIR="${CT_WORK_DIR}/src"

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-01 20:36 ` [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION Benoît THÉBAUDEAU
  2011-06-01 21:16   ` Yann E. MORIN
@ 2011-06-03 21:44   ` Arnaud Lacombe
  2011-06-03 21:52     ` Benoît THÉBAUDEAU
  2011-06-03 22:01     ` Yann E. MORIN
  1 sibling, 2 replies; 23+ messages in thread
From: Arnaud Lacombe @ 2011-06-03 21:44 UTC (permalink / raw)
  To: Benoît THÉBAUDEAU; +Cc: Yann E. MORIN, crossgcc

Hi Benoit,

2011/6/1 Benoît THÉBAUDEAU <benoit.thebaudeau@advansee.com>:
> # HG changeset patch
> # User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
> # Date 1306960344 -7200
> # Node ID b96b4403c850000dfe69b7d64bc4d65542007290
> # Parent  9e3cbe13deae566d9ec0c31f38afe238f7c9660d
> kconfig: prepend CT-NG's version tag to PKGVERSION
>
could you please avoid to prefix your patches with `kconfig' when they
truly applied to the `config'. Each time I see a patch prefixed with
`kconfig', I think there is something wrong with the tools, which
picks up my attention as per the not-fully standard way crosstool-ng
uses it.

Thanks in advance,
 - Arnaud

> "crosstool-NG-${CT_VERSION}" is currently the default for TOOLCHAIN_PKGVERSION,
> and this options is passed as is to --with-pkgversion.
>
> This patch prepends "crosstool-NG ${CT_VERSION}" to TOOLCHAIN_PKGVERSION before
> passing it to --with-pkgversion.
>
> Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
>
> diff --git a/config/toolchain.in b/config/toolchain.in
> --- a/config/toolchain.in
> +++ b/config/toolchain.in
> @@ -69,13 +69,18 @@
>  config TOOLCHAIN_PKGVERSION
>     string
>     prompt "Toolchain ID string"
> -    default "crosstool-NG-${CT_VERSION}"
> +    default ""
>     help
>       Specify a string that identifies your package. You may wish to include
>       a build number or build date. This version string will be included in
>       the output of gcc --version, and also in binutils, eglibc, gdb and
>       gdbserver.
>
> +      If this string is left empty, the actual package version will be:
> +          "crosstool-NG ${CT_VERSION}"
> +      Otherwise, it will be:
> +          "crosstool-NG ${CT_VERSION} - ${CT_TOOLCHAIN_PKGVERSION}"
> +
>       This is passed to the configure flag --with-pkgversion.
>
>  config TOOLCHAIN_BUGURL
> diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh
> --- a/scripts/build/binutils/binutils.sh
> +++ b/scripts/build/binutils/binutils.sh
> @@ -56,8 +56,8 @@
>         extra_config+=( --enable-plugins )
>     fi
>     if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
> -        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>     fi
>
>     CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
> @@ -147,8 +147,8 @@
>         CT_DoLog EXTRA "Configuring binutils for target"
>
>         if [ "${CT_BINUTILS_HAS_PKGVERSION_BUGURL}" = "y" ]; then
> -            [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -            [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +            extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +            [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>         fi
>
>         CT_DoExecLog CFG                                            \
> diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
> --- a/scripts/build/cc/gcc.sh
> +++ b/scripts/build/cc/gcc.sh
> @@ -161,8 +161,8 @@
>
>     if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
>         # Bare metal delivers the core compiler as final compiler, so add version info and bugurl
> -        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>     fi
>
>     if [ "${copy_headers}" = "y" ]; then
> @@ -405,8 +405,8 @@
>
>     [ "${CT_SHARED_LIBS}" = "y" ] || extra_config+=("--disable-shared")
>     if [ "${CT_CC_GCC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
> -        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>     fi
>     case "${CT_CC_GCC_SJLJ_EXCEPTIONS}" in
>         y)  extra_config+=("--enable-sjlj-exceptions");;
> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gdb.sh
> --- a/scripts/build/debug/300-gdb.sh
> +++ b/scripts/build/debug/300-gdb.sh
> @@ -99,8 +99,8 @@
>     esac
>
>     if [ "${CT_GDB_HAS_PKGVERSION_BUGURL}" = "y" ]; then
> -        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>     fi
>
>     if [ "${CT_GDB_CROSS}" = "y" ]; then
> diff --git a/scripts/build/libc/glibc-eglibc.sh-common b/scripts/build/libc/glibc-eglibc.sh-common
> --- a/scripts/build/libc/glibc-eglibc.sh-common
> +++ b/scripts/build/libc/glibc-eglibc.sh-common
> @@ -235,8 +235,8 @@
>     esac
>
>     if [ "${CT_LIBC_EGLIBC_HAS_PKGVERSION_BUGURL}" = "y" ]; then
> -        [ -n "${CT_TOOLCHAIN_PKGVERSION}" ] && extra_config+=("--with-pkgversion=${CT_TOOLCHAIN_PKGVERSION}")
> -        [ -n "${CT_TOOLCHAIN_BUGURL}" ]     && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
> +        extra_config+=("--with-pkgversion=crosstool-NG ${CT_VERSION}${CT_TOOLCHAIN_PKGVERSION:+ - ${CT_TOOLCHAIN_PKGVERSION}}")
> +        [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}")
>     fi
>
>     extra_cc_args="${extra_cc_args} ${CT_ARCH_ENDIAN_OPT}"
>

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-03 16:38         ` [PATCH] " Benoît THÉBAUDEAU
@ 2011-06-03 21:47           ` Yann E. MORIN
  2011-06-04 13:36           ` Yann E. MORIN
  1 sibling, 0 replies; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-03 21:47 UTC (permalink / raw)
  To: crossgcc; +Cc: Benoît THÉBAUDEAU

Benoit, All,

On Friday 03 June 2011 18:37:35 Benoît THÉBAUDEAU wrote:
> # HG changeset patch
> # User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
> # Date 1307114516 -7200
> # Node ID b5541f296b921fe7e00748576e85ee1cf1de48a3
> # Parent  02b7285c078f27acbe56d5df86e373d7e420c265
> kconfig: prepend CT-NG's version tag to PKGVERSION

Queued here! Thank you!

Regards,
Yann E. MORIN.


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 1 of 8] kconfig: remove useless 'default n'
  2011-06-01 20:37 ` [PATCH 1 of 8] kconfig: remove useless 'default n' Benoît THÉBAUDEAU
@ 2011-06-03 21:49   ` Arnaud Lacombe
  2011-06-03 21:54     ` Benoît THÉBAUDEAU
  0 siblings, 1 reply; 23+ messages in thread
From: Arnaud Lacombe @ 2011-06-03 21:49 UTC (permalink / raw)
  To: Benoît THÉBAUDEAU; +Cc: Yann E. MORIN, crossgcc

Hi,

2011/6/1 Benoît THÉBAUDEAU <benoit.thebaudeau@advansee.com>:
> # HG changeset patch
> # User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
> # Date 1306852059 -7200
> # Node ID d124516c60a2f0559020400a8dfd1dbf339359a5
> # Parent  fa3a18f9abcf9dde1535088554778fe4c4e5e831
> kconfig: remove useless 'default n'
>
> kconfig bools are disabled by default, so specifying 'default n' is useless and
> noisy. This patch removes all occurrences of 'default n'.
>
> Signed-off-by: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
>
> diff --git a/config/arch/arm.in.2 b/config/arch/arm.in.2
> --- a/config/arch/arm.in.2
> +++ b/config/arch/arm.in.2
> @@ -28,11 +28,10 @@
>  config ARCH_ARM_INTERWORKING
>     bool
>     prompt "Use Thumb-interworking (READ HELP)"
> -    default n
>     depends on EXPERIMENTAL
>     help
>       Excerpt from the gcc manual:
> -
> +
obviously, you're patch do more than just removing occurrences of
`default n', as this white-space change (and many other I skipped)
points out.

 - Arnaud

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-03 21:44   ` [PATCH 8 of 8] " Arnaud Lacombe
@ 2011-06-03 21:52     ` Benoît THÉBAUDEAU
  2011-06-03 22:01     ` Yann E. MORIN
  1 sibling, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-03 21:52 UTC (permalink / raw)
  To: Arnaud Lacombe; +Cc: Yann E. MORIN, crossgcc

Hi Arnaud,

> > # HG changeset patch
> > # User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
> > # Date 1306960344 -7200
> > # Node ID b96b4403c850000dfe69b7d64bc4d65542007290
> > # Parent  9e3cbe13deae566d9ec0c31f38afe238f7c9660d
> > kconfig: prepend CT-NG's version tag to PKGVERSION
> >
> could you please avoid to prefix your patches with `kconfig' when
> they
> truly applied to the `config'. Each time I see a patch prefixed with
> `kconfig', I think there is something wrong with the tools, which
> picks up my attention as per the not-fully standard way crosstool-ng
> uses it.
>
> Thanks in advance,
>  - Arnaud

OK. I'll be careful about that in the future.

Regards,
Benoît

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 1 of 8] kconfig: remove useless 'default n'
  2011-06-03 21:49   ` Arnaud Lacombe
@ 2011-06-03 21:54     ` Benoît THÉBAUDEAU
  0 siblings, 0 replies; 23+ messages in thread
From: Benoît THÉBAUDEAU @ 2011-06-03 21:54 UTC (permalink / raw)
  To: Arnaud Lacombe; +Cc: Yann E. MORIN, crossgcc

Arnaud,

> obviously, you're patch do more than just removing occurrences of
> `default n', as this white-space change (and many other I skipped)
> points out.

Indeed. I removed some useless trailing spaces by the way, but I did
not find it worth mentioning.

Regards,
Benoît

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-03 21:44   ` [PATCH 8 of 8] " Arnaud Lacombe
  2011-06-03 21:52     ` Benoît THÉBAUDEAU
@ 2011-06-03 22:01     ` Yann E. MORIN
  1 sibling, 0 replies; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-03 22:01 UTC (permalink / raw)
  To: crossgcc; +Cc: Arnaud Lacombe, Benoît THÉBAUDEAU

Arnaud, Benoit, All,

On Friday 03 June 2011 23:44:37 Arnaud Lacombe wrote:
> 2011/6/1 Benoît THÉBAUDEAU <benoit.thebaudeau@advansee.com>:
> > kconfig: prepend CT-NG's version tag to PKGVERSION
> could you please avoid to prefix your patches with `kconfig' when they
> truly applied to the `config'. Each time I see a patch prefixed with
> `kconfig', I think there is something wrong with the tools, which
> picks up my attention as per the not-fully standard way crosstool-ng
> uses it.

Yes, indeed. Arnaud is quite helpful regarding helping fix/enhance
kconfig [0] so we can use it easily in crosstool-NG (most probably,
other projects will benefit those changes as well, such as buildroot).

Unfortunately, there is no clear prefixing scheme for the commit logs.
What I (try to) do is:
  category/component: subject

where 'category' is one of cc, libc, kernel, arch, and so on, and
'component' is one of gcc, glibc, uClibc, linux, arm and so on. For
example, something that relates to gcc (config and/or build script)
will be prefixed with:
  cc/gcc: add config option to foo the bar, pass to ./configure

Of course, that is not as easy with the rest of the code. For example,
there is the kconfig stuff, which gets prefixed with 'kconfig', and
the rest of the scripts, for example:
  scripts/functions: add generic buz wrapper

Plus a few other exceptions to the rule (it needs exceptions, or it would
not be a rule!). But this is not a definitive rule, this is just my prefered
scheme. I'll add it to the docs. Thanks for bringing up the subject.

And thanks again for your help on kconfig! :-)

Regards,
Yann E. MORIN.

[0] For those wondering why there has been no mail about this on this very
list, the kconfig discussions happen on the linux-kbuild ML, as it is
most appropriate to discuss the issues there.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH] kconfig: prepend CT-NG's version tag to PKGVERSION
  2011-06-03 16:38         ` [PATCH] " Benoît THÉBAUDEAU
  2011-06-03 21:47           ` Yann E. MORIN
@ 2011-06-04 13:36           ` Yann E. MORIN
  1 sibling, 0 replies; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-04 13:36 UTC (permalink / raw)
  To: crossgcc; +Cc: Benoît THÉBAUDEAU

Benoit, All,

On Friday 03 June 2011 18:37:35 Benoît THÉBAUDEAU wrote:
> # HG changeset patch
> # User "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>
> # Date 1307114516 -7200
> # Node ID b5541f296b921fe7e00748576e85ee1cf1de48a3
> # Parent  02b7285c078f27acbe56d5df86e373d7e420c265
> kconfig: prepend CT-NG's version tag to PKGVERSION

Applied as #b5541f296b92. Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools
  2011-06-01 21:18 ` [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Yann E. MORIN
  2011-06-01 21:35   ` Benoît THÉBAUDEAU
@ 2011-06-04 14:19   ` Yann E. MORIN
  1 sibling, 0 replies; 23+ messages in thread
From: Yann E. MORIN @ 2011-06-04 14:19 UTC (permalink / raw)
  To: crossgcc; +Cc: Benoît THÉBAUDEAU

Benoit, All,

On Wednesday 01 June 2011 23:18:02 Yann E. MORIN wrote:
> On Wednesday 01 June 2011 22:35:52 Benoît THÉBAUDEAU wrote:
> > This is a new revision of my previous patch series about the same subject,
> > taking your comments into account.
> Applying patches 1..7.

I forgot to say, but patches 1..7 were and pushed. Too many changeset #s,
I won't list them. Thanks again!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2011-06-04 14:19 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-01 20:36 [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Benoît THÉBAUDEAU
2011-06-01 20:36 ` [PATCH 4 of 8] gcc: promote PKGVERSION and BUGURL options to toolchain level Benoît THÉBAUDEAU
2011-06-01 20:36 ` [PATCH 8 of 8] kconfig: prepend CT-NG's version tag to PKGVERSION Benoît THÉBAUDEAU
2011-06-01 21:16   ` Yann E. MORIN
2011-06-01 21:41     ` Benoît THÉBAUDEAU
2011-06-01 21:48       ` Yann E. MORIN
2011-06-03 16:38         ` [PATCH] " Benoît THÉBAUDEAU
2011-06-03 21:47           ` Yann E. MORIN
2011-06-04 13:36           ` Yann E. MORIN
2011-06-03 21:44   ` [PATCH 8 of 8] " Arnaud Lacombe
2011-06-03 21:52     ` Benoît THÉBAUDEAU
2011-06-03 22:01     ` Yann E. MORIN
2011-06-01 20:36 ` [PATCH 7 of 8] gdb: use the PKGVERSION and BUGURL options Benoît THÉBAUDEAU
2011-06-01 20:36 ` [PATCH 3 of 8] gcc: add a CC_GCC_HAS_PKGVERSION_BUGURL option Benoît THÉBAUDEAU
2011-06-01 20:36 ` [PATCH 2 of 8] scripts/addToolVersion.sh: add a function to extract fields from versions Benoît THÉBAUDEAU
2011-06-01 20:37 ` [PATCH 1 of 8] kconfig: remove useless 'default n' Benoît THÉBAUDEAU
2011-06-03 21:49   ` Arnaud Lacombe
2011-06-03 21:54     ` Benoît THÉBAUDEAU
2011-06-01 20:45 ` [PATCH 5 of 8] binutils: use the PKGVERSION and BUGURL options Benoît THÉBAUDEAU
2011-06-01 20:45 ` [PATCH 6 of 8] eglibc: " Benoît THÉBAUDEAU
2011-06-01 21:18 ` [PATCH 0 of 8] Apply PKGVERSION and BUGURL options to all applicable tools Yann E. MORIN
2011-06-01 21:35   ` Benoît THÉBAUDEAU
2011-06-04 14:19   ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).