Re: [PATCH 2 of 2] companion_tools/autoconf: add autoconf tool

["Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>]

Richard, All,

On Monday 11 January 2010 21:20:03 Richard Strand wrote:
> Yann E. MORIN wrote:
> > OK, now what about this help text and prompt:
> >
> > comment "READ HELP before you say 'Y' below !!!"
> > prompt "Build some companion tools"
> > help
> >   Crosstool-NG relies on some external tools to be recent enough, namely:
> >     autoconf >= 2.65
> >     blah     >= blah

Of course, only autoconf should appear initially (see below); then as you
send patches adding the next tools, update the list accordingly.

> >   If your system has older versions, we can build them for you,
> >   but you are strongly encouraged to update your system instead!
> Do you know the minimum versions of the tools required or are the
> versions in the TODO correct? Should I be building the minimum versions,
> or is it ok just to build the latest ones?

The versions in the TODO are the strictly required versions, and have been
validated (sort of). So stick with those versions.

> No problem! It seems fairly simple to add the other 3 tools into this
> patch as well, or would you rather they were all separate patches?
> When I submit further versions of this patch should I also include the
> "Change overide bin dir" patch

First patch with the bin-override.
Second patch with the infrastuture and autoconf (as you did so far).
Then one patch for each other tool.

> (is it even possible to exclude it with 
> mercurial)?

Yes. If you are using mqueue, then you can "guard" patches. I have never
played with that, however.

If you're not using mqueue, then you could use email -r rev1:rev2 to send
all changesets from revision rev1 to revision rev2 (both inclusive), which
you can also do with mqueu, btw).

But please send all patches, so we have a correct sequence to apply.

> I don't like spamming the list with duplicate patches, but 
> this patch doesn't work without the "Change overide bin dir" patch.

Don't worry, the round-trips needed to review patches are not regarded as
spamming! :-) If we did in fact have, say, 10 or more in a 1-hour time,
then it could have been. But we'd have gone private long before that! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
`------------------------------^-------^------------------^--------------------'



--
For unsubscribe information see http://sourceware.org/lists.html#faq