From: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
To: crossgcc@sourceware.org
Cc: "Benoît THÉBAUDEAU" <benoit.thebaudeau@advansee.com>,
"Bryan Hundven" <bryanhundven@gmail.com>
Subject: Re: [PATCH 1 of 2] cross-gdb: add XML support
Date: Fri, 03 Jun 2011 22:19:00 -0000 [thread overview]
Message-ID: <201106040019.22405.yann.morin.1998@anciens.enib.fr> (raw)
In-Reply-To: <61d3b19c-293d-4352-a1dd-6970165eaf36@mx-12>
Benoit, Bryan, All,
On Friday 03 June 2011 23:45:53 Benoît THÉBAUDEAU wrote:
> > 2) Add a *_prepare function to the API, that gets call at the very
> > beginning
> > of the build, and does the necessary checks. Eg.:
> > do_debug_gdb_prepare() {
> > if [ ! "${libexpat_available}" ]; then
> > Aaargh
> > fi
> > }
> > Do it everywhere.
No, the above is crap ( I can say, I wrote it! :-) ). Since I wrote that,
we now have ./configure that can pass options down to kconfig. Let's
use that.
> > Also, have ./configure do the has_or_warn (as per Bryan's
> > suggestion).
> > This is pretty nice, and lightweight. Rather easy to implement, I
> > think.
>
> The has_or_warn part() of my new patch is ready. Do you prefer the
> do_debug_gdb_prepare() that you proposed above, or rather something
> like the following?
>
> ---
> comment "Cross-gdb - disabled (requires expat)"
> depends on !CONFIGURE_has_expat
Although a comment is a very nice thing to have, I am wondering if it
won't come poluting the code. When I first read it, I was all:
Oh, a comment. Very nice!
And then, thinking again, I'm all:
Wait... Will we have to add such a comment for all features
conditional on ./configure ? Can we do it in a generic way ?
And then, how do we tell the user to re-run ./configure again so that
the feat is available? Comments can not have help entries (I just
tested). Seems I'll be hanging on the linux-kbuild list a litle
while longer! ;-)
Let's keep the comment for now. If the ./configure warning is explicit
enough, we can live with that.
> cconfig GDB_CROSS
> bool
> prompt "Cross-gdb"
> default y
> depends on CONFIGURE_has_expat
> select GDB_GDBSERVER if ! BARE_METAL
> help
> Build and install a cross-gdb for the target, to run on host.
> ---
>
> I don't see the point of allowing the user to choose a configuration
> that will fail as soon as the build starts.
Yes, please go ahead as above, comment included.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
next prev parent reply other threads:[~2011-06-03 22:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cd5b634e-0006-4136-b428-694f5a5968df@mx-12>
2011-05-21 13:33 ` [CT-NG 1.11.3] Cross-gdb XML support missing Benoît THÉBAUDEAU
2011-05-24 11:22 ` [PATCH 0 of 2] cross-gdb: fix runtime warnings Benoît THÉBAUDEAU
2011-05-24 11:22 ` [PATCH 1 of 2] cross-gdb: add XML support Benoît THÉBAUDEAU
2011-05-25 17:25 ` Yann E. MORIN
2011-05-25 18:01 ` Benoît THÉBAUDEAU
2011-05-25 18:23 ` Yann E. MORIN
2011-05-25 18:39 ` Bryan Hundven
2011-05-25 18:57 ` Benoît THÉBAUDEAU
2011-05-25 18:54 ` Benoît THÉBAUDEAU
2011-05-25 20:19 ` Yann E. MORIN
2011-05-25 20:26 ` Bryan Hundven
2011-05-26 16:27 ` Yann E. MORIN
2011-05-27 7:04 ` Bryan Hundven
2011-06-03 21:46 ` Benoît THÉBAUDEAU
2011-06-03 22:19 ` Yann E. MORIN [this message]
2011-06-06 14:50 ` [PATCH] debug/cross-gdb: check host dependencies Benoît THÉBAUDEAU
2011-06-07 22:36 ` Yann E. MORIN
2011-06-07 22:47 ` Yann E. MORIN
2011-06-08 12:56 ` Benoît THÉBAUDEAU
2011-06-08 14:08 ` [PATCH 0 of 2] " Benoît THÉBAUDEAU
2011-06-08 14:08 ` [PATCH 2 " Benoît THÉBAUDEAU
2011-06-08 18:05 ` Yann E. MORIN
2011-06-08 14:08 ` [PATCH 1 of 2] configure: give check_for() the ability to test several item types at once Benoît THÉBAUDEAU
2011-06-08 18:02 ` Yann E. MORIN
2011-05-24 11:22 ` [PATCH 2 of 2] cross-gdb: fix runtime sysroot Benoît THÉBAUDEAU
2011-05-25 17:29 ` Yann E. MORIN
2011-05-25 18:22 ` Benoît THÉBAUDEAU
2011-05-25 18:26 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201106040019.22405.yann.morin.1998@anciens.enib.fr \
--to=yann.morin.1998@anciens.enib.fr \
--cc=benoit.thebaudeau@advansee.com \
--cc=bryanhundven@gmail.com \
--cc=crossgcc@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).