From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24724 invoked by alias); 19 Sep 2011 15:40:39 -0000 Received: (qmail 24465 invoked by uid 22791); 19 Sep 2011 15:40:35 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Sep 2011 15:40:17 +0000 Received: by fxh17 with SMTP id 17so4617535fxh.0 for ; Mon, 19 Sep 2011 08:40:16 -0700 (PDT) Received: by 10.223.45.209 with SMTP id g17mr5359046faf.96.1316446816167; Mon, 19 Sep 2011 08:40:16 -0700 (PDT) Received: from swarm.cs.pub.ro ([141.85.227.118]) by mx.google.com with ESMTPS id m26sm15652690fac.6.2011.09.19.08.40.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 19 Sep 2011 08:40:14 -0700 (PDT) Date: Mon, 19 Sep 2011 15:40:00 -0000 From: Mircea Gherzan To: "Yann E. MORIN" Cc: crossgcc@sourceware.org Subject: Re: [PATCH] gcc: add support for the PowerPC EABI Message-ID: <20110919154008.GA23438@swarm.cs.pub.ro> References: <201109161427.36090.yann.morin.1998@anciens.enib.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201109161427.36090.yann.morin.1998@anciens.enib.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-09/txt/msg00020.txt.bz2 Hi Yann, On Fri, Sep 16, 2011 at 02:27:35PM +0200, Yann E. MORIN wrote: > Mircea, All, > > On Friday 16 September 2011 02:19:02 Mircea Gherzan wrote: > > # HG changeset patch > > # User Mircea Gherzan > > # Date 1316132293 -7200 > > # Node ID ddb7a1b016c824a0ddaf97768d37c1a1fb287156 > > # Parent eda6ef5a2532607ab7060814eb8b786bd361ab11 > > gcc: add support for the PowerPC EABI > > You have to add a SoB line: > http://crosstool-ng.org/hg/crosstool-ng/file/tip/docs/7%20-%20Contributing%20to%20crosstool-NG.txt#l24 > > > diff -r eda6ef5a2532 -r ddb7a1b016c8 config/arch/powerpc.in.2 > > --- a/config/arch/powerpc.in.2 Mon Sep 12 12:54:45 2011 +0200 > > +++ b/config/arch/powerpc.in.2 Fri Sep 16 02:18:13 2011 +0200 > > @@ -1,8 +1,31 @@ > > # powerpc specific configuration file > > > > -config ARCH_POWERPC_SPE > > +config ARCH_POWERPC_ABI > > Yes, _POWERPC_ is a legacy naming scheme, back when the menus in the > menuconfig were not autogenerated. Nowadays, the naming scheme is to > use the architecture name in lowercase, the same as the file is named > (eg. 'powerpc' here). > > It would be really great if you could also do the rename at the same > time. > > > + string > > + default "" if ARCH_POWERPC_ABI_DEFAULT > > + default "eabi" if ARCH_POWERPC_ABI_EABI > > + default "spe" if ARCH_POWERPC_ABI_SPE > > + > > +choice > > bool > > - prompt "Enable SPE support" > > + prompt "ABI" > > + default ARCH_POWERPC_ABI_DEFAULT > > + > > +config ARCH_POWERPC_ABI_DEFAULT > > + bool > > + prompt "default" > > + help > > + The default ABI (System V.4). > > + > > +config ARCH_POWERPC_ABI_EABI > > + bool > > + prompt "EABI" > > + help > > + The Embedded ABI (stack alignment of 8 bytes, etc). > > This should depend on BARE_METAL. > > > +config ARCH_POWERPC_ABI_SPE > > + bool > > + prompt "SPE" > > help > > Add support for the Signal Processing Engine. This will set up > > the toolchain so that it supports the SPE ABI extensions. This > > @@ -14,3 +37,6 @@ > > will also automatically add "-mabi=spe -mspe" to your TARGET_CFLAGS, > > and "--enable-e500_double" to your CC_EXTRA_CONFIG_ARRAY, so you > > do not need to explicitly add them. > > + > > +endchoice > > + > > diff -r eda6ef5a2532 -r ddb7a1b016c8 scripts/build/arch/powerpc.sh > > --- a/scripts/build/arch/powerpc.sh Mon Sep 12 12:54:45 2011 +0200 > > +++ b/scripts/build/arch/powerpc.sh Fri Sep 16 02:18:13 2011 +0200 > > @@ -6,14 +6,23 @@ > > CT_TARGET_ARCH="powerpc64" > > fi > > > > - # Add spe in the tuple if needed > > - case "${CT_LIBC},${CT_ARCH_POWERPC_SPE}" in > > - glibc,|eglibc,) CT_TARGET_SYS=gnu;; > > - glibc,y|eglibc,y) CT_TARGET_SYS=gnuspe;; > > + CT_TARGET_SYS="gnu" > > + case "${CT_ARCH_POWERPC_ABI}" in > > + "") ;; > > + eabi) > > + CT_TARGET_SYS="eabi";; > > + spe) > > + case "${CT_LIBC}" in > > + glibc|eglibc) > > + CT_TARGET_SYS="gnuspe";; > > + *) > > + CT_TARGET_SYS="spe";; > > + > > + esac;; > > esac > > The coding style for all other case..esac is either: > - all on a single line: > pattern) code;; > - one line for pattern, then lines for code, then ';;' on its own line: > pattern) > code > ;; Thank you for your feedback. All the issues have been addressed in v3 of the patch. Could you please apply it and release a new version (1.12.3)? Thanks, Mircea -- For unsubscribe information see http://sourceware.org/lists.html#faq