From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26828 invoked by alias); 5 Oct 2011 21:35:16 -0000 Received: (qmail 26732 invoked by uid 22791); 5 Oct 2011 21:35:13 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp10.smtpout.orange.fr (HELO smtp.smtpout.orange.fr) (80.12.242.132) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Oct 2011 21:34:55 +0000 Received: from treguer.localnet ([90.32.247.43]) by mwinf5d33 with ME id h9as1h0050wutKN039asb9; Wed, 05 Oct 2011 23:34:53 +0200 X-ME-engine: default From: "Yann E. MORIN" To: crossgcc@sourceware.org Subject: Re: [PATCH] Support extra host compiler flags Date: Wed, 05 Oct 2011 21:35:00 -0000 User-Agent: KMail/1.13.5 (Linux/3.0.4-treguer; KDE/4.4.5; x86_64; ; ) Cc: Michael Hope References: <415f1de11ddcc321d5e6.1317777658@crucis> In-Reply-To: <415f1de11ddcc321d5e6.1317777658@crucis> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110052334.51905.yann.morin.1998@anciens.enib.fr> Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00005.txt.bz2 Michael, All, On Wednesday 05 October 2011 03:20:58 Michael Hope wrote: > # HG changeset patch > # User Michael Hope > # Date 1317777591 -46800 > # Node ID 415f1de11ddcc321d5e6cf2f7cd058973045507f > # Parent f051032a1070eda28557dd738c35446b44787217 > Support extra host compiler flags. This is typically a case where "category/component" does not apply... :-/ Usually, I use something like: scripts: suport extra host compiler flags > Allow the user to configure extra flags to pass to the host compiler > at build time. Applies to both C and C++. > > Useful on Ubuntu to turn off the stack protector and fortify defaults > so the program stands a better chance of running on other distros. > > Signed-off-by: Michael Hope > > diff -r f051032a1070 -r 415f1de11ddc config/global/build-behave.in > --- a/config/global/build-behave.in Wed Oct 05 14:15:45 2011 +1300 > +++ b/config/global/build-behave.in Wed Oct 05 14:19:51 2011 +1300 > @@ -41,6 +41,16 @@ > Use gcc's option -pipe to use pipes rather than temp files when building > the toolchain. > > +config EXTRA_FLAGS_FOR_HOST > + string > + prompt "Extra host compiler flags" > + default "" > + help > + Extra flags to pass to the host C and C++ compiler. > + > + May be used to change the default features of the host > + compiler such as turning off the stack protector or fortify. (see below) Add: Those flags are passed after all the internally-computed flags, so will override them. > + > choice > bool > prompt "Shell to use as CONFIG_SHELL" > diff -r f051032a1070 -r 415f1de11ddc scripts/crosstool-NG.sh.in > --- a/scripts/crosstool-NG.sh.in Wed Oct 05 14:15:45 2011 +1300 > +++ b/scripts/crosstool-NG.sh.in Wed Oct 05 14:19:51 2011 +1300 > @@ -479,7 +479,7 @@ > esac > > # Help gcc > - CT_CFLAGS_FOR_HOST= > + CT_CFLAGS_FOR_HOST="${CT_EXTRA_FLAGS_FOR_HOST}" > [ "${CT_USE_PIPES}" = "y" ] && CT_CFLAGS_FOR_HOST="${CT_CFLAGS_FOR_HOST} -pipe" I'd rather like that the user-specified flags are passed last, so they have a chance to override the automatically-computed flags. Otherwise, good. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq