Re: [PATCH] scripts: Make the crosstool-NG version an optional part of pkgversion

["Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>]

Michael, All,

On Monday 17 October 2011 05:39:47 Michael Hope wrote:
> # HG changeset patch
> # User Michael Hope <michael.hope@linaro.org>
> # Date 1317709748 -46800
> # Node ID 931a96c7b84610c33a5535f574adf01df63d1a89
> # Parent  5b157f46a3ab4830e4117811e9338e7d74d3a55d
> scripts: Make the crosstool-NG version an optional part of pkgversion.

If I may ask, what is the reason you (Linaro) would not want to identify
crosstool-NG in the pkgversion string?

Would it be better if the crosstool-NG ID string was placed _after_ the
custom string?

> We use the pkgversion for the Linaro release name.  This patch lets you
> turn off the automatic crosstool-NG@revno and just use the configured
> package version.

Note that, for release, the 'revno' is replaced by the version string,
so it is much shorter; that is, something like:
    crosstool-NG 1.12.4

> +config TOOLCHAIN_PKGVERSION_WITH_CROSSTOOL
> +    bool
> +    prompt "Include the crosstool-NG version in the ID string"
> +    default y
> +    help
> +      Include the crosstool-NG version in the package version string.

If this was to make it in, I would add:
    depends on TOOLCHAIN_PKGVERSION != ""

So there's at least one pkgversion string:
 - the crosstool-NG ID string
 - the crosstool-NG + the custom ID strings
 - the custom ID string

OK for you?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq