From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31676 invoked by alias); 14 Nov 2011 21:17:51 -0000 Received: (qmail 31654 invoked by uid 22791); 14 Nov 2011 21:17:50 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp02.smtpout.orange.fr (HELO smtp.smtpout.orange.fr) (80.12.242.124) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Nov 2011 21:17:35 +0000 Received: from treguer.localnet ([90.32.27.63]) by mwinf5d25 with ME id x9HZ1h0051Mhb62039HZRM; Mon, 14 Nov 2011 22:17:34 +0100 From: "Yann E. MORIN" To: Michael Hope Subject: Re: [PATCH] configure: support arbitrary versions via a shell script Date: Mon, 14 Nov 2011 21:17:00 -0000 User-Agent: KMail/1.13.5 (Linux/3.1.0-treguer; KDE/4.4.5; x86_64; ; ) Cc: crossgcc@sourceware.org References: <02572d8009f6a872ccd2.1321225822@crucis> <201111140820.57656.yann.morin.1998@anciens.enib.fr> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201111142217.33054.yann.morin.1998@anciens.enib.fr> Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00051.txt.bz2 Michael, All, On Monday 14 November 2011 21:37:15 Michael Hope wrote: > That sounds good. There's a minor bug in your version: ./configure > --help uses the version from .version instead of version.sh as > do_help() is called before version.sh is updated. > > Then again, it had a similar problem before the patch: ./configure > --help would report crosstool-NG-hg instead of the full > crosstool-NG-hg-revno-foo. Indeed, the /issue/ was there previously as well. So, it is not a regression! ;-) > Let me know if it's important and I can make a patch, I understand it could be confusing. - the easy way is to remove the version string from the help entry; - the proper way would be to move the version computation upward, but it needs ${sed} that is available only after the tests, which do not get run for --help. So, we could just move the version calculations upward, print the pristine version string in --help, and just mangle the string at the moment we need it and can do it. If the sight of the incorrect version string is absolutely untenable for you, if your screen turns itself off so you don't get to see it, if you lose your sanity at the mere thought of seeing the raw version, then by all means, send a patch! ;-) Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq