From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21141 invoked by alias); 22 Nov 2011 17:24:13 -0000 Received: (qmail 21130 invoked by uid 22791); 22 Nov 2011 17:24:11 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp04.smtpout.orange.fr (HELO smtp.smtpout.orange.fr) (80.12.242.126) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 17:23:58 +0000 Received: from treguer.localnet ([90.32.33.236]) by mwinf5d39 with ME id 0HPw1i00b55gilm03HPweh; Tue, 22 Nov 2011 18:23:56 +0100 From: "Yann E. MORIN" To: crossgcc@sourceware.org Subject: Re: [nls PATCH 2 of 3] binutils/binutils: Handle --disable-nls config Date: Tue, 22 Nov 2011 17:24:00 -0000 User-Agent: KMail/1.13.5 (Linux/3.1.1-treguer; KDE/4.4.5; x86_64; ; ) Cc: Zhenqiang Chen References: <4ECB8D46.1040002@linaro.org> In-Reply-To: <4ECB8D46.1040002@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201111221823.56129.yann.morin.1998@anciens.enib.fr> Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00130.txt.bz2 Zhenqiang, All, On Tuesday 22 November 2011 12:53:42 Zhenqiang Chen wrote: > # HG changeset patch > # User Zhenqiang Chen > # Date 1321523984 -28800 > # Node ID 640bdfd7d1efc1b91ad54304fefe6db77179ec65 > # Parent 986e1c75432aad60ae3239767198c653c08c01af > binutils/binutils: Add --disable-nls config when > option "Enable nls" is not selected. > > Reviewed-by: Michael Hope > Signed-off-by: Zhenqiang Chen > > diff --git a/scripts/build/binutils/binutils.sh b/scripts/build/binutils/binutils.sh > --- a/scripts/build/binutils/binutils.sh > +++ b/scripts/build/binutils/binutils.sh > @@ -62,6 +62,8 @@ > [ -n "${CT_TOOLCHAIN_BUGURL}" ] && extra_config+=("--with-bugurl=${CT_TOOLCHAIN_BUGURL}") > fi > > + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls") Shoudn't we also force --enable-nls otherwise? if [ "${CT_TOOLCHAIN_ENABLE_NLS}" = "y" ]; then extra_config+=("--enable-nls") else extra_config+=("--disable-nls") fi Not sure what the default is (I guess enabled is, but better safe than sorry). Otherwise, good. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq