From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23732 invoked by alias); 22 Nov 2011 17:26:48 -0000 Received: (qmail 23444 invoked by uid 22791); 22 Nov 2011 17:26:46 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp04.smtpout.orange.fr (HELO smtp.smtpout.orange.fr) (80.12.242.126) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 17:26:33 +0000 Received: from treguer.localnet ([90.32.33.236]) by mwinf5d39 with ME id 0HSX1i00C55gilm03HSXFC; Tue, 22 Nov 2011 18:26:31 +0100 From: "Yann E. MORIN" To: crossgcc@sourceware.org Subject: Re: [nls PATCH 3 of 3] cc/gcc: Handle --disable-nls config Date: Tue, 22 Nov 2011 17:26:00 -0000 User-Agent: KMail/1.13.5 (Linux/3.1.1-treguer; KDE/4.4.5; x86_64; ; ) Cc: Zhenqiang Chen References: <4ECB8DEF.8000108@linaro.org> In-Reply-To: <4ECB8DEF.8000108@linaro.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201111221826.31158.yann.morin.1998@anciens.enib.fr> Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00131.txt.bz2 Zhenqiang, All, On Tuesday 22 November 2011 12:56:31 Zhenqiang Chen wrote: > # HG changeset patch > # User Zhenqiang Chen > # Date 1321524028 -28800 > # Node ID e53dbc5ca50291b5258e19d1738fdf34e3a460ad > # Parent 640bdfd7d1efc1b91ad54304fefe6db77179ec65 > cc/gcc: Add --disable-nls config when option "Enable nls" is not selected. > > Reviewed-by: Michael Hope > Signed-off-by: Zhenqiang Chen > > diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh > --- a/scripts/build/cc/gcc.sh > +++ b/scripts/build/cc/gcc.sh > @@ -289,6 +289,8 @@ > extra_config+=(--disable-libgomp) > extra_config+=(--disable-libmudflap) > > + [ "${CT_TOOLCHAIN_ENABLE_NLS}" != "y" ] && extra_config+=("--disable-nls") Ditto the comment on the binutils patch. > - # --disable-nls to work around crash bug on ppc405, but also because > - # embedded systems don't really need message catalogs... I agrre that this comment is misleading, as the catalogs are not for the target, but fir the host; so the last part has to go, indeed. But what worries me is the PPC405 breakage. Is it no longer breaking? > CT_DoExecLog CFG \ > CC_FOR_BUILD="${CT_BUILD}-gcc" \ > CFLAGS="${CT_CFLAGS_FOR_HOST}" \ > @@ -617,7 +618,6 @@ > ${CC_SYSROOT_ARG} \ > "${extra_config[@]}" \ > --with-local-prefix="${CT_SYSROOT_DIR}" \ > - --disable-nls \ > --enable-c99 \ > --enable-long-long \ > "${CT_CC_EXTRA_CONFIG_ARRAY[@]}" Otherwise, good! Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq