From: Mike Frysinger <vapier@gentoo.org>
To: crossgcc@sourceware.org, jon.diekema@gmail.com
Subject: Re: eglibc-2_14 patch: Add protection on the __caddr_t typedef in usr/include/sys/types.h to avoid problems when caddr_t is defined.
Date: Sat, 31 Dec 2011 07:02:00 -0000 [thread overview]
Message-ID: <201112310202.44679.vapier@gentoo.org> (raw)
In-Reply-To: <4EF511E4.5010201@gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 713 bytes --]
On Friday 23 December 2011 18:42:28 Jon Diekema wrote:
> On 12/21/2011 05:27 PM, Mike Frysinger wrote:
> > On Wednesday 21 December 2011 14:54:38 Diekema, Jon wrote:
> >> When using ct-ng 1.13.0, the following patch for eglibc-2_14 was needed
> >> for a i686-pc-mingw32-i686-pc-linux-gnu build.
> >
> > your patch is horribly mangled. please send with `git send-email`.
> > -mike
>
> Sorry, let's try this again.
thanks, this one came across fine
now for the question: is this patch correct ? glibc protects itself against
redefinition with "__daddr_t_defined". if you have code that is (wrongly imo)
defining these core types, then you should also do "#define __daddr_t_defined".
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2011-12-31 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 19:55 Diekema, Jon (GE Aviation, US)
2011-12-21 22:27 ` Mike Frysinger
2011-12-23 23:42 ` Jon Diekema
2011-12-31 7:02 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112310202.44679.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=crossgcc@sourceware.org \
--cc=jon.diekema@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).