public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: crossgcc@sourceware.org
Cc: "Jérôme BARDON" <bardon.pro@gmail.com>
Subject: Re: [PATCH] to fix : crosstool-NG-1.18.0 - obsolete RPC headers are not installed for Glibc
Date: Fri, 15 Feb 2013 18:03:00 -0000	[thread overview]
Message-ID: <201302151903.29171.yann.morin.1998@free.fr> (raw)
In-Reply-To: <CAFKqv7w8HVnA2RRS7sGn4=iMnnw+HPEEpNq1_-JEko_TaMf4jw@mail.gmail.com>

Jérôme, All,

On Friday 15 February 2013 Jérôme BARDON wrote:
> Here is a patch to fix this :
> ================================================================
> # HG changeset patch
> # User Jerome BARDON <bardon.pro@gmail.com>
> # Date 1360923357 -3600
> # Node ID 367d677bfbeee5905310cbf0bf4636f76a786192
> # Parent  fb662f18d002da9303aba2ea933c5204b789e752
> also add RPC headers install for Glibc

The commit log should be a bit more explicit about what the changeset is
about (basically, what you added below the patch), and must include your
SoB-line (see: http://www.elinux.org/Developer_Certificate_Of_Origin ),
something like:

    libc/glibc: install obsolete RPC for both eglibc and glibc

    Currently, the obsolete RPC headers are only installed for eglibc,
    but glibc has the same /deficiency/, so install the obsolete RPC
    for both.

    Signed-off-by: Your Real Name <a.valid@email.address>

> diff -r fb662f18d002 -r 367d677bfbee scripts/build/libc/glibc-eglibc.sh-common
> --- a/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 10:46:40 2013 +0100
> +++ b/scripts/build/libc/glibc-eglibc.sh-common Fri Feb 15 11:15:57 2013 +0100
> @@ -222,7 +222,9 @@
>              OPTIMIZE=-O2
>              # Also, if those two are missing, iconv build breaks
>              extra_config+=( --disable-debug --disable-sanity-checks )
> -            ;;
> +            # always include rpc, the user can still override it with TI-RPC
> +            extra_config+=( --enable-obsolete-rpc )
> +             ;;
>      esac

Rather than duplicate the code in both the glibc and the eglibc path, just
move the existing "extra_config+=" line just belose the "esac".

Thank you! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

--
For unsubscribe information see http://sourceware.org/lists.html#faq

      reply	other threads:[~2013-02-15 18:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 14:43 Jérôme BARDON
2013-02-15 18:03 ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201302151903.29171.yann.morin.1998@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=bardon.pro@gmail.com \
    --cc=crossgcc@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).