public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
* [PATCH 1 of 1] component: libc/glibc, patch to fix build for PowerPC64
  2013-02-06 21:16 [PATCH 0 of 1] PowerPC64 target - fix for glibc build failure Frederic Roussel
@ 2013-02-06 21:16 ` Frederic Roussel
  2013-02-15 18:30   ` libc/glibc: add " Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Frederic Roussel @ 2013-02-06 21:16 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

# HG changeset patch
# User "Frederic Roussel" <fr.frasc@gmail.com>
# Date 1360185106 28800
# Node ID 7585f649ad60b23c4a31ef747322d0b171f948b5
# Parent  20f2459b97bf5eb89e2f125e0aede9541e7fc049
component: libc/glibc, patch to fix build for PowerPC64.

For a PowerPC64 build, avoid erroneous inline optimization of initfini.s

Signed-off-by: "Frederic R. ROUSSEL" <fr.frasc@gmail.com>

diff -r 20f2459b97bf -r 7585f649ad60 patches/glibc/2.13/950-initfini-ppc64.patch
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/glibc/2.13/950-initfini-ppc64.patch	Wed Feb 06 13:11:46 2013 -0800
@@ -0,0 +1,20 @@
+Prevent erroneous inline optimization of initfini.s on PowerPC64.
+
+The problem and the fix was reported there:
+http://sourceware.org/ml/libc-alpha/2012-01/msg00195.html
+Git commit:
+commit 1fe05ea95e1460e5e1cf1568a8ce3982f0f02de6
+Author: Ryan S. Arnold <rsa@us.ibm.com>
+Date: Tue May 3 17:26:17 2011 -0500
+
+--- glibc.orig/sysdeps/powerpc/powerpc64/Makefile	2012-12-22 19:10:06.713568781 -0800
++++ glibc/sysdeps/powerpc/powerpc64/Makefile	2012-12-22 19:10:50.318605517 -0800
+@@ -31,7 +31,7 @@
+ ifneq ($(elf),no)
+ # The initfini generation code doesn't work in the presence of -fPIC, so
+ # we use -fpic instead which is much better.
+-CFLAGS-initfini.s += -fpic -O1
++CFLAGS-initfini.s += -fpic -O1 -fno-inline
+ endif
+ endif
+ 
diff -r 20f2459b97bf -r 7585f649ad60 patches/glibc/2.14.1/950-initfini-ppc64.patch
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/glibc/2.14.1/950-initfini-ppc64.patch	Wed Feb 06 13:11:46 2013 -0800
@@ -0,0 +1,20 @@
+Prevent erroneous inline optimization of initfini.s on PowerPC64.
+
+The problem and the fix was reported there:
+http://sourceware.org/ml/libc-alpha/2012-01/msg00195.html
+Git commit:
+commit 1fe05ea95e1460e5e1cf1568a8ce3982f0f02de6
+Author: Ryan S. Arnold <rsa@us.ibm.com>
+Date: Tue May 3 17:26:17 2011 -0500
+
+--- glibc.orig/sysdeps/powerpc/powerpc64/Makefile	2012-12-22 19:10:06.713568781 -0800
++++ glibc/sysdeps/powerpc/powerpc64/Makefile	2012-12-22 19:10:50.318605517 -0800
+@@ -31,7 +31,7 @@
+ ifneq ($(elf),no)
+ # The initfini generation code doesn't work in the presence of -fPIC, so
+ # we use -fpic instead which is much better.
+-CFLAGS-initfini.s += -fpic -O1
++CFLAGS-initfini.s += -fpic -O1 -fno-inline
+ endif
+ endif
+ 
diff -r 20f2459b97bf -r 7585f649ad60 patches/glibc/2.14/950-initfini-ppc64.patch
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/glibc/2.14/950-initfini-ppc64.patch	Wed Feb 06 13:11:46 2013 -0800
@@ -0,0 +1,20 @@
+Prevent erroneous inline optimization of initfini.s on PowerPC64.
+
+The problem and the fix was reported there:
+http://sourceware.org/ml/libc-alpha/2012-01/msg00195.html
+Git commit:
+commit 1fe05ea95e1460e5e1cf1568a8ce3982f0f02de6
+Author: Ryan S. Arnold <rsa@us.ibm.com>
+Date: Tue May 3 17:26:17 2011 -0500
+
+--- glibc.orig/sysdeps/powerpc/powerpc64/Makefile	2012-12-22 19:10:06.713568781 -0800
++++ glibc/sysdeps/powerpc/powerpc64/Makefile	2012-12-22 19:10:50.318605517 -0800
+@@ -31,7 +31,7 @@
+ ifneq ($(elf),no)
+ # The initfini generation code doesn't work in the presence of -fPIC, so
+ # we use -fpic instead which is much better.
+-CFLAGS-initfini.s += -fpic -O1
++CFLAGS-initfini.s += -fpic -O1 -fno-inline
+ endif
+ endif
+ 

--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 0 of 1] PowerPC64 target -  fix for glibc build failure
@ 2013-02-06 21:16 Frederic Roussel
  2013-02-06 21:16 ` [PATCH 1 of 1] component: libc/glibc, patch to fix build for PowerPC64 Frederic Roussel
  0 siblings, 1 reply; 3+ messages in thread
From: Frederic Roussel @ 2013-02-06 21:16 UTC (permalink / raw)
  To: Yann E. MORIN; +Cc: crossgcc

Hi,

I've been building cross tools for PowerPC64 and it failed to build glibc.

The exact same failure had previously been discussed elsewhere.
A patch had been submitted too:
http://sourceware.org/ml/libc-alpha/2012-01/msg00195.html
commit 1fe05ea95e1460e5e1cf1568a8ce3982f0f02de6
Author: Ryan S. Arnold <rsa (at) us.ibm.com>
Date: Tue May 3 17:26:17 2011 -0500

This glibc patch doesn't seem to have made it to upstream, so I tried
it out for PowerPC64 with CT-NG 1.18.0

I works for glibc 1.14.1, 1.14 and 1.13. I didn't try for earlier versions
of glibc.

For glibc 2.15 and later there is another build failure that I haven't
investigated yet.

Thanks all,

--Frederic


--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

* libc/glibc: add patch to fix build for PowerPC64.
  2013-02-06 21:16 ` [PATCH 1 of 1] component: libc/glibc, patch to fix build for PowerPC64 Frederic Roussel
@ 2013-02-15 18:30   ` Yann E. MORIN
  0 siblings, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2013-02-15 18:30 UTC (permalink / raw)
  To: Frederic Roussel; +Cc: crossgcc

Frederic, All,

Your patch:
    libc/glibc: add patch to fix build for PowerPC64.

has been applied as: #7209c64d2318
    http://crosstool-ng.org/hg/crosstool-ng/rev/7209c64d2318

Thank you!

Regards,
Yann E. MORIN.



--
For unsubscribe information see http://sourceware.org/lists.html#faq

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-02-15 18:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-06 21:16 [PATCH 0 of 1] PowerPC64 target - fix for glibc build failure Frederic Roussel
2013-02-06 21:16 ` [PATCH 1 of 1] component: libc/glibc, patch to fix build for PowerPC64 Frederic Roussel
2013-02-15 18:30   ` libc/glibc: add " Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).