From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Filipp Andjelo <Filipp.Andjelo@tomtom.com>
Cc: "crossgcc@sourceware.org" <crossgcc@sourceware.org>
Subject: Re: [mingw32] DUMA's missing include
Date: Mon, 17 Jun 2013 22:20:00 -0000 [thread overview]
Message-ID: <20130617221955.GE3202@free.fr> (raw)
In-Reply-To: <51B6C8CD.7020807@tomtom.com>
Filipp, All,
On 2013-06-11 06:49 +0000, Filipp Andjelo spake thusly:
> I just built the i686-unknown-mingw32 toolchain, where I got errors
> about undefined symbol building DUMA. There was one include missing to
> build it for mingw32. It is my first time here and I currently don't
> know a better way to commit a patch. If it was wrong, just tell how I
> could make it better next time :)
No problem, we are ahere to learn! :-)
The patch below is a patch against duma, not against crosstool-NG.
I'd suggest you submit htis patch to upstream DUMA first
Then:
- add this file in patches/duma/2_5_15/100-fix-mingw32-build.patch
- send here a patch that adds this file
Do not forget to sign-off your work:
http://elinux.org/Developer_Certificate_Of_Origin
> diff -durN duma_2_5_15.orig/print.c duma_2_5_15/print.c
> --- duma_2_5_15.orig/print.c 2013-06-11 08:19:32.929986085 +0200
> +++ duma_2_5_15/print.c 2013-06-11 08:21:07.369983168 +0200
> @@ -42,7 +42,7 @@
> #include <windows.h>
> #include <winbase.h>
> #include <io.h>
> -
> + #include <fcntl.h>
Please keep the indentation already used in this file.
> #ifndef __CYGWIN__
> /* already defined in cygwin headers */
> typedef LPVOID caddr_t;
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
--
For unsubscribe information see http://sourceware.org/lists.html#faq
prev parent reply other threads:[~2013-06-17 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 6:49 Filipp Andjelo
2013-06-17 22:20 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617221955.GE3202@free.fr \
--to=yann.morin.1998@free.fr \
--cc=Filipp.Andjelo@tomtom.com \
--cc=crossgcc@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).