From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13608 invoked by alias); 3 Jan 2014 11:40:01 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 13597 invoked by uid 89); 3 Jan 2014 11:40:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f173.google.com Received: from mail-we0-f173.google.com (HELO mail-we0-f173.google.com) (74.125.82.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 03 Jan 2014 11:40:00 +0000 Received: by mail-we0-f173.google.com with SMTP id u57so13322358wes.18 for ; Fri, 03 Jan 2014 03:39:56 -0800 (PST) X-Received: by 10.180.187.229 with SMTP id fv5mr1590827wic.24.1388749196852; Fri, 03 Jan 2014 03:39:56 -0800 (PST) Received: from ymorin.is-a-geek.org (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id jw4sm35193462wjc.20.2014.01.03.03.39.54 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 03 Jan 2014 03:39:56 -0800 (PST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Fri, 03 Jan 2014 12:39:53 +0100 Date: Fri, 03 Jan 2014 11:40:00 -0000 From: "Yann E. MORIN" To: Niels Penneman Cc: crossgcc@sourceware.org Subject: Re: [PATCH] cc/gcc: fix gcc 4.8 build for C library without threads support Message-ID: <20140103113953.GA3526@free.fr> References: <309df93f4354c80e05c9.1388743085@i7sb.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <309df93f4354c80e05c9.1388743085@i7sb.local> User-Agent: Mutt/1.5.21 (2012-12-30) X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00015.txt.bz2 Niels, All, On 2014-01-03 10:58 +0100, Niels Penneman spake thusly: > # HG changeset patch > # User Niels Penneman > # Date 1388743068 -3600 > # Fri Jan 03 10:57:48 2014 +0100 > # Node ID 309df93f4354c80e05c950ded710d111c50d7b26 > # Parent 8e2077dfc250877b2182f31cac97bd1292e01026 > cc/gcc: fix gcc 4.8 build for C library without threads support > Signed-off-by: Niels Penneman Usually, we add an empty line after the subject. This scheme is canon for DVCS (Hg, git) to separate the 'subject' from the 'body' of the commit log, and display them correctly. That's a minor nit, I've fixed it here. Also, for this patch, the change is not obvious, so would have needed a bit of explanations in the commit log, eg.: cc/gcc: fix gcc 4.8 build for C library without threads support libatomic calls the pthread primitives, which are not present if the C library lacks threads support, and the build breaks. In this case, just disable the build of libatomic. Signed-off-by: you@there I had to look at libatomic to understand why it would not build without threads. Granted, that was kind of easy, but not obvious. In a commit log that fixes a problem, you have to explain: - what breaks - why it breaks - how you fixed it Anyway, I've applied it nonetheless. Thank you! :-) Regards, Yann E. MORIN. > diff -r 8e2077dfc250 -r 309df93f4354 scripts/build/cc/gcc.sh > --- a/scripts/build/cc/gcc.sh Fri Jan 03 00:13:15 2014 +0100 > +++ b/scripts/build/cc/gcc.sh Fri Jan 03 10:57:48 2014 +0100 > @@ -643,6 +643,11 @@ > if [ -n "${CT_CC_ENABLE_CXX_FLAGS}" ]; then > extra_config+=("--enable-cxx-flags=${CT_CC_ENABLE_CXX_FLAGS}") > fi > + if [ "${CT_CC_GCC_4_8_or_later}" = "y" ]; then > + if [ "${CT_THREADS}" = "none" ]; then > + extra_config+=(--disable-libatomic) > + fi > + fi > if [ "${CT_CC_GCC_LIBMUDFLAP}" = "y" ]; then > extra_config+=(--enable-libmudflap) > else > > -- > For unsubscribe information see http://sourceware.org/lists.html#faq > -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq