From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14155 invoked by alias); 15 Jan 2014 23:17:08 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 14140 invoked by uid 89); 15 Jan 2014 23:17:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 23:17:05 +0000 Received: by mail-wi0-f180.google.com with SMTP id d13so2926005wiw.7 for ; Wed, 15 Jan 2014 15:17:02 -0800 (PST) X-Received: by 10.194.82.105 with SMTP id h9mr5023729wjy.52.1389827822886; Wed, 15 Jan 2014 15:17:02 -0800 (PST) Received: from ymorin.is-a-geek.org (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id q15sm4555688wjw.18.2014.01.15.15.17.00 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 15 Jan 2014 15:17:01 -0800 (PST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Thu, 16 Jan 2014 00:16:59 +0100 Date: Wed, 15 Jan 2014 23:17:00 -0000 From: "Yann E. MORIN" To: Daniel Schultze Cc: crossgcc@sourceware.org Subject: Re: GNU Make Message-ID: <20140115231658.GA17564@free.fr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2012-12-30) X-IsSubscribed: yes X-SW-Source: 2014-01/txt/msg00042.txt.bz2 Daniel, All, On 2014-01-15 14:15 -0800, Daniel Schultze spake thusly: > Guys after working with CT-NG for a bit I found the patch directory > and recreated my patch to work with the existing system: > in $CT_NG/patches/glibc/2.10.1/920-glibc-2.10.1-manual-make.patch Yep, that the correct way to add a new patch. :-) Also, when submitting a patch, you should format it as such (without the leading 4 spaces): component: short description One or more paragraph, if needed that describe in more details the issue you encountered, hy it happens, and how you fixed it. Signed-off-by: Your Real NAME For example, for this patch: libc/glibc: fix glibc-2.10 for use with make-3.82 glibc-2.10's Makefile is broken because it mixes implicit and normal rules: Makefile:235: *** mixed implicit and normal rules. Stop. That's because make-3.82 removed this undocumented feature. Fix that by splitting the rules in two, as was done in: patches/glibc/2.12.1/920-make-382.patch Signed-off-by: you This is all important, to: - quickly find the bug it the history log: subject - understand the bug: first paragraph - confirm the reason: second paragraph - explain the fix: third paragraph - assess the origin of the patch: SoB-line It is not necessary to write long paragraphs, as long as all the relevant information is present. Some doc exists in the tree: docs/7 - Contributing to crosstool-NG.txt docs/C - Misc. tutorials.txt Also, the SoB-line is explained in the doc, above, and there: http://elinux.org/Developer_Certificate_Of_Origin The SoB-line is the only thing I can not add for you. Care to resend with the above suggestions, please? Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq