From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5067 invoked by alias); 5 May 2014 20:10:04 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 5057 invoked by uid 89); 5 May 2014 20:10:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f169.google.com Received: from mail-we0-f169.google.com (HELO mail-we0-f169.google.com) (74.125.82.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 05 May 2014 20:10:02 +0000 Received: by mail-we0-f169.google.com with SMTP id u56so8140991wes.0 for ; Mon, 05 May 2014 13:09:59 -0700 (PDT) X-Received: by 10.180.91.114 with SMTP id cd18mr17483495wib.28.1399320599606; Mon, 05 May 2014 13:09:59 -0700 (PDT) Received: from ymorin.is-a-geek.org (ks3095497.kimsufi.com. [94.23.60.27]) by mx.google.com with ESMTPSA id cd10sm19879489wib.0.2014.05.05.13.09.56 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 05 May 2014 13:09:58 -0700 (PDT) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Mon, 05 May 2014 22:09:55 +0200 Date: Mon, 05 May 2014 20:10:00 -0000 From: "Yann E. MORIN" To: Trevor Woerner Cc: crossgcc@sourceware.org, patches@linaro.org Subject: Re: [PATCH] gcc: skip core pass 1 when it is unnecessary Message-ID: <20140505200955.GB3566@free.fr> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00002.txt.bz2 Trevor, All, Sorry for the delay... :-( On 2014-02-26 11:15 -0500, Trevor Woerner spake thusly: > # HG changeset patch > # User Trevor Woerner > # Date 1393431218 18000 > # Wed Feb 26 11:13:38 2014 -0500 > # Node ID e9f99d9bd902414c8e3f3c6fc36c0fc67f3a7593 > # Parent c727adf1b7bd2c1e891db512871dbe7b26797fa6 > gcc: skip core pass 1 when it is unnecessary > > If neither the Linux headers nor the libc start files are required, skip gcc's > core pass 1 since the build will simply move from pass 1 to pass 2 without > doing any work in between. > > Signed-off-by: Trevor Woerner > > diff -r c727adf1b7bd -r e9f99d9bd902 scripts/build/cc/gcc.sh > --- a/scripts/build/cc/gcc.sh Tue Feb 25 13:34:48 2014 -0500 > +++ b/scripts/build/cc/gcc.sh Wed Feb 26 11:13:38 2014 -0500 > @@ -88,6 +88,14 @@ > return 0 > fi > > + # skip gcc pass 1 if there are no Linux kernel headers > + # nor libc start files to build/process > + if [ "${CT_LIBC}" = "none" -o "${CT_LIBC}" = "newlib" ]; then > + if [ "${CT_BARE_METAL}" = "y" ]; then > + return 0 There is already an escape-point a few lines above: if [ "${CT_CC_CORE_PASSES_NEEDED}" != "y" ]; then return 0 fi Also, LIBC == none or LIBC == newlib is only possible for bare-metal to start with. So, this would be equivalent to not select CC_CORE_PASSES_NEEDED for newlib, right? Regards, Yann E. MORIN. > + fi > + fi > + > core_opts+=( "mode=static" ) > core_opts+=( "host=${CT_BUILD}" ) > core_opts+=( "complibs=${CT_BUILDTOOLS_PREFIX_DIR}" ) -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' -- For unsubscribe information see http://sourceware.org/lists.html#faq