public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
From: Niels Penneman <niels@penneman.org>
To: crossgcc@sourceware.org
Subject: Fwd: Re: binutils/binutils: 2.23.2 is a 2_23_or_later (ie. has gold)
Date: Thu, 02 Jan 2014 09:39:00 -0000	[thread overview]
Message-ID: <52C533E0.4050601@penneman.org> (raw)
In-Reply-To: <52C5335F.8040805@penneman.org>

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]


Yann,

I see you have added support for binutils 2.24.

You have added the BINUTILS_2_24_or_later symbol in Kconfig but
unfortunately BINUTILS_V_2_24 does not select it. You also did not mark
it as experimental; perhaps the latter was intended.

Here's a "suggestion":

======
diff --git a/config/binutils/binutils.in b/config/binutils/binutils.in
index 64ce389..e007e3c 100644
--- a/config/binutils/binutils.in
+++ b/config/binutils/binutils.in
@@ -10,7 +10,9 @@ choice
 
 config BINUTILS_V_2_24
     bool
-    prompt "2.24"
+    prompt "2.24 (EXPERIMENTAL)"
+    depends on EXPERIMENTAL
+    select BINUTILS_2_24_or_later
 
 config BINUTILS_V_2_23_2
     bool
======


On 12/31/2013 12:46 PM, Yann E. MORIN wrote:
> Yann, All,
>
> Your patch:
>     binutils/binutils: 2.23.2 is a 2_23_or_later (ie. has gold)
>
> has been applied as: #7b7d953f9cfb
>     http://crosstool-ng.org/hg/crosstool-ng/rev/7b7d953f9cfb
>
> Thank you!
>
> Regards,
> Yann E. MORIN.
>
>







[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  parent reply	other threads:[~2014-01-02  9:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-31 11:47 Yann E. MORIN
     [not found] ` <52C5335F.8040805@penneman.org>
2014-01-02  9:39   ` Niels Penneman [this message]
     [not found]   ` <20140102205551.GC3417@free.fr>
2014-01-03 10:00     ` Niels Penneman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C533E0.4050601@penneman.org \
    --to=niels@penneman.org \
    --cc=crossgcc@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).