public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
From: Alexey Neyman <stilor@att.net>
To: crossgcc@sourceware.org
Subject: [crosstool-ng/crosstool-ng] 8397ad: Fix the build of elf2flt on Cygwin
Date: Thu, 23 Feb 2017 06:19:00 -0000	[thread overview]
Message-ID: <58ae7ef2182bd_3533fd4593e7c3c170566@hookshot-fe6-cp1-prd.iad.github.net.mail> (raw)

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

  Branch: refs/heads/master
  Home:   https://github.com/crosstool-ng/crosstool-ng
  Commit: 8397ad2c1a71992b441d73802f45be582c37b1e7
      https://github.com/crosstool-ng/crosstool-ng/commit/8397ad2c1a71992b441d73802f45be582c37b1e7
  Author: Alexey Neyman <stilor@att.net>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    A patches/elf2flt/4820f0dbb77cd6564d5fa0817218fe2a1fb99f32/100-no-lcygwin.patch
    M scripts/build/binutils/binutils.sh

  Log Message:
  -----------
  Fix the build of elf2flt on Cygwin

The -lcygwin -lc actually breaks the build: elf2flt picks up the symbols for getopt/optarg via
<getopt.h> in binutils-X.Y/include, where optarg is declared without dllimport attribute.
Therefore it pulls in getopt() from libc/libcygwin, but since optarg is not prefixed with
_imp__, it is pulled from libiberty. But the object file in libiberty also contains getopt()
thus resulting in multiple definitions thereof.

While there, kill extraneous -ldl passed into configure - configure detects -ldl successfully.

Upstream: https://github.com/uclinux-dev/elf2flt/pull/6
Signed-off-by: Alexey Neyman <stilor@att.net>


  Commit: 85ae00c1a6331d7738abb406a1eb59091c8a4535
      https://github.com/crosstool-ng/crosstool-ng/commit/85ae00c1a6331d7738abb406a1eb59091c8a4535
  Author: Alexey Neyman <stilor@att.net>
  Date:   2017-02-22 (Wed, 22 Feb 2017)

  Changed paths:
    A patches/elf2flt/4820f0dbb77cd6564d5fa0817218fe2a1fb99f32/100-no-lcygwin.patch
    M scripts/build/binutils/binutils.sh

  Log Message:
  -----------
  Merge pull request #614 from stilor/elf2flt-cygwin

Fix the build of elf2flt on Cygwin


Compare: https://github.com/crosstool-ng/crosstool-ng/compare/4de4507a6519...85ae00c1a633

                 reply	other threads:[~2017-02-23  6:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58ae7ef2182bd_3533fd4593e7c3c170566@hookshot-fe6-cp1-prd.iad.github.net.mail \
    --to=stilor@att.net \
    --cc=crossgcc@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).