public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
From: Alexey Neyman <stilor@att.net>
To: crossgcc@sourceware.org
Subject: [crosstool-ng/crosstool-ng] c41b96: package/gcc: fix xtensa PR target/65416
Date: Sun, 23 Sep 2018 18:36:00 -0000	[thread overview]
Message-ID: <5ba7dd1162519_56652af2809dcec87891@hookshot-fe-7191cb1.cp1-iad.github.net.mail> (raw)

[-- Attachment #1: Type: text/plain, Size: 2609 bytes --]

  Branch: refs/heads/master
  Home:   https://github.com/crosstool-ng/crosstool-ng
  Commit: c41b9641b1eed68819cc6f174eb7319a6fca5ffc
      https://github.com/crosstool-ng/crosstool-ng/commit/c41b9641b1eed68819cc6f174eb7319a6fca5ffc
  Author: Max Filippov <jcmvbkbc@gmail.com>
  Date:   2018-06-24 (Sun, 24 Jun 2018)

  Changed paths:
    A packages/gcc/5.5.0/0034-xtensa-fix-PR-target-65416.patch
    A packages/gcc/6.4.0/0034-xtensa-fix-PR-target-65416.patch
    A packages/gcc/7.3.0/0022-xtensa-fix-PR-target-65416.patch
    A packages/gcc/8.1.0/0021-xtensa-fix-PR-target-65416.patch

  Log Message:
  -----------
  package/gcc: fix xtensa PR target/65416

gcc-8.1 for xtensa miscompiles uClibc dynamic linker due to gcc PR
target/65416. The build completes successfully, but the binary is
non-functional because the following fragment in the _dl_get_ready_to_run
in ld-uClibc.so overwrites register spill area on stack causing register
corruption in the previous call frame and a subsequent crash:

    419f:       f0c1b2          addi    a11, a1, -16
    41a2:       1ba9            s32i.n  a10, a11, 4
    41a4:       0bc9            s32i.n  a12, a11, 0
    41a6:       5127f2          l32i    a15, a7, 0x144
    41a9:       1765b2          s32i    a11, a5, 92
    41ac:       4e2782          l32i    a8, a7, 0x138
    41af:       146af2          s32i    a15, a10, 80
    41b2:       001b10          movsp   a1, a11

The crash terminates the init process and causes kernel panic.
The fix prevents reordering of movsp opcode and any access to the stack
frame memory and is applicable to all existing gcc versions.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>


  Commit: 8026e6a0139b3f3a4c416c131885d18b8908bf2c
      https://github.com/crosstool-ng/crosstool-ng/commit/8026e6a0139b3f3a4c416c131885d18b8908bf2c
  Author: Alexey Neyman <stilor@att.net>
  Date:   2018-09-23 (Sun, 23 Sep 2018)

  Changed paths:
    A packages/gcc/5.5.0/0034-xtensa-fix-PR-target-65416.patch
    A packages/gcc/6.4.0/0034-xtensa-fix-PR-target-65416.patch
    A packages/gcc/7.3.0/0022-xtensa-fix-PR-target-65416.patch
    A packages/gcc/8.1.0/0021-xtensa-fix-PR-target-65416.patch

  Log Message:
  -----------
  Merge pull request #994 from jcmvbkbc/xtensa-fix-pr65416

package/gcc: fix xtensa PR target/65416


Compare: https://github.com/crosstool-ng/crosstool-ng/compare/af079341393f...8026e6a0139b
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

                 reply	other threads:[~2018-09-23 18:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ba7dd1162519_56652af2809dcec87891@hookshot-fe-7191cb1.cp1-iad.github.net.mail \
    --to=stilor@att.net \
    --cc=crossgcc@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).