Branch: refs/heads/master Home: https://github.com/crosstool-ng/crosstool-ng Commit: eef8eb403340ffb651f1b0067b0daa3fc7d7b7bf https://github.com/crosstool-ng/crosstool-ng/commit/eef8eb403340ffb651f1b0067b0daa3fc7d7b7bf Author: Masahiro Yamada Date: 2018-07-10 (Tue, 10 Jul 2018) Changed paths: M kconfig/symbol.c Log Message: ----------- kconfig: display recursive dependency resolution hint just once Commit 1c199f2878f6 ("kbuild: document recursive dependency limitation / resolution") probably intended to show a hint along with "recursive dependency detected!" error, but it missed to add {...} guard, and the hint is displayed in every loop of the dep_stack traverse, annoyingly. This error was detected by GCC's -Wmisleading-indentation when switching to build-time generation of lexer/parser. scripts/kconfig/symbol.c: In function ‘sym_check_print_recursive’: scripts/kconfig/symbol.c:1150:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (stack->sym == last_sym) ^~ scripts/kconfig/symbol.c:1153:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig-language.txt\n"); ^~~~~~~ I could simply add {...} to surround the three fprintf(), but I rather chose to move the hint after the loop to make the whole message readable. Fixes: 1c199f2878f6 ("kbuild: document recursive dependency limitation / resolution" Signed-off-by: Masahiro Yamada Acked-by: Luis R. Rodriguez [upstream commit e3b03bf29d6b99fab7001fb20c33fe54928c157a] Fixes #1000 Signed-off-by: Chris Packham Commit: a6580b8e8b55345a5a342b5bd96e42c83e640ac5 https://github.com/crosstool-ng/crosstool-ng/commit/a6580b8e8b55345a5a342b5bd96e42c83e640ac5 Author: Alexey Neyman Date: 2018-09-23 (Sun, 23 Sep 2018) Changed paths: M kconfig/symbol.c Log Message: ----------- Merge pull request #1001 from cpackham/kconfig-fix kconfig: display recursive dependency resolution hint just once Compare: https://github.com/crosstool-ng/crosstool-ng/compare/8026e6a0139b...a6580b8e8b55 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.