From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129581 invoked by alias); 23 Sep 2018 18:37:27 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 129566 invoked by uid 89); 23 Sep 2018 18:37:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,KAM_LOTSOFHASH,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:Unknown, chose, displayed, H*Ad:U*crossgcc X-HELO: m69-169.mailgun.net Received: from m69-169.mailgun.net (HELO m69-169.mailgun.net) (166.78.69.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Sep 2018 18:37:25 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=github.com; q=dns/txt; s=mailo; t=1537727844; h=Content-Transfer-Encoding: Content-Type: Mime-Version: Subject: Message-ID: To: Reply-To: From: Date: Sender; bh=APLYmq6ZbvtIKI+GI9LlCoLhS/Hu6LNi/7smW0lQC2o=; b=GSNf679UVF7p9N7wElwCfSv/a0LzlqMyutwjJ/pn7DtAoB6DfYjOyHh1q4REpDPQrR1TWqsv AO+g+uIA/R3Ulzuxrw/bKcx8NKhCirRx1K3FAoDLdo8PPbEYnhqVlS5o7UHdEotFPKHJjNVU Pyn2hD7tVBeK5pFvXgzBr/bGOI0= X-Mailgun-Sending-Ip: 166.78.69.169 X-Mailgun-Sid: WyIwZTgzNyIsICJjcm9zc2djY0Bzb3VyY2V3YXJlLm9yZyIsICI0MGYiXQ== Sender: stilor=att.net@github.com Received: from github.com (Unknown [192.30.252.36]) by mxa.mailgun.org with ESMTP id 5ba7dd63.7f43d42e3d20-smtp-out-n01; Sun, 23 Sep 2018 18:37:23 -0000 (UTC) Date: Sun, 23 Sep 2018 18:37:00 -0000 From: Alexey Neyman Reply-To: Alexey Neyman To: crossgcc@sourceware.org Message-ID: <5ba7dd63c53ae_12792adbbb0b0ec053228@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Subject: [crosstool-ng/crosstool-ng] eef8eb: kconfig: display recursive dependency resolution h... Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="--==_mimepart_5ba7dd63c4ff1_12792adbbb0b0ec053191"; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00009.txt.bz2 ----==_mimepart_5ba7dd63c4ff1_12792adbbb0b0ec053191 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 2584 Branch: refs/heads/master Home: https://github.com/crosstool-ng/crosstool-ng Commit: eef8eb403340ffb651f1b0067b0daa3fc7d7b7bf https://github.com/crosstool-ng/crosstool-ng/commit/eef8eb403340ffb65= 1f1b0067b0daa3fc7d7b7bf Author: Masahiro Yamada Date: 2018-07-10 (Tue, 10 Jul 2018) Changed paths: M kconfig/symbol.c Log Message: ----------- kconfig: display recursive dependency resolution hint just once Commit 1c199f2878f6 ("kbuild: document recursive dependency limitation / resolution") probably intended to show a hint along with "recursive dependency detected!" error, but it missed to add {...} guard, and the hint is displayed in every loop of the dep_stack traverse, annoyingly. This error was detected by GCC's -Wmisleading-indentation when switching to build-time generation of lexer/parser. scripts/kconfig/symbol.c: In function =E2=80=98sym_check_print_recursive=E2= =80=99: scripts/kconfig/symbol.c:1150:3: warning: this =E2=80=98if=E2=80=99 clause = does not guard... [-Wmisleading-indentation] if (stack->sym =3D=3D last_sym) ^~ scripts/kconfig/symbol.c:1153:4: note: ...this statement, but the latter is= misleadingly indented as if it were guarded by the =E2=80=98if=E2=80=99 fprintf(stderr, "For a resolution refer to Documentation/kbuild/kconfig= -language.txt\n"); ^~~~~~~ I could simply add {...} to surround the three fprintf(), but I rather chose to move the hint after the loop to make the whole message readable. Fixes: 1c199f2878f6 ("kbuild: document recursive dependency limitation / re= solution" Signed-off-by: Masahiro Yamada Acked-by: Luis R. Rodriguez [upstream commit e3b03bf29d6b99fab7001fb20c33fe54928c157a] Fixes #1000 Signed-off-by: Chris Packham Commit: a6580b8e8b55345a5a342b5bd96e42c83e640ac5 https://github.com/crosstool-ng/crosstool-ng/commit/a6580b8e8b55345a5= a342b5bd96e42c83e640ac5 Author: Alexey Neyman Date: 2018-09-23 (Sun, 23 Sep 2018) Changed paths: M kconfig/symbol.c Log Message: ----------- Merge pull request #1001 from cpackham/kconfig-fix kconfig: display recursive dependency resolution hint just once Compare: https://github.com/crosstool-ng/crosstool-ng/compare/8026e6a0139b.= ..a6580b8e8b55 **NOTE:** This service has been marked for deprecation: https://devel= oper.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. ----==_mimepart_5ba7dd63c4ff1_12792adbbb0b0ec053191--