public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
From: Alexey Neyman <stilor@att.net>
To: crossgcc@sourceware.org
Subject: [crosstool-ng/crosstool-ng] 21af76: Detect errors in CT_SaveLocal
Date: Sat, 27 Oct 2018 21:04:00 -0000	[thread overview]
Message-ID: <5bd4d2cf72e7e_7dbd2b0035be857477560@hookshot-fe-6e9b612.cp1-iad.github.net.mail> (raw)

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

  Branch: refs/heads/master
  Home:   https://github.com/crosstool-ng/crosstool-ng
  Commit: 21af769802e25d99ef00026372b3e54970643f61
      https://github.com/crosstool-ng/crosstool-ng/commit/21af769802e25d99ef00026372b3e54970643f61
  Author: Alexey Neyman <stilor@att.net>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M scripts/functions

  Log Message:
  -----------
  Detect errors in CT_SaveLocal

The function is called from a conditional and therefore, the CT_OnError
handler is not invoked on failures. Need to return an error and check
for the error return in the caller.

Also, while here, fix the issue that was causing the failure -
move can fail if it crosses a filesystem, so fall back to 'cp+rm' in
that case.

Signed-off-by: Alexey Neyman <stilor@att.net>


  Commit: d2bf59cb7da0940aa3a7bd660f2701f3eb2677fe
      https://github.com/crosstool-ng/crosstool-ng/commit/d2bf59cb7da0940aa3a7bd660f2701f3eb2677fe
  Author: Alexey Neyman <stilor@att.net>
  Date:   2018-10-27 (Sat, 27 Oct 2018)

  Changed paths:
    M scripts/functions

  Log Message:
  -----------
  Merge pull request #1072 from stilor/failure-when-saving

Detect errors in CT_SaveLocal


Compare: https://github.com/crosstool-ng/crosstool-ng/compare/e12e90c798a7...d2bf59cb7da0
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

                 reply	other threads:[~2018-10-27 21:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bd4d2cf72e7e_7dbd2b0035be857477560@hookshot-fe-6e9b612.cp1-iad.github.net.mail \
    --to=stilor@att.net \
    --cc=crossgcc@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).