[PATCH] cc/gcc: remove --enable-symver option

[PATCH] cc/gcc: remove --enable-symver option

[Yann E. MORIN]

# HG changeset patch
# User "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
# Date 1309296085 -7200
# Node ID ac85fc943fc536a243fdfee188905d333da916c5
# Parent  aa833630f29c780332bc43b87e03a49b37bd700a
cc/gcc: remove --enable-symver option

That option is coming from the original crosstool, and is not entirely
understand here.

Moreover, it breaks with newer gcc-s: 4.6.1 now breaks while configuring
libjava (and probably some other libs as well, untested).

There is an related bug report to the gcc BZ:
  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49555

If need be, the old behavior can be restored with:
  CC_CORE_EXTRA_CONFIG_ARRAY="--enable-symver=gnu"
  CC_EXTRA_CONFIG_ARRAY="--enable-symver=gnu"

Reported-by: Bryan Hundven <bryanhundven@gmail.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>

diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
--- a/scripts/build/cc/gcc.sh
+++ b/scripts/build/cc/gcc.sh
@@ -276,7 +276,6 @@
         ${CC_CORE_SYSROOT_ARG}                      \
         "${extra_config[@]}"                        \
         --disable-nls                               \
-        --enable-symvers=gnu                        \
         --enable-languages="${lang_opt}"            \
         "${CT_CC_CORE_EXTRA_CONFIG_ARRAY[@]}"
 
@@ -536,8 +535,6 @@
 
     CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
 
-    # --enable-symvers=gnu really only needed for sh4 to work around a
-    # detection problem only matters for gcc-3.2.x and later, I think.
     # --disable-nls to work around crash bug on ppc405, but also because
     # embedded systems don't really need message catalogs...
     CT_DoExecLog CFG                                \
@@ -556,7 +553,6 @@
         "${extra_config[@]}"                        \
         --with-local-prefix="${CT_SYSROOT_DIR}"     \
         --disable-nls                               \
-        --enable-symvers=gnu                        \
         --enable-c99                                \
         --enable-long-long                          \
         "${CT_CC_EXTRA_CONFIG_ARRAY[@]}"

--
For unsubscribe information see http://sourceware.org/lists.html#faq

Re: [PATCH] cc/gcc: remove --enable-symver option

[Bryan Hundven]

On Tue, Jun 28, 2011 at 2:39 PM, Yann E. MORIN
<yann.morin.1998@anciens.enib.fr> wrote:
> # HG changeset patch
> # User "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
> # Date 1309296085 -7200
> # Node ID ac85fc943fc536a243fdfee188905d333da916c5
> # Parent  aa833630f29c780332bc43b87e03a49b37bd700a
> cc/gcc: remove --enable-symver option
>
> That option is coming from the original crosstool, and is not entirely
> understand here.
>
> Moreover, it breaks with newer gcc-s: 4.6.1 now breaks while configuring
> libjava (and probably some other libs as well, untested).
>
> There is an related bug report to the gcc BZ:
>  http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49555
>
> If need be, the old behavior can be restored with:
>  CC_CORE_EXTRA_CONFIG_ARRAY="--enable-symver=gnu"
>  CC_EXTRA_CONFIG_ARRAY="--enable-symver=gnu"
>
> Reported-by: Bryan Hundven <bryanhundven@gmail.com>
Reviewed-by: Bryan Hundven <bryanhundven@gmail.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
>
> diff --git a/scripts/build/cc/gcc.sh b/scripts/build/cc/gcc.sh
> --- a/scripts/build/cc/gcc.sh
> +++ b/scripts/build/cc/gcc.sh
> @@ -276,7 +276,6 @@
>         ${CC_CORE_SYSROOT_ARG}                      \
>         "${extra_config[@]}"                        \
>         --disable-nls                               \
> -        --enable-symvers=gnu                        \
>         --enable-languages="${lang_opt}"            \
>         "${CT_CC_CORE_EXTRA_CONFIG_ARRAY[@]}"
>
> @@ -536,8 +535,6 @@
>
>     CT_DoLog DEBUG "Extra config passed: '${extra_config[*]}'"
>
> -    # --enable-symvers=gnu really only needed for sh4 to work around a
> -    # detection problem only matters for gcc-3.2.x and later, I think.
>     # --disable-nls to work around crash bug on ppc405, but also because
>     # embedded systems don't really need message catalogs...
>     CT_DoExecLog CFG                                \
> @@ -556,7 +553,6 @@
>         "${extra_config[@]}"                        \
>         --with-local-prefix="${CT_SYSROOT_DIR}"     \
>         --disable-nls                               \
> -        --enable-symvers=gnu                        \
>         --enable-c99                                \
>         --enable-long-long                          \
>         "${CT_CC_EXTRA_CONFIG_ARRAY[@]}"
>

--
For unsubscribe information see http://sourceware.org/lists.html#faq