From: Zhenqiang Chen <zhenqiang.chen@linaro.org>
To: Mike Frysinger <vapier@gentoo.org>
Cc: crossgcc@sourceware.org, "Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [PATCH] scripts: Select the correct "strip" to strip gdbserver for Canadian build
Date: Wed, 19 Sep 2012 08:56:00 -0000 [thread overview]
Message-ID: <CACgzC7CDumsGp2S09eDXtQ1vT9CrX4YJ-3dXTfiWBgA8Go0Z_A@mail.gmail.com> (raw)
In-Reply-To: <201209190205.27782.vapier@gentoo.org>
> could you set a local variable so that you don't have to copy & paste the
> entire command twice ?
> local cross_strip="bin/${CT_TARGET}-strip"
> [[ ${CT_TARGET} == "y" ]] && cross_strip=${CT_TARGET}-strip
> CT_DoExecLog ALL ${cross_strip} ...
Thanks for the comments. Update it as:
exporting patch:
# HG changeset patch
# User Zhenqiang Chen <zhenqiang.chen@linaro.org>
# Date 1348044842 -28800
# Node ID 49dc965c5eada0b4bbef5f7810a259eae5773bb1
# Parent 2858a24a584642e263a920b4214c815c172ed547
scripts: Select the correct "strip" to strip gdbserver for Canadian build.
For Canadian build, we can not run the bin/${CT_TARGET}-strip on the build
system. But ${CT_TARGET}-strip should be on PATH.
Signed-off-by: Zhenqiang Chen <zhenqiang.chen@linaro.org>
diff -r 2858a24a5846 -r 49dc965c5ead scripts/build/internals.sh
--- a/scripts/build/internals.sh Sun Aug 12 07:45:42 2012 -0400
+++ b/scripts/build/internals.sh Wed Sep 19 16:54:02 2012 +0800
@@ -25,8 +25,12 @@
# Strip gdbserver
if [ "${CT_GDB_GDBSERVER}" = "y" ]; then
- CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \
- ${CT_TARGET}/debug-root/usr/bin/gdbserver
+ local cross_strip="bin/${CT_TARGET}-strip"
+ # For Canadian build, we can not run the bin/${CT_TARGET}-strip on
+ # the build system. But ${CT_TARGET}-strip should be on PATH.
+ [ "${CT_CANADIAN}" = "y" ] && cross_strip="${CT_TARGET}-strip"
+ CT_DoExecLog ALL ${cross_strip} ${strip_args} \
+ ${CT_TARGET}/debug-root/usr/bin/gdbserver
fi
# We can not use the version in CT_CC_VERSION because
# of the Linaro stuff. So, harvest the version string
--
For unsubscribe information see http://sourceware.org/lists.html#faq
next prev parent reply other threads:[~2012-09-19 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 5:49 Zhenqiang Chen
2012-09-19 6:05 ` Mike Frysinger
2012-09-19 8:56 ` Zhenqiang Chen [this message]
2012-09-19 21:04 ` Yann E. MORIN
2012-09-20 3:23 ` Zhenqiang Chen
2012-09-25 21:00 ` scripts: Use ${CT_TARGET}-strip to strip gdbserver Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACgzC7CDumsGp2S09eDXtQ1vT9CrX4YJ-3dXTfiWBgA8Go0Z_A@mail.gmail.com \
--to=zhenqiang.chen@linaro.org \
--cc=crossgcc@sourceware.org \
--cc=vapier@gentoo.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).