From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2382 invoked by alias); 19 Sep 2012 08:56:34 -0000 Received: (qmail 2355 invoked by uid 22791); 19 Sep 2012 08:56:31 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ie0-f169.google.com (HELO mail-ie0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 19 Sep 2012 08:56:18 +0000 Received: by ied10 with SMTP id 10so1268850ied.0 for ; Wed, 19 Sep 2012 01:56:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=Z1krlcVhEe65JwfEzInwhDtN4n1zbeAU/51n9Fci264=; b=L7f+xQZK6hF8s5VTDXiWvz970+bjzhg1X/Sm7Uz9Cih7lGyn5iMtt/kq7WfIAy/Is4 TVb9CThP2GuYfr2yDJx4fomje0wZbhhH4Ax/sNxvwExWduf/qR8pJBxcLkpntWKQZf8p 9iBzLClP0S9luLDwvEdaNpDnb57LzA4WYAh/kDZLx4kB0GAjlmfhlR5VKcbH4Pq0Obkm J946mDKrr5Rn6wFEGaQHorsGfwxnew8Nz4PXdG7W6sI+pVPuLWUGIrtZb9z6rSxijioF dPtmOY0Qm7A+Q/e/m6c4hQ9YlY8Ex2AY8Y6Jcbhn6CTyf8pk4g20g8H0paAsJGS2LBxp CvfA== MIME-Version: 1.0 Received: by 10.43.48.129 with SMTP id uw1mr2006602icb.10.1348044978196; Wed, 19 Sep 2012 01:56:18 -0700 (PDT) Received: by 10.231.169.84 with HTTP; Wed, 19 Sep 2012 01:56:18 -0700 (PDT) In-Reply-To: <201209190205.27782.vapier@gentoo.org> References: <201209190205.27782.vapier@gentoo.org> Date: Wed, 19 Sep 2012 08:56:00 -0000 Message-ID: Subject: Re: [PATCH] scripts: Select the correct "strip" to strip gdbserver for Canadian build From: Zhenqiang Chen To: Mike Frysinger Cc: crossgcc@sourceware.org, "Yann E. MORIN" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQmoIg5QG38NoIjBX5d1Y16PfCxheq/u870XEh0JiqZI/bBdBVndDZUQ/K+50mpA72QzjMUS X-IsSubscribed: yes Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00051.txt.bz2 > could you set a local variable so that you don't have to copy & paste the > entire command twice ? > local cross_strip="bin/${CT_TARGET}-strip" > [[ ${CT_TARGET} == "y" ]] && cross_strip=${CT_TARGET}-strip > CT_DoExecLog ALL ${cross_strip} ... Thanks for the comments. Update it as: exporting patch: # HG changeset patch # User Zhenqiang Chen # Date 1348044842 -28800 # Node ID 49dc965c5eada0b4bbef5f7810a259eae5773bb1 # Parent 2858a24a584642e263a920b4214c815c172ed547 scripts: Select the correct "strip" to strip gdbserver for Canadian build. For Canadian build, we can not run the bin/${CT_TARGET}-strip on the build system. But ${CT_TARGET}-strip should be on PATH. Signed-off-by: Zhenqiang Chen diff -r 2858a24a5846 -r 49dc965c5ead scripts/build/internals.sh --- a/scripts/build/internals.sh Sun Aug 12 07:45:42 2012 -0400 +++ b/scripts/build/internals.sh Wed Sep 19 16:54:02 2012 +0800 @@ -25,8 +25,12 @@ # Strip gdbserver if [ "${CT_GDB_GDBSERVER}" = "y" ]; then - CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args} \ - ${CT_TARGET}/debug-root/usr/bin/gdbserver + local cross_strip="bin/${CT_TARGET}-strip" + # For Canadian build, we can not run the bin/${CT_TARGET}-strip on + # the build system. But ${CT_TARGET}-strip should be on PATH. + [ "${CT_CANADIAN}" = "y" ] && cross_strip="${CT_TARGET}-strip" + CT_DoExecLog ALL ${cross_strip} ${strip_args} \ + ${CT_TARGET}/debug-root/usr/bin/gdbserver fi # We can not use the version in CT_CC_VERSION because # of the Linaro stuff. So, harvest the version string -- For unsubscribe information see http://sourceware.org/lists.html#faq