From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14549 invoked by alias); 18 Mar 2014 20:54:05 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 14536 invoked by uid 89); 18 Mar 2014 20:54:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qg0-f50.google.com Received: from mail-qg0-f50.google.com (HELO mail-qg0-f50.google.com) (209.85.192.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 18 Mar 2014 20:54:03 +0000 Received: by mail-qg0-f50.google.com with SMTP id q108so22762171qgd.9 for ; Tue, 18 Mar 2014 13:54:01 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.224.55.140 with SMTP id u12mr38849708qag.0.1395176041120; Tue, 18 Mar 2014 13:54:01 -0700 (PDT) Received: by 10.140.93.226 with HTTP; Tue, 18 Mar 2014 13:54:01 -0700 (PDT) In-Reply-To: <53287A48.6010303@biessmann.de> References: <2f1530b54afcb6a00e1d.1395158786@andreas-mbp.er.biessmann.org> <532875BA.3010201@biessmann.de> <53287A48.6010303@biessmann.de> Date: Tue, 18 Mar 2014 20:54:00 -0000 Message-ID: Subject: Re: [PATCH] configure.ac: respect 'g' variants of libtool/libtoolize From: Bryan Hundven To: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= Cc: Ray Donnelly , "Yann E. MORIN" , "crossgcc@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-03/txt/msg00009.txt.bz2 Andreas, Ray, list, On Tue, Mar 18, 2014 at 9:54 AM, Andreas Bie=DFmann = wrote: > Dear Ray Donnelly, > > On 18.03.14 17:39, Ray Donnelly wrote: >> But using the existing mechanism to specify --with-program=3D is the way >> it is intended to be done, surely? > > I feel this '--with-program=3D' switch is used for tools not available in > $PATH. For example bootstrapping the _whole_ toolchain beginning with > the tools required for ct-ng. > >> Feel free to disagree of course, and if Yann / others want both >> methods then I don't much mind, but you should also implement >> detection for the correct vendor and version of the software specified >> using the configure options: >> >> --with-libtoolize=3D >> --with-objcopy=3D >> --with-objdump=3D >> --with-readelf=3D >> --with-gperf=3D >> >> .. I expect that it might get messy! > > I don't think so. My patch just provides another default name for the > tool in question. In fact it is the correct name where BSD variants and > GNU variants collide. This was done before for make and awk too: > > ---8<--- > andreas@andreas-mbp % grep AC_PATH_ configure.ac > [AC_PATH_PROGS([$1], [$2]) > [AC_PATH_PROGS_FEATURE_CHECK([_BASH], [bash], > [AC_PATH_PROGS_FEATURE_CHECK([_AWK], [awk gawk], > [AC_PATH_PROGS_FEATURE_CHECK([MAKE], [make gmake], > [AC_PATH_PROGS_FEATURE_CHECK([LIBTOOL], [libtool glibtool], > [AC_PATH_PROGS_FEATURE_CHECK([LIBTOOLIZE], [libtoolize glibtoolize], > [AC_PATH_PROGS_FEATURE_CHECK([automake], [automake], > --->8--- > > Best regards > > Andreas Bie=DFmann > >> On Tue, Mar 18, 2014 at 4:35 PM, Andreas Bie=DFmann wrote: >>> Dear Ray Donelly, >>> >>> On 18.03.14 17:10, Ray Donnelly wrote: >>>> Why don't you use: >>>> configure --with-libtool=3Dglibtool >>> >>> well, in fact this is the command I used to get it working in the first >>> place. I however think its worth to give something back to the community >>> and this is a trivial fix others should not stumble upon. >>> >>> Best regards >>> >>> Andreas Bie=DFmann >>> >>>> On Tue, Mar 18, 2014 at 4:06 PM, wrote: >>>>> # HG changeset patch >>>>> # User Andreas Bie=DFmann >>>>> # Date 1395158470 -3600 >>>>> # Tue Mar 18 17:01:10 2014 +0100 >>>>> # Node ID 2f1530b54afcb6a00e1d3ecc2595f588a3dd7315 >>>>> # Parent e11a8a2e225d3fa882c24e05ea097979ba8925eb >>>>> configure.ac: respect 'g' variants of libtool/libtoolize >>>>> >>>>> BSD OS'es (OS X for me) provide GNU tools with prefixed 'g'. To find = correct >>>>> versions of libtool/libtoolize on those systems search also for >>>>> glibtool/glibtoolize. >>>>> >>>>> Signed-off-by: Andreas Bie=DFmann >>>>> >>>>> diff --git a/configure.ac b/configure.ac >>>>> --- a/configure.ac >>>>> +++ b/configure.ac >>>>> @@ -242,7 +242,7 @@ >>>>> [Specify the full PATH to GNU libtool >=3D 1.= 5.26]), >>>>> [ac_cv_path_LIBTOOL=3D$withval])]) >>>>> AC_CACHE_CHECK([for GNU libtool >=3D 1.5.26], [ac_cv_path_LIBTOOL], >>>>> - [AC_PATH_PROGS_FEATURE_CHECK([LIBTOOL], [libtool], >>>>> + [AC_PATH_PROGS_FEATURE_CHECK([LIBTOOL], [libtool glibtool], >>>>> [[LIBTOOL_ver=3D$($ac_path_LIBTOOL --version 2>&1 \ >>>>> |$EGREP '\(GNU libtool.*\) (2[[:digit:]]*\.|= 1\.6[[:digit:]]*\.|1\.5\.[2-9][[:digit:]]+)') >>>>> test -n "$LIBTOOL_ver" && ac_cv_path_LIBTOOL=3D$ac_path_LI= BTOOL ac_path_LIBTOOL_found=3D:]], >>>>> @@ -258,7 +258,7 @@ >>>>> [Specify the full PATH to GNU libtoolize >=3D= 1.5.26]), >>>>> [ac_cv_path_LIBTOOLIZE=3D$withval])]) >>>>> AC_CACHE_CHECK([for GNU libtoolize >=3D 1.5.26], [ac_cv_path_LIBTOOL= IZE], >>>>> - [AC_PATH_PROGS_FEATURE_CHECK([LIBTOOLIZE], [libtoolize], >>>>> + [AC_PATH_PROGS_FEATURE_CHECK([LIBTOOLIZE], [libtoolize glibtooli= ze], >>>>> [[LIBTOOLIZE_ver=3D$($ac_path_LIBTOOLIZE --version 2>&1 \ >>>>> |$EGREP '\(GNU libtool.*\) (2[[:digit:]]*\.|= 1\.6[[:digit:]]*\.|1\.5\.[2-9][[:digit:]]+)') >>>>> test -n "$LIBTOOLIZE_ver" && ac_cv_path_LIBTOOLIZE=3D$ac_p= ath_LIBTOOLIZE ac_path_LIBTOOLIZE_found=3D:]], >>> >> >> -- >> For unsubscribe information see http://sourceware.org/lists.html#faq >> > > > -- > For unsubscribe information see http://sourceware.org/lists.html#faq > I was about to make a patch for this myself. So I'm in: Signed-off-by: Bryan Hundven -Bryan -- For unsubscribe information see http://sourceware.org/lists.html#faq