public inbox for crossgcc@sourceware.org
 help / color / mirror / Atom feed
From: Bryan Hundven <bryanhundven@gmail.com>
To: "Jason T. Masker" <jason@masker.net>
Cc: crossgcc <crossgcc@sourceware.org>
Subject: Re: [PATCH 1/2][RESEND] Prevent zconf.gperf from throwing an error on OSX
Date: Fri, 05 Dec 2014 11:26:00 -0000	[thread overview]
Message-ID: <CAJ+oik2aJUbELYXnt=iEwB0ryst=U_tV9VAkHC5ttYEbHyVy6A@mail.gmail.com> (raw)
In-Reply-To: <CAEFQu-GfdH0i1C0p5p_4rO7bD5VF0Y-suaEJWp1_hiOYZROnrg@mail.gmail.com>

Jason,

On Thu, Oct 16, 2014 at 9:51 AM, Jason T. Masker <jason@masker.net> wrote:
> Updated zconf.gperf patch to be conditional.
>
> The problem is when compiling with clang/LLVM, so not necessarily
> specific to OS X. Offsetof is part of C99 and defined in stddef.h, but
> is builtin with gcc. This code will check for a definition and try
> including stddef.h if it is not found. As a last resort, offsetof will
> be defined. Apologies for the resend. I did not sign off.
>
> Signed-off-by: Jason Masker <jason@masker.net>
>
>
> diff --git a/kconfig/zconf.gperf b/kconfig/zconf.gperf
> index c9e690e..d758a2a 100644
> --- a/kconfig/zconf.gperf
> +++ b/kconfig/zconf.gperf
> @@ -7,6 +7,15 @@
>  %pic
>  %struct-type
>
> +%{
> +# ifndef offsetof
> +#  include <stddef.h>
> +#  ifndef offsetof
> +#   define offsetof(st, m) ((size_t)(&((st *)0)->m))
> +#  endif
> +# endif
> +%}
> +
>  struct kconf_id;
>
>  static struct kconf_id *kconf_id_lookup(register const char *str,
> register unsigned int len);

Dang, I wanted to apply this but the patch did not apply cleanly.
Would you mind rebasing this patch with latest head and resending?
Then I'll finally get this bad boy applied.

Thanks,

-Bryan

--
For unsubscribe information see http://sourceware.org/lists.html#faq

  reply	other threads:[~2014-12-05 11:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 16:52 Jason T. Masker
2014-12-05 11:26 ` Bryan Hundven [this message]
2014-12-15  2:17   ` Jason T. Masker
2015-01-09  3:25     ` Bryan Hundven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ+oik2aJUbELYXnt=iEwB0ryst=U_tV9VAkHC5ttYEbHyVy6A@mail.gmail.com' \
    --to=bryanhundven@gmail.com \
    --cc=crossgcc@sourceware.org \
    --cc=jason@masker.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).