From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16625 invoked by alias); 4 Feb 2014 20:14:38 -0000 Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org Received: (qmail 16611 invoked by uid 89); 4 Feb 2014 20:14:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f49.google.com Received: from mail-qa0-f49.google.com (HELO mail-qa0-f49.google.com) (209.85.216.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 04 Feb 2014 20:14:36 +0000 Received: by mail-qa0-f49.google.com with SMTP id w8so12924769qac.22 for ; Tue, 04 Feb 2014 12:14:34 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.140.37.146 with SMTP id r18mr65611292qgr.61.1391544874720; Tue, 04 Feb 2014 12:14:34 -0800 (PST) Received: by 10.140.94.151 with HTTP; Tue, 4 Feb 2014 12:14:34 -0800 (PST) In-Reply-To: References: Date: Tue, 04 Feb 2014 20:14:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] {e}glibc: Fix various multilib build bugs From: Bryan Hundven To: Ray Donnelly Cc: "crossgcc@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2014-02/txt/msg00018.txt.bz2 Ray, Cody, list, On Tue, Feb 4, 2014 at 10:49 AM, Ray Donnelly wrote: > Here is the new version using Cody's get_multilib_target () function. > > Cheers, > > Ray. I have some comments on this commit, but it's attached :( I recommend using the patchbomb method: http://crosstool-ng.org/hg/crosstool-ng/file/529a71ea091e/docs/C%20-%20Misc.%20tutorials.txt#l183 Anyways, it seems to me that get_multilib_target should be stubbed in scripts/build/arch/multilib.sh, and implemented in the respective scripts/build/arch/.sh Source multilib.sh after this line: http://crosstool-ng.org/hg/crosstool-ng/file/529a71ea091e/scripts/crosstool-NG.sh.in#l140 That way, any package - beyond (e)glibc - can obtain the multilib target info if needed. Other points are easier to discuss inline. Cody, Ray; what are your thoughts? -Bryan -- For unsubscribe information see http://sourceware.org/lists.html#faq