From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26357 invoked by alias); 23 Nov 2011 02:41:04 -0000 Received: (qmail 26297 invoked by uid 22791); 23 Nov 2011 02:41:01 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 02:40:38 +0000 Received: by faas10 with SMTP id s10so1433446faa.0 for ; Tue, 22 Nov 2011 18:40:37 -0800 (PST) Received: by 10.152.134.77 with SMTP id pi13mr13628725lab.21.1322016037262; Tue, 22 Nov 2011 18:40:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.152.24.36 with HTTP; Tue, 22 Nov 2011 18:40:06 -0800 (PST) In-Reply-To: References: <4ECB854F.1050809@linaro.org> <201111221821.22751.yann.morin.1998@anciens.enib.fr> From: Khem Raj Date: Wed, 23 Nov 2011 02:41:00 -0000 Message-ID: Subject: Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS To: Michael Hope Cc: "Yann E. MORIN" , crossgcc@sourceware.org, Zhenqiang Chen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00144.txt.bz2 On Tue, Nov 22, 2011 at 5:48 PM, Michael Hope wro= te: > On Wed, Nov 23, 2011 at 6:21 AM, Yann E. MORIN > wrote: >> Zhenqiang, All, >> >> On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote: >>> # HG changeset patch >>> # User Zhenqiang Chen >>> # Date 1321604572 -28800 >>> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd >>> # Parent =C2=A0a6c68712024f406df7d2da4af377f51982615833 >>> debug/gdb: --disable-sim for CT_GDB_CROSS. >>> >>> sim was already disabled for CT_GDB_NATIVE. >>> >>> Reviewed-by: Michael Hope >>> Signed-off-by: Zhenqiang Chen >>> >>> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-g= db. >>> --- a/scripts/build/debug/300-gdb.sh >>> +++ b/scripts/build/debug/300-gdb.sh >>> @@ -146,6 +146,7 @@ >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-build-sysroot= =3D"${CT_SYSROOT_DIR}" =C2=A0 =C2=A0\ >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-sysroot=3D"${CT= _SYSROOT_DIR}" =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0\ >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --with-expat=3Dyes =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0\ >>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0--disable-sim =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 \ >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 --disable-werror =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0\ >>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "${cross_extra_config[= @]}" >> >> Your mailer is mangling every patch, by adding a leading space to every >> line that start with a space, so the patches do not apply cleanly. I will >> be fixing that locally, no need to resend. >> >> Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the >> cross-gdb? If the build is broken for some archs, it should rather be >> fixed. At least, disabling/enabling 'sim' should be a config option, >> so users that want to try and/or fix it have an easy way to. > > I'd like to disable sim as it isn't useful when building for a GLIBC > target and it's one more thing to support. =C2=A0ARM don't want to > distribute a binary simulator due to IP reasons which I must admit > I've never understood :) > > How about a GDB_CROSS_EXTRA_CONFIG_ARRAY instead? =C2=A0Disabling the > simulator is rare enough that it shouldn't be an option on it's own. disabling it for glibc and uclibc toolchains is fine however it should be left enabled for bare metal toolchains > > -- Michael > > -- > For unsubscribe information see http://sourceware.org/lists.html#faq > > -- For unsubscribe information see http://sourceware.org/lists.html#faq