From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9494 invoked by alias); 15 Nov 2011 02:42:40 -0000 Received: (qmail 9428 invoked by uid 22791); 15 Nov 2011 02:42:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Nov 2011 02:42:26 +0000 Received: by wwp14 with SMTP id 14so4942827wwp.12 for ; Mon, 14 Nov 2011 18:42:25 -0800 (PST) Received: by 10.180.90.19 with SMTP id bs19mr28042443wib.7.1321324945052; Mon, 14 Nov 2011 18:42:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.82.2 with HTTP; Mon, 14 Nov 2011 18:42:04 -0800 (PST) In-Reply-To: <201111142217.33054.yann.morin.1998@anciens.enib.fr> References: <02572d8009f6a872ccd2.1321225822@crucis> <201111140820.57656.yann.morin.1998@anciens.enib.fr> <201111142217.33054.yann.morin.1998@anciens.enib.fr> From: Michael Hope Date: Tue, 15 Nov 2011 02:42:00 -0000 Message-ID: Subject: Re: [PATCH] configure: support arbitrary versions via a shell script To: "Yann E. MORIN" Cc: crossgcc@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00056.txt.bz2 On Tue, Nov 15, 2011 at 10:17 AM, Yann E. MORIN wrote: > Michael, All, > > On Monday 14 November 2011 21:37:15 Michael Hope wrote: >> That sounds good. =A0There's a minor bug in your version: =A0./configure >> --help uses the version from .version instead of version.sh as >> do_help() is called before version.sh is updated. >> >> Then again, it had a similar problem before the patch: ./configure >> --help would report crosstool-NG-hg instead of the full >> crosstool-NG-hg-revno-foo. > > Indeed, the /issue/ was there previously as well. > So, it is not a regression! ;-) > >> Let me know if it's important and I can make a patch, > > I understand it could be confusing. > =A0- the easy way is to remove the version string from the help entry; > =A0- the proper way would be to move the version computation upward, but > =A0 it needs ${sed} that is available only after the tests, which do not > =A0 get run for --help. > > So, we could just move the version calculations upward, print the pristine > version string in --help, and just mangle the string at the moment we need > it and can do it. > > If the sight of the incorrect version string is absolutely untenable for > you, if your screen turns itself off so you don't get to see it, if you > lose your sanity at the mere thought of seeing the raw version, then by > all means, send a patch! ;-) The current version is fine, -- Michael the nit-picker -- For unsubscribe information see http://sourceware.org/lists.html#faq