From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26214 invoked by alias); 23 Nov 2011 01:48:53 -0000 Received: (qmail 26078 invoked by uid 22791); 23 Nov 2011 01:48:52 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-ww0-f43.google.com (HELO mail-ww0-f43.google.com) (74.125.82.43) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Nov 2011 01:48:37 +0000 Received: by wwo1 with SMTP id 1so917738wwo.12 for ; Tue, 22 Nov 2011 17:48:36 -0800 (PST) Received: by 10.181.13.82 with SMTP id ew18mr22261110wid.16.1322012916332; Tue, 22 Nov 2011 17:48:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.180.82.2 with HTTP; Tue, 22 Nov 2011 17:48:15 -0800 (PST) In-Reply-To: <201111221821.22751.yann.morin.1998@anciens.enib.fr> References: <4ECB854F.1050809@linaro.org> <201111221821.22751.yann.morin.1998@anciens.enib.fr> From: Michael Hope Date: Wed, 23 Nov 2011 01:48:00 -0000 Message-ID: Subject: Re: [PATCH] debug/gdb: --disable-sim for CT_GDB_CROSS To: "Yann E. MORIN" Cc: crossgcc@sourceware.org, Zhenqiang Chen Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact crossgcc-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: crossgcc-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00143.txt.bz2 On Wed, Nov 23, 2011 at 6:21 AM, Yann E. MORIN wrote: > Zhenqiang, All, > > On Tuesday 22 November 2011 12:19:43 Zhenqiang Chen wrote: >> # HG changeset patch >> # User Zhenqiang Chen >> # Date 1321604572 -28800 >> # Node ID 2d6b11f65d7cfa0802e2db9a23363d04be44eecd >> # Parent =A0a6c68712024f406df7d2da4af377f51982615833 >> debug/gdb: --disable-sim for CT_GDB_CROSS. >> >> sim was already disabled for CT_GDB_NATIVE. >> >> Reviewed-by: Michael Hope >> Signed-off-by: Zhenqiang Chen >> >> diff --git a/scripts/build/debug/300-gdb.sh b/scripts/build/debug/300-gd= b. >> --- a/scripts/build/debug/300-gdb.sh >> +++ b/scripts/build/debug/300-gdb.sh >> @@ -146,6 +146,7 @@ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 --with-build-sysroot=3D"${CT_SYSROOT_DIR}" = =A0 =A0\ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 --with-sysroot=3D"${CT_SYSROOT_DIR}" =A0 =A0= =A0 =A0 =A0\ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 --with-expat=3Dyes =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0\ >> + =A0 =A0 =A0 =A0 =A0 =A0--disable-sim =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 =A0 =A0 =A0 =A0 =A0 \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 --disable-werror =A0 =A0 =A0 =A0 =A0 =A0 =A0= =A0 =A0 =A0 =A0 =A0 =A0 =A0\ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 "${cross_extra_config[@]}" > > Your mailer is mangling every patch, by adding a leading space to every > line that start with a space, so the patches do not apply cleanly. I will > be fixing that locally, no need to resend. > > Otherwise, I agree with Mike: Why is it needed to disable 'sim' in the > cross-gdb? If the build is broken for some archs, it should rather be > fixed. At least, disabling/enabling 'sim' should be a config option, > so users that want to try and/or fix it have an easy way to. I'd like to disable sim as it isn't useful when building for a GLIBC target and it's one more thing to support. ARM don't want to distribute a binary simulator due to IP reasons which I must admit I've never understood :) How about a GDB_CROSS_EXTRA_CONFIG_ARRAY instead? Disabling the simulator is rare enough that it shouldn't be an option on it's own. -- Michael -- For unsubscribe information see http://sourceware.org/lists.html#faq